From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1N7sQo-0004te-91
	for qemu-devel@nongnu.org; Tue, 10 Nov 2009 10:14:54 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1N7sQj-0004nu-8K
	for qemu-devel@nongnu.org; Tue, 10 Nov 2009 10:14:53 -0500
Received: from [199.232.76.173] (port=56992 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1N7sQi-0004nb-Uq
	for qemu-devel@nongnu.org; Tue, 10 Nov 2009 10:14:49 -0500
Received: from mail-px0-f203.google.com ([209.85.216.203]:42312)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <scottt.tw@gmail.com>) id 1N7sQi-0007om-JA
	for qemu-devel@nongnu.org; Tue, 10 Nov 2009 10:14:48 -0500
Received: by pxi41 with SMTP id 41so64089pxi.19
	for <qemu-devel@nongnu.org>; Tue, 10 Nov 2009 07:14:47 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <4AF97D3B.8080601@redhat.com>
References: <1257845850-4660-1-git-send-email-scottt.tw@gmail.com>
	<1257845850-4660-2-git-send-email-scottt.tw@gmail.com>
	<1257845850-4660-3-git-send-email-scottt.tw@gmail.com>
	<4AF97D3B.8080601@redhat.com>
Date: Tue, 10 Nov 2009 23:14:47 +0800
Message-ID: <ef2f888d0911100714k351de5b8hea3a2b48935bde25@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH V2 2/3] usb-gotemp: new module emulating a
	USB thermometer
From: Scott Tsai <scottt.tw@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: qemu-devel@nongnu.org

>> + =C2=A0 =C2=A0s->temperature++;
>>
> You're going to overheat very quickly.
> Apart from making the driver work, is this actually useful?

I wanted the temperature to change with time to give a sense of
"something is happening" ^_^

The main user I had in mind was someone new to USB and Linux driver develop=
ment
following gregkh's driver tutorial:
http://www.kroah.com/linux/talks/ols_2005_driver_tutorial/
My thinking was that if the temperature never changes, all the USB
packets generated in the 'read_int_callback"
part of the driver would seem like a waste of effort.