From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N7ut8-0000yk-9J for qemu-devel@nongnu.org; Tue, 10 Nov 2009 12:52:18 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N7ut3-0000yI-K9 for qemu-devel@nongnu.org; Tue, 10 Nov 2009 12:52:17 -0500 Received: from [199.232.76.173] (port=53438 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N7ut3-0000yF-HC for qemu-devel@nongnu.org; Tue, 10 Nov 2009 12:52:13 -0500 Received: from mail-pw0-f43.google.com ([209.85.160.43]:64274) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N7ut3-0002t1-5c for qemu-devel@nongnu.org; Tue, 10 Nov 2009 12:52:13 -0500 Received: by pwi12 with SMTP id 12so164196pwi.2 for ; Tue, 10 Nov 2009 09:52:12 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20091110150630.19b0c3fa@doriath> References: <1257845850-4660-1-git-send-email-scottt.tw@gmail.com> <1257845850-4660-2-git-send-email-scottt.tw@gmail.com> <1257845850-4660-3-git-send-email-scottt.tw@gmail.com> <4AF97D3B.8080601@redhat.com> <374D220D-FE6E-410B-83F3-E8988BA61A6D@suse.de> <20091110150630.19b0c3fa@doriath> Date: Wed, 11 Nov 2009 01:52:12 +0800 Message-ID: Subject: Re: [Qemu-devel] [PATCH V2 2/3] usb-gotemp: new module emulating a USB thermometer From: Scott Tsai Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: qemu-devel@nongnu.org, Alexander Graf , Avi Kivity On Wed, Nov 11, 2009 at 1:06 AM, Luiz Capitulino w= rote: >> >> I'd certainly like to make this code useful for something other than >> developer training. >> How about a new monitor command "thermometer_set" that works like "mouse= _move"? >> "thermometer_set" would just set the temperature of the "first" >> thermometer device it finds. > > =C2=A0Couldn't the device be a parameter? > > =C2=A0And I'd suggest usb_therm_set for the name. > Looking at the existing "mouse_set" and "mouse_move" monitor commands, they work on USB, PS/2 and other kinds of mice with "mouse_set" selecting the mouse device affected by "mouse_move". So how about a new command "therm_set" which selects the thermometer affected by "therm_temp" ? On a separate note, I understand that if a piece of code is not useful enou= gh we don't want to merge it to add to the maintenance burden. I still propose 'usb-gotemp' for merging because the fact that gregkh could give his driver tutorial several years in a roll to sizable audiences shows that there are people out there interested in getting into Linux driver development. With this code merged, people could follow the video and slides of his talk without special hardware and this potentially grows the Linux developer poo= l.