From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1N82fQ-0003FK-JA
	for qemu-devel@nongnu.org; Tue, 10 Nov 2009 21:10:40 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1N82fK-0003Ai-RV
	for qemu-devel@nongnu.org; Tue, 10 Nov 2009 21:10:39 -0500
Received: from [199.232.76.173] (port=39437 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1N82fK-0003AO-MK
	for qemu-devel@nongnu.org; Tue, 10 Nov 2009 21:10:34 -0500
Received: from mail-pz0-f188.google.com ([209.85.222.188]:60734)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <scottt.tw@gmail.com>) id 1N82fK-0007LR-BJ
	for qemu-devel@nongnu.org; Tue, 10 Nov 2009 21:10:34 -0500
Received: by pzk26 with SMTP id 26so432955pzk.4
	for <qemu-devel@nongnu.org>; Tue, 10 Nov 2009 18:10:33 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <4AFA00D6.9030107@codemonkey.ws>
References: <1257845850-4660-1-git-send-email-scottt.tw@gmail.com>
	<1257845850-4660-2-git-send-email-scottt.tw@gmail.com>
	<1257845850-4660-3-git-send-email-scottt.tw@gmail.com>
	<4AF97D3B.8080601@redhat.com>
	<ef2f888d0911100714k351de5b8hea3a2b48935bde25@mail.gmail.com>
	<374D220D-FE6E-410B-83F3-E8988BA61A6D@suse.de>
	<ef2f888d0911100755q1052f2bw7462bee445a7556a@mail.gmail.com>
	<20091110150630.19b0c3fa@doriath>
	<ef2f888d0911100952s557d9364w87913352b37fc4dd@mail.gmail.com>
	<4AFA00D6.9030107@codemonkey.ws>
Date: Wed, 11 Nov 2009 10:10:32 +0800
Message-ID: <ef2f888d0911101810s2191e96fm63fb60e7b7c8f147@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH V2 2/3] usb-gotemp: new module emulating a
	USB thermometer
From: Scott Tsai <scottt.tw@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Alexander Graf <agraf@suse.de>, Avi Kivity <avi@redhat.com>, Greg KH <gregkh@suse.de>, qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>

On Wed, Nov 11, 2009 at 8:09 AM, Anthony Liguori <anthony@codemonkey.ws> wr=
ote:
> That said, if we position this as an example device, I think that makes
> sense. =C2=A0But that suggests that we should document the heck out of it=
 and
> make it a learning experience for QEMU too. =C2=A0It could be an example =
of how
> to write a simple QEMU device emulation.
>
> That would be interesting independent of Greg's tutorial.

Thinking about how to document the 'usb-gotemp' code better:
I could improve the comments describing the packet format used by the devic=
e.

While writing the code, I remember thinking the methods in
USBDeviceInfo are fairly straight forward and getting into USB device
development through QEMU is much more pleasant then writing firmware
for memory constrained PIC and AVR microcontrollers.

I'll go off to run some errands now, I'm very willing to make any
suggested changes.