From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51621) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c3pYJ-0007sB-E7 for qemu-devel@nongnu.org; Mon, 07 Nov 2016 14:25:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c3pYF-0007rO-WC for qemu-devel@nongnu.org; Mon, 07 Nov 2016 14:25:55 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:43104) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c3pYF-0007qs-MO for qemu-devel@nongnu.org; Mon, 07 Nov 2016 14:25:51 -0500 Received: from pps.filterd (m0098393.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id uA7JNqDC036456 for ; Mon, 7 Nov 2016 14:25:50 -0500 Received: from e06smtp05.uk.ibm.com (e06smtp05.uk.ibm.com [195.75.94.101]) by mx0a-001b2d01.pphosted.com with ESMTP id 26jv0a3933-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Mon, 07 Nov 2016 14:25:50 -0500 Received: from localhost by e06smtp05.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 7 Nov 2016 19:25:48 -0000 References: <1478257275-30365-1-git-send-email-mst@redhat.com> <1478257275-30365-3-git-send-email-mst@redhat.com> From: Halil Pasic Date: Mon, 7 Nov 2016 20:25:44 +0100 MIME-Version: 1.0 In-Reply-To: <1478257275-30365-3-git-send-email-mst@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Message-Id: Subject: Re: [Qemu-devel] [PATCH 2/2] virtio-net: mark VIRTIO_NET_F_GSO as legacy List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" , qemu-devel@nongnu.org Cc: Jason Wang , dgilbert@redhat.com, qemu-stable@nongnu.org On 11/04/2016 12:01 PM, Michael S. Tsirkin wrote: > virtio 1.0 spec says this is a legacy feature bit, > hide it from guests in legacy mode. > Probably the other way around: since its legacy it is supposed to be hidden from non-legacy )and exposed to legacy) or? > Note: for cross-version migration compatibility, > we keep the bit set in host_features. > The result will be that a guest migrating cross-version > will see host features change under it. > As guests only seem to read it once, this should > not be an issue. Meanwhile, will work to fix guests to > ignore this bit in virtio1 mode, too. > Makes sense to me (except for the probably typo). Regards, Halil > Cc: qemu-stable@nongnu.org > Signed-off-by: Michael S. Tsirkin > --- > hw/net/virtio-net.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c > index 20aa63e..b68c69d 100644 > --- a/hw/net/virtio-net.c > +++ b/hw/net/virtio-net.c > @@ -1942,6 +1942,7 @@ static void virtio_net_class_init(ObjectClass *klass, void *data) > vdc->guest_notifier_pending = virtio_net_guest_notifier_pending; > vdc->load = virtio_net_load_device; > vdc->save = virtio_net_save_device; > + vdc->legacy_features |= (0x1 << VIRTIO_NET_F_GSO); > } > > static const TypeInfo virtio_net_info = { >