From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: "Cédric Le Goater" <clg@kaod.org>,
"John Wang" <wangzhiqiang.bj@bytedance.com>,
xuxiaohan@bytednace.com, yulei.sh@bytedance.com, joel@jms.id.au
Cc: Peter Maydell <peter.maydell@linaro.org>,
"open list:ARM TCG CPUs" <qemu-arm@nongnu.org>,
"open list:All patches CC here" <qemu-devel@nongnu.org>
Subject: Re: [PATCH v2 1/2] hw/misc: add an EMC141{3,4} device model
Date: Sat, 24 Oct 2020 19:33:40 +0200 [thread overview]
Message-ID: <ef53dba9-431e-bd9e-df92-cedb6a75e4c6@amsat.org> (raw)
In-Reply-To: <19801c31-77e3-f51f-24ce-124ae65cd698@kaod.org>
On 10/8/20 7:19 PM, Cédric Le Goater wrote:
> On 10/8/20 11:02 AM, John Wang wrote:
>> Largely inspired by the TMP421 temperature sensor, here is a model for
>> the EMC1413 temperature sensors.
>>
>> Specs can be found here :
>> https://pdf1.alldatasheet.com/datasheet-pdf/view/533713/SMSC/EMC1413.html
>>
>> Signed-off-by: John Wang <wangzhiqiang.bj@bytedance.com>
>
> Reviewed-by: Cédric Le Goater <clg@kaod.org>
>
>> ---
>> v2:
>> - Remove DeviceInfo
>
> I will look at doing the same in TMP421. All the temperature devices
> have a lot in common.
>
> Philippe,
>
> Did you have a patchset introducing a common framework ?
Yes, based on this (but probably using QOM path instead of ID):
https://www.mail-archive.com/qemu-devel@nongnu.org/msg697031.html
I plan to respin once the 5.2 is released.
>
> Thanks,
>
> C.
next prev parent reply other threads:[~2020-10-24 17:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-08 9:02 [PATCH v2 1/2] hw/misc: add an EMC141{3,4} device model John Wang
2020-10-08 9:02 ` [PATCH v2 2/2] aspeed: Add support for the g220a-bmc board John Wang
2020-10-08 17:19 ` [PATCH v2 1/2] hw/misc: add an EMC141{3,4} device model Cédric Le Goater
2020-10-24 9:25 ` [External] Re: [PATCH v2 1/2] hw/misc: add an EMC141{3, 4} " John Wang
2020-10-24 17:33 ` Philippe Mathieu-Daudé [this message]
2020-10-24 17:32 ` [PATCH v2 1/2] hw/misc: add an EMC141{3,4} " Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef53dba9-431e-bd9e-df92-cedb6a75e4c6@amsat.org \
--to=f4bug@amsat.org \
--cc=clg@kaod.org \
--cc=joel@jms.id.au \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=wangzhiqiang.bj@bytedance.com \
--cc=xuxiaohan@bytednace.com \
--cc=yulei.sh@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).