Re: [Qemu-devel] [PATCH RESEND] Makefile: Remove qemu-version.h and qemu-options.def during 'make distclean'

[Eric Blake <eblake@redhat.com>]

On 06/08/2018 02:01 PM, Philippe Mathieu-Daudé wrote:
> qemu-version.h and qemu-options.def are generated files
> that should be deleted during 'make distclean'.
> 
> This solves building issues with out-of-tree builds from
> a source tree that has been built in (see d1bd2423a90):

Well, it prevents future repeats of the problem. It does not "fix" 
existing incremental builds that already have the problem.  But I'm 
still in favor of this change.


> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> resend: Cc Peter, removed dup line in comment
> 
>   Makefile | 1 +
>   1 file changed, 1 insertion(+)
> 

Reviewed-by: Eric Blake <eblake@redhat.com>

> diff --git a/Makefile b/Makefile
> index 023b3437ec..7ae453ffa2 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -757,6 +757,7 @@ qemu-%.tar.bz2:
>   distclean: clean
>   	rm -f config-host.mak config-host.h* config-host.ld $(DOCS) qemu-options.texi qemu-img-cmds.texi qemu-monitor.texi qemu-monitor-info.texi
>   	rm -f config-all-devices.mak config-all-disas.mak config.status
> +	rm -f qemu-version.h qemu-options.def
>   	rm -f po/*.mo tests/qemu-iotests/common.env
>   	rm -f roms/seabios/config.mak roms/vgabios/config.mak
>   	rm -f qemu-doc.info qemu-doc.aux qemu-doc.cp qemu-doc.cps
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org