From: Richard Henderson <richard.henderson@linaro.org>
To: Anton Johansson <anjo@rev.ng>, qemu-devel@nongnu.org
Cc: ale@rev.ng, pbonzini@redhat.com, philmd@linaro.org,
peter.maydell@linaro.org
Subject: Re: [PATCH 05/11] accel/tcg: Modifies memory access functions to use CPUState
Date: Tue, 12 Sep 2023 12:34:06 -0700 [thread overview]
Message-ID: <ef6f5d06-4dfc-e114-3f1b-52ccc125c34e@linaro.org> (raw)
In-Reply-To: <20230912153428.17816-6-anjo@rev.ng>
On 9/12/23 08:34, Anton Johansson wrote:
> do_[ld|st]*() and mmu_lookup*() are changed to use CPUState over
> CPUArchState, moving the target-dependence to the target-facing facing
> cpu_[ld|st] functions.
>
> Signed-off-by: Anton Johansson <anjo@rev.ng>
> ---
> accel/tcg/cputlb.c | 324 ++++++++++++++++++++++-----------------------
> 1 file changed, 161 insertions(+), 163 deletions(-)
So... what's your ultimate plan here?
At the moment through patches 5-11, all you do is take CPUArchState, discard knowledge of
it via CPUState, and then recover knowledge of it via cpu->tlb_ptr.
I agree that *something* has to happen in order to allow these entry points to be used by
multiple cpu types simultaneously, but there must be a plan.
Is it to have tcg generated code perform env_cpu() inline before the call? That's just
pointer arithmetic, so it's certainly an easy option.
r~
next prev parent reply other threads:[~2023-09-12 19:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-12 15:34 [PATCH 00/11] Reduce usage of CPUArchState in cputlb.c Anton Johansson via
2023-09-12 15:34 ` [PATCH 01/11] target/arm: Replace TARGET_PAGE_ENTRY_EXTRA Anton Johansson via
2023-09-12 15:34 ` [PATCH 02/11] include: Introduce tlb_ptr field to CPUState Anton Johansson via
2023-09-12 18:43 ` Richard Henderson
2023-09-13 15:23 ` Anton Johansson via
2023-09-12 15:34 ` [PATCH 03/11] accel/tcg: Modify tlb_*() to use CPUState Anton Johansson via
2023-09-12 18:42 ` Richard Henderson
2023-09-13 19:09 ` Anton Johansson via
2023-09-12 15:34 ` [PATCH 04/11] accel/tcg: Modify probe_access_internal() " Anton Johansson via
2023-09-12 15:34 ` [PATCH 05/11] accel/tcg: Modifies memory access functions " Anton Johansson via
2023-09-12 19:34 ` Richard Henderson [this message]
2023-09-13 13:46 ` Anton Johansson via
2023-09-12 15:34 ` [PATCH 06/11] accel/tcg: Modify atomic_mmu_lookup() " Anton Johansson via
2023-09-12 15:34 ` [PATCH 07/11] accel/tcg: Use CPUState in atomicity helpers Anton Johansson via
2023-09-12 15:34 ` [PATCH 08/11] include/exec: Remove env_tlb() Anton Johansson via
2023-09-12 15:34 ` [PATCH 09/11] tcg: Update env_tlb() comments Anton Johansson via
2023-09-12 15:34 ` [PATCH 10/11] accel/tcg: Unify user and softmmu do_[st|ld]*_mmu() Anton Johansson via
2023-09-12 15:34 ` [PATCH 11/11] accel/tcg: move ld/st helpers to ldst_common.c.inc Anton Johansson via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef6f5d06-4dfc-e114-3f1b-52ccc125c34e@linaro.org \
--to=richard.henderson@linaro.org \
--cc=ale@rev.ng \
--cc=anjo@rev.ng \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).