Re: [PATCH v2 08/10] usb/msd: Rename mode to cbw_state, and tweak names

["Philippe Mathieu-Daudé" <philmd@linaro.org>]

On 11/4/25 10:04, Nicholas Piggin wrote:
> This reflects a little better what it does, particularly with a
> subsequent change to relax the order packets are seen in. This
> field is not the general state of the MSD state machine, rather
> it follows packets that are completed as part of a CBW command.
> 
> The difference is a bit subtle, so for a concrete example, the
> next change will permit the host to send a CSW packet before it
> sends the associated CBW packet. In that case the CSW packet
> will be tracked and the MSD state machine will move, but this
> mode / cbw_state field would remain unchanged (in the "expecting
> CBW" state), until the CBW packet arrives.
> 
> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
> ---
>   include/hw/usb/msd.h | 12 +++++------
>   hw/usb/dev-storage.c | 50 +++++++++++++++++++++++---------------------
>   2 files changed, 32 insertions(+), 30 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>