From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E6F7C433DB for ; Mon, 1 Feb 2021 15:16:12 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F1C3264DE3 for ; Mon, 1 Feb 2021 15:16:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F1C3264DE3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47734 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l6avy-0006e5-VL for qemu-devel@archiver.kernel.org; Mon, 01 Feb 2021 10:16:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35014) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l6aus-0005mg-3B for qemu-devel@nongnu.org; Mon, 01 Feb 2021 10:15:02 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:57431) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l6aun-0000mM-Nv for qemu-devel@nongnu.org; Mon, 01 Feb 2021 10:15:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612192495; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ozIpMqdD+iWDcSAqUu8JnyllJwpaDgaHUGFapFVXhs4=; b=RJjDFif06iWVHu7y0/ZwyIksGUjIJvw96qBJImcjxtA7iCjpov0XeViAvkhPdkp4zlGb87 impQggHRPyW2DihDZ6s0jgT6K3Em2pVuo+FjUh0KJbccthe6AFrsLEVDyqWIs1TzDTD++O OQINHAisSCxNZowByyO2kQlD1Es+6x8= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-212-t919khUmOz2As2Vi-n10lg-1; Mon, 01 Feb 2021 10:14:51 -0500 X-MC-Unique: t919khUmOz2As2Vi-n10lg-1 Received: by mail-ej1-f69.google.com with SMTP id ar27so7309486ejc.22 for ; Mon, 01 Feb 2021 07:14:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ozIpMqdD+iWDcSAqUu8JnyllJwpaDgaHUGFapFVXhs4=; b=HFkMqc8C6xAfh4ZkXnI4jBHPrUMjKZaag9z/R4FKyRfXks468S92HuPuqtbCgdxqoH FFfZTEr1TLw07bJRgQYWRA2lY3qF3uRExxOMJ6G0qYAWL+eXXyGo62TVMR+J/12XcWYJ msm5G3tZfXkWX4ZRs7TurPUG0a7O3APcDrxpSYUbm0109DiOBSk60XcTMfjjIga9PrLP cQ11IyDG4fuMbzSTSPqrbn9G/ho+jbEGe0jCOoZtKk3eU49LhEeAJcdgH+6OzEuqy9rA IqlL/CQFfvwINMs3LRR5LxRqYu73ywuazDRGB4Pns7OUSgoJMGRJ1eV8tQvjA7VD7wHP h9Dg== X-Gm-Message-State: AOAM531YMlaMRP314Gr35KE7qUUHgisNd04T0TYx4DOUSg79yO0RaWRB j+9qWSsjKJl7ko1YAgb9Lf/WXf4kW80IAR/H0IJt6swEykNMMN6d00WE3w/0m0nqcUQ5hx/kzMh jwAHymAA7gqxJ8PE= X-Received: by 2002:a17:906:2b11:: with SMTP id a17mr2895249ejg.203.1612192490224; Mon, 01 Feb 2021 07:14:50 -0800 (PST) X-Google-Smtp-Source: ABdhPJxXlZF+TW4mrA+26ATw+qpSwDnRGpGFo7oajB4U8h44xBqc8IK9tixzY7gowcJEeUW2K7C7fQ== X-Received: by 2002:a17:906:2b11:: with SMTP id a17mr2895213ejg.203.1612192489878; Mon, 01 Feb 2021 07:14:49 -0800 (PST) Received: from [192.168.1.36] (7.red-83-57-171.dynamicip.rima-tde.net. [83.57.171.7]) by smtp.gmail.com with ESMTPSA id m26sm8014991ejr.54.2021.02.01.07.14.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 Feb 2021 07:14:48 -0800 (PST) Subject: Re: [PATCH v2 2/2] accel: kvm: Add aligment assert for kvm_log_clear_one_slot To: Keqian Zhu , Peter Maydell , Paolo Bonzini , "Dr . David Alan Gilbert" , Andrew Jones , Peter Xu References: <20201217014941.22872-1-zhukeqian1@huawei.com> <20201217014941.22872-3-zhukeqian1@huawei.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: Date: Mon, 1 Feb 2021 16:14:46 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20201217014941.22872-3-zhukeqian1@huawei.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.351, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Zenghui Yu , wanghaibin.wang@huawei.com, jiangkunkun@huawei.com, qemu-devel@nongnu.org, qemu-arm@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hi, On 12/17/20 2:49 AM, Keqian Zhu wrote: > The parameters start and size are transfered from QEMU memory > emulation layer. It can promise that they are TARGET_PAGE_SIZE > aligned. However, KVM needs they are qemu_real_page_size aligned. > > Though no caller breaks this aligned requirement currently, we'd > better add an explicit assert to avoid future breaking. > > Signed-off-by: Keqian Zhu > --- > accel/kvm/kvm-all.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > --- > v2 > - Address Andrew's commment (Use assert instead of return err). > > diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c > index f6b16a8df8..73b195cc41 100644 > --- a/accel/kvm/kvm-all.c > +++ b/accel/kvm/kvm-all.c > @@ -692,6 +692,10 @@ out: > #define KVM_CLEAR_LOG_ALIGN (qemu_real_host_page_size << KVM_CLEAR_LOG_SHIFT) > #define KVM_CLEAR_LOG_MASK (-KVM_CLEAR_LOG_ALIGN) > > +/* > + * As the granule of kvm dirty log is qemu_real_host_page_size, > + * @start and @size are expected and restricted to align to it. > + */ > static int kvm_log_clear_one_slot(KVMSlot *mem, int as_id, uint64_t start, > uint64_t size) > { > @@ -701,6 +705,9 @@ static int kvm_log_clear_one_slot(KVMSlot *mem, int as_id, uint64_t start, > unsigned long *bmap_clear = NULL, psize = qemu_real_host_page_size; > int ret; > > + /* Make sure start and size are qemu_real_host_page_size aligned */ > + assert(QEMU_IS_ALIGNED(start | size, psize)); Why not return an error instead of aborting the VM? > /* > * We need to extend either the start or the size or both to > * satisfy the KVM interface requirement. Firstly, do the start >