From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55647) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1boPod-0006DY-He for qemu-devel@nongnu.org; Mon, 26 Sep 2016 02:55:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1boPoY-0002wb-Lk for qemu-devel@nongnu.org; Mon, 26 Sep 2016 02:55:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57958) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1boPoY-0002wF-Fm for qemu-devel@nongnu.org; Mon, 26 Sep 2016 02:54:58 -0400 References: <20160822161740.4252-1-prem.mallappa@broadcom.com> <20160822161740.4252-2-prem.mallappa@broadcom.com> <3c8edc1c-fd1a-7da6-9274-ad4191eddbdc@redhat.com> <20160925145853.GB5931@toto> From: Auger Eric Message-ID: Date: Mon, 26 Sep 2016 08:54:52 +0200 MIME-Version: 1.0 In-Reply-To: <20160925145853.GB5931@toto> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 1/9] log: Add new IOMMU type List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Edgar E. Iglesias" , Prem Mallappa Cc: Peter Maydell , QEMU Developers Hi Edgar, Prem, On 25/09/2016 16:58, Edgar E. Iglesias wrote: > On Tue, Sep 13, 2016 at 01:53:39AM +0530, Prem Mallappa wrote: >> On Fri, Sep 9, 2016 at 9:06 PM, Auger Eric wrote: >> >>> Hi Prem, >>> >>> Missing commit message >>> >>>> Signed-off-by: Prem Mallappa >>>> --- >>>> include/qemu/log.h | 1 + >>>> util/log.c | 2 ++ >>>> 2 files changed, 3 insertions(+) >>>> >>>> diff --git a/include/qemu/log.h b/include/qemu/log.h >>>> index 234fa81..3dd2131 100644 >>>> --- a/include/qemu/log.h >>>> +++ b/include/qemu/log.h >>>> @@ -42,6 +42,7 @@ static inline bool qemu_log_separate(void) >>>> #define CPU_LOG_TB_NOCHAIN (1 << 13) >>>> #define CPU_LOG_PAGE (1 << 14) >>>> #define LOG_TRACE (1 << 15) >>>> +#define CPU_LOG_IOMMU (1 << 16) >>> why is it prefixed with CPU_ ? >>> besides all arm gic devices seem to use LOG_GUEST_ERROR. what is the >>> rationale behind introducing a new enum? >>> >> >> Will change this to LOG_GUEST_ERROR, if others on the list are okay. > > Hi, > > LOG_GUEST_ERROR is used for cases when the guest programs things in bad > way. E.g sets up a register in an invalid manner or writes to regs that > don't exist. > > In this case we're logging information for valid translation steps, I > would prefer if we could use something else than LOG_GUEST_ERROR. > An IOMMU logging class sounds good to me. Thank you for the clarification; so indeed LOG_GUEST_ERROR which was my suggestion is not a good idea. With respect to that patch I was also wondering whether the CPU_ prefix was relevant. Thanks Eric > > Best regards, > Edgar >