From: Max Reitz <mreitz@redhat.com>
To: Alberto Garcia <berto@igalia.com>, qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
qemu-block@nongnu.org
Subject: Re: [PATCH v4] qcow2: Forbid discard in qcow2 v2 images with backing files
Date: Tue, 31 Mar 2020 12:44:11 +0200 [thread overview]
Message-ID: <efcc0408-2a60-532f-b813-7efed2e6cbb1@redhat.com> (raw)
In-Reply-To: <w51v9mkx36x.fsf@maestria.local.igalia.com>
[-- Attachment #1.1: Type: text/plain, Size: 586 bytes --]
On 31.03.20 11:51, Alberto Garcia wrote:
> On Tue 31 Mar 2020 10:57:18 AM CEST, Max Reitz wrote:
>> I’ll have to dequeue it again, because it breaks iotests 046 and 177
>> (both of which already have special handling for v2-specific discard;
>> but it needs to be adjusted now that the discard operation no longer
>> reveals the backing file contents).
>
> ??? None of those break for me, is that in your branch or in master?
Er, oops. Somehow I forgot to note that they break for v2 images, so
with -o compat=0.10:
$ ./check -T -qcow2 -o compat=0.10 46 177
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2020-03-31 10:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-27 18:59 [PATCH v4] qcow2: Forbid discard in qcow2 v2 images with backing files Alberto Garcia
2020-03-27 19:19 ` Eric Blake
2020-03-30 10:05 ` Max Reitz
2020-03-31 8:57 ` Max Reitz
2020-03-31 9:51 ` Alberto Garcia
2020-03-31 10:44 ` Max Reitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=efcc0408-2a60-532f-b813-7efed2e6cbb1@redhat.com \
--to=mreitz@redhat.com \
--cc=berrange@redhat.com \
--cc=berto@igalia.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).