From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B459C4338F for ; Tue, 17 Aug 2021 13:51:02 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 207A860EFE for ; Tue, 17 Aug 2021 13:51:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 207A860EFE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:45914 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mFzUb-0005Sp-8N for qemu-devel@archiver.kernel.org; Tue, 17 Aug 2021 09:51:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39956) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mFzTl-0004hC-7u for qemu-devel@nongnu.org; Tue, 17 Aug 2021 09:50:09 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:23191) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mFzTh-000558-Sv for qemu-devel@nongnu.org; Tue, 17 Aug 2021 09:50:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1629208204; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QspSGJvOH/ctE3FKLW1adFTN5nvhQEpZYM3w5V7bcJ8=; b=d7hoCPpY8a83S9N9YaiZFfsPB9ipl75wmjcPdWNkNOnVbJcp7vUHOShHHjSDPonWGfNBqP NuE8QrqK4TFyMMsJICGrQEaK5vXJJkQurA1dJvA5YLkb1NbwC4U3oVKKf0PDDJ/UvCKA+2 nlNLDyHK1iL78XXSYULTyuc5TplG05o= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-325-JpqwxBk-PxW320SQFl4hvg-1; Tue, 17 Aug 2021 09:50:03 -0400 X-MC-Unique: JpqwxBk-PxW320SQFl4hvg-1 Received: by mail-wr1-f69.google.com with SMTP id m5-20020a5d6a050000b0290154e83dce73so6551681wru.19 for ; Tue, 17 Aug 2021 06:50:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=QspSGJvOH/ctE3FKLW1adFTN5nvhQEpZYM3w5V7bcJ8=; b=UBKtzInt1/iwSkEJGTI8L7eAWdZBJb5A2VBjzwfn1nUc6rd9nRJts1fZ2rPoZFNQmv cAoKfLiwpRkWnjdTupN4fg4P+8llZftICxcQmJ5kolPIzVTmiR+Lbz91ikcJ7IFPj6nj t8v3lKbrAkwjqBi2yi1ESrL5SWjz57jq0HiqOlNCEUwXZV0w4WAEc91Of7qOoHZaxx2o uH7sUWuW7mIR9P3T8wb01vq32BScBq4Z9wq6+c2toxKDJVlMJ22TiRrNZsfe/L9Kv/Lm Hn8FOcxtr3BOC0WXir04hcDdVuiSHhIIhga9QU3Ph5+j27eqAD/bVTy0nua8ZwRUkljU RQLg== X-Gm-Message-State: AOAM532//43S9L1I8X6VtV8Rs/Y19sXjtwFwsfMzJeHkwijLwsDB/2uQ EwAwooRh3KxEeKJQxwkTDUjFvAuEbSbGKo2IV7CT47q0vYqukD2bDn3Re/U5x6ntWeChzTXMuN7 m6SqHZ5vHDWiaOFo= X-Received: by 2002:a1c:1dc4:: with SMTP id d187mr3538554wmd.1.1629208202460; Tue, 17 Aug 2021 06:50:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw7oTG7UDRtYq/aihc5Elr5Yrrr7dPCn7cXa4EW35Vf4U98nCazkGS+DzZA+kBOjDxufGPY9g== X-Received: by 2002:a1c:1dc4:: with SMTP id d187mr3538533wmd.1.1629208202265; Tue, 17 Aug 2021 06:50:02 -0700 (PDT) Received: from [192.168.1.36] (163.red-83-52-55.dynamicip.rima-tde.net. [83.52.55.163]) by smtp.gmail.com with ESMTPSA id q11sm2226444wmc.41.2021.08.17.06.50.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Aug 2021 06:50:01 -0700 (PDT) Subject: Re: [PATCH] qapi/machine.json: Remove zero value reference from SMPConfiguration documentation To: Andrew Jones , qemu-devel References: <20210817125356.9461-1-drjones@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: Date: Tue, 17 Aug 2021 15:50:00 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210817125356.9461-1-drjones@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -54 X-Spam_score: -5.5 X-Spam_bar: ----- X-Spam_report: (-5.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.7, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-1.961, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Yanan Wang , Paolo Bonzini , Cornelia Huck , "Daniel P . Berrange" , Eduardo Habkost Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 8/17/21 2:53 PM, Andrew Jones wrote: > Commit 1e63fe685804 ("machine: pass QAPI struct to mc->smp_parse") > introduced documentation stating that a zero input value for an SMP > parameter indicates that its value should be automatically configured. > This is indeed how things work today, but we'd like to change that. > Avoid documenting behaviors we want to leave undefined for the time > being, giving us freedom to change it later. > > Fixes: 1e63fe685804 ("machine: pass QAPI struct to mc->smp_parse") > Signed-off-by: Andrew Jones > --- > qapi/machine.json | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/qapi/machine.json b/qapi/machine.json > index c3210ee1fb24..157712f00614 100644 > --- a/qapi/machine.json > +++ b/qapi/machine.json > @@ -1288,7 +1288,7 @@ > ## > # @SMPConfiguration: > # > -# Schema for CPU topology configuration. "0" or a missing value lets > +# Schema for CPU topology configuration. A missing value lets > # QEMU figure out a suitable value based on the ones that are provided. > # > # @cpus: number of virtual CPUs in the virtual machine > Reviewed-by: Philippe Mathieu-Daudé