* [PATCH v1 0/1] hw/arm: versal: Use nr_apu_cpus in favor of hard coding 2 @ 2021-02-10 14:20 Edgar E. Iglesias 2021-02-10 14:20 ` [PATCH v1 1/1] " Edgar E. Iglesias 2021-02-11 11:36 ` [PATCH v1 0/1] " Peter Maydell 0 siblings, 2 replies; 5+ messages in thread From: Edgar E. Iglesias @ 2021-02-10 14:20 UTC (permalink / raw) To: qemu-devel Cc: figlesia, peter.maydell, sstabellini, edgar.iglesias, sai.pavan.boddu, frasse.iglesias, alistair, richard.henderson, frederic.konrad, qemu-arm, komlodi, philmd, luc.michel From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com> This is a minor clean-up making it a little easier to play around with different CPU configurations. Cheers, Edgar Edgar E. Iglesias (1): hw/arm: versal: Use nr_apu_cpus in favor of hard coding 2 hw/arm/xlnx-versal.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.25.1 ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v1 1/1] hw/arm: versal: Use nr_apu_cpus in favor of hard coding 2 2021-02-10 14:20 [PATCH v1 0/1] hw/arm: versal: Use nr_apu_cpus in favor of hard coding 2 Edgar E. Iglesias @ 2021-02-10 14:20 ` Edgar E. Iglesias 2021-02-10 14:48 ` Philippe Mathieu-Daudé 2021-02-11 8:23 ` Luc Michel 2021-02-11 11:36 ` [PATCH v1 0/1] " Peter Maydell 1 sibling, 2 replies; 5+ messages in thread From: Edgar E. Iglesias @ 2021-02-10 14:20 UTC (permalink / raw) To: qemu-devel Cc: figlesia, peter.maydell, sstabellini, edgar.iglesias, sai.pavan.boddu, frasse.iglesias, alistair, richard.henderson, frederic.konrad, qemu-arm, komlodi, philmd, luc.michel From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com> Use nr_apu_cpus in favor of hard coding 2. Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com> --- hw/arm/xlnx-versal.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/arm/xlnx-versal.c b/hw/arm/xlnx-versal.c index b0777166e8..628e77ef66 100644 --- a/hw/arm/xlnx-versal.c +++ b/hw/arm/xlnx-versal.c @@ -67,10 +67,10 @@ static void versal_create_apu_gic(Versal *s, qemu_irq *pic) gicbusdev = SYS_BUS_DEVICE(&s->fpd.apu.gic); gicdev = DEVICE(&s->fpd.apu.gic); qdev_prop_set_uint32(gicdev, "revision", 3); - qdev_prop_set_uint32(gicdev, "num-cpu", 2); + qdev_prop_set_uint32(gicdev, "num-cpu", nr_apu_cpus); qdev_prop_set_uint32(gicdev, "num-irq", XLNX_VERSAL_NR_IRQS + 32); qdev_prop_set_uint32(gicdev, "len-redist-region-count", 1); - qdev_prop_set_uint32(gicdev, "redist-region-count[0]", 2); + qdev_prop_set_uint32(gicdev, "redist-region-count[0]", nr_apu_cpus); qdev_prop_set_bit(gicdev, "has-security-extensions", true); sysbus_realize(SYS_BUS_DEVICE(&s->fpd.apu.gic), &error_fatal); -- 2.25.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v1 1/1] hw/arm: versal: Use nr_apu_cpus in favor of hard coding 2 2021-02-10 14:20 ` [PATCH v1 1/1] " Edgar E. Iglesias @ 2021-02-10 14:48 ` Philippe Mathieu-Daudé 2021-02-11 8:23 ` Luc Michel 1 sibling, 0 replies; 5+ messages in thread From: Philippe Mathieu-Daudé @ 2021-02-10 14:48 UTC (permalink / raw) To: Edgar E. Iglesias, qemu-devel Cc: figlesia, peter.maydell, sstabellini, edgar.iglesias, sai.pavan.boddu, frasse.iglesias, alistair, richard.henderson, frederic.konrad, qemu-arm, komlodi, luc.michel On 2/10/21 3:20 PM, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com> > > Use nr_apu_cpus in favor of hard coding 2. > > Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com> > --- > hw/arm/xlnx-versal.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/arm/xlnx-versal.c b/hw/arm/xlnx-versal.c > index b0777166e8..628e77ef66 100644 > --- a/hw/arm/xlnx-versal.c > +++ b/hw/arm/xlnx-versal.c > @@ -67,10 +67,10 @@ static void versal_create_apu_gic(Versal *s, qemu_irq *pic) > gicbusdev = SYS_BUS_DEVICE(&s->fpd.apu.gic); > gicdev = DEVICE(&s->fpd.apu.gic); > qdev_prop_set_uint32(gicdev, "revision", 3); > - qdev_prop_set_uint32(gicdev, "num-cpu", 2); > + qdev_prop_set_uint32(gicdev, "num-cpu", nr_apu_cpus); Or directly XLNX_VERSAL_NR_ACPUS? Regardless: Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > qdev_prop_set_uint32(gicdev, "num-irq", XLNX_VERSAL_NR_IRQS + 32); > qdev_prop_set_uint32(gicdev, "len-redist-region-count", 1); > - qdev_prop_set_uint32(gicdev, "redist-region-count[0]", 2); > + qdev_prop_set_uint32(gicdev, "redist-region-count[0]", nr_apu_cpus); > qdev_prop_set_bit(gicdev, "has-security-extensions", true); > > sysbus_realize(SYS_BUS_DEVICE(&s->fpd.apu.gic), &error_fatal); > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1 1/1] hw/arm: versal: Use nr_apu_cpus in favor of hard coding 2 2021-02-10 14:20 ` [PATCH v1 1/1] " Edgar E. Iglesias 2021-02-10 14:48 ` Philippe Mathieu-Daudé @ 2021-02-11 8:23 ` Luc Michel 1 sibling, 0 replies; 5+ messages in thread From: Luc Michel @ 2021-02-11 8:23 UTC (permalink / raw) To: Edgar E. Iglesias, qemu-devel Cc: figlesia, peter.maydell, sstabellini, edgar.iglesias, sai.pavan.boddu, frasse.iglesias, alistair, richard.henderson, frederic.konrad, qemu-arm, komlodi, philmd On 2/10/21 3:20 PM, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com> > > Use nr_apu_cpus in favor of hard coding 2. > > Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com> Reviewed-by: Luc Michel <luc@lmichel.fr> > --- > hw/arm/xlnx-versal.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/arm/xlnx-versal.c b/hw/arm/xlnx-versal.c > index b0777166e8..628e77ef66 100644 > --- a/hw/arm/xlnx-versal.c > +++ b/hw/arm/xlnx-versal.c > @@ -67,10 +67,10 @@ static void versal_create_apu_gic(Versal *s, qemu_irq *pic) > gicbusdev = SYS_BUS_DEVICE(&s->fpd.apu.gic); > gicdev = DEVICE(&s->fpd.apu.gic); > qdev_prop_set_uint32(gicdev, "revision", 3); > - qdev_prop_set_uint32(gicdev, "num-cpu", 2); > + qdev_prop_set_uint32(gicdev, "num-cpu", nr_apu_cpus); > qdev_prop_set_uint32(gicdev, "num-irq", XLNX_VERSAL_NR_IRQS + 32); > qdev_prop_set_uint32(gicdev, "len-redist-region-count", 1); > - qdev_prop_set_uint32(gicdev, "redist-region-count[0]", 2); > + qdev_prop_set_uint32(gicdev, "redist-region-count[0]", nr_apu_cpus); > qdev_prop_set_bit(gicdev, "has-security-extensions", true); > > sysbus_realize(SYS_BUS_DEVICE(&s->fpd.apu.gic), &error_fatal); > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1 0/1] hw/arm: versal: Use nr_apu_cpus in favor of hard coding 2 2021-02-10 14:20 [PATCH v1 0/1] hw/arm: versal: Use nr_apu_cpus in favor of hard coding 2 Edgar E. Iglesias 2021-02-10 14:20 ` [PATCH v1 1/1] " Edgar E. Iglesias @ 2021-02-11 11:36 ` Peter Maydell 1 sibling, 0 replies; 5+ messages in thread From: Peter Maydell @ 2021-02-11 11:36 UTC (permalink / raw) To: Edgar E. Iglesias Cc: Francisco Eduardo Iglesias, Edgar Iglesias, Stefano Stabellini, Sai Pavan Boddu, Francisco Iglesias, Alistair Francis, Richard Henderson, QEMU Developers, KONRAD Frederic, qemu-arm, Joe Komlodi, Philippe Mathieu-Daudé, Luc Michel On Wed, 10 Feb 2021 at 14:20, Edgar E. Iglesias <edgar.iglesias@gmail.com> wrote: > > From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com> > > This is a minor clean-up making it a little easier to play around > with different CPU configurations. > > Cheers, > Edgar > > Edgar E. Iglesias (1): > hw/arm: versal: Use nr_apu_cpus in favor of hard coding 2 Applied to target-arm.next, thanks. PS: you don't really need a cover letter for single patches... -- PMM ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-02-11 11:38 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2021-02-10 14:20 [PATCH v1 0/1] hw/arm: versal: Use nr_apu_cpus in favor of hard coding 2 Edgar E. Iglesias 2021-02-10 14:20 ` [PATCH v1 1/1] " Edgar E. Iglesias 2021-02-10 14:48 ` Philippe Mathieu-Daudé 2021-02-11 8:23 ` Luc Michel 2021-02-11 11:36 ` [PATCH v1 0/1] " Peter Maydell
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).