Re: [PATCH v2 39/42] include/system: Remove ifndef CONFIG_USER_ONLY in qtest.h

["Philippe Mathieu-Daudé" <philmd@linaro.org>]

On 18/3/25 22:32, Richard Henderson wrote:
> This is include/system, so CONFIG_USER_ONLY will never be true.
> 
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>   include/system/qtest.h | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/include/system/qtest.h b/include/system/qtest.h
> index 6ddddc501b..84b1f8c6ee 100644
> --- a/include/system/qtest.h
> +++ b/include/system/qtest.h
> @@ -23,7 +23,6 @@ static inline bool qtest_enabled(void)
>       return qtest_allowed;
>   }

IIRC the problem I had here were uses in common ARM cpus code.

i.e.:
target/arm/cpu.c:1786:     if (tcg_enabled() || qtest_enabled()) {
target/arm/cpu64.c:765:    if (tcg_enabled() || qtest_enabled()) {

I'll recheck how code evolved in your branch.