* [PATCH] linux-user/riscv: Fix sizeof_reg typo in vdso unwind info
@ 2024-01-12 22:03 Richard Henderson
2024-01-15 9:58 ` Philippe Mathieu-Daudé
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Richard Henderson @ 2024-01-12 22:03 UTC (permalink / raw)
To: qemu-devel; +Cc: Vineet Gupta
Reported-by: Vineet Gupta <vineetg@rivosinc.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
linux-user/riscv/vdso-32.so | Bin 2900 -> 2900 bytes
linux-user/riscv/vdso-64.so | Bin 3856 -> 3856 bytes
linux-user/riscv/vdso.S | 2 +-
3 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/linux-user/riscv/vdso-32.so b/linux-user/riscv/vdso-32.so
index 1ad1e5cbbbb8b1fe36b0fe4bcb6c06fab8219ecd..5829c1dc90f1c1aafde69f5b9f5bc9afb85251f7 100755
GIT binary patch
delta 112
zcmV-$0FVFF7StB71OXHyD|k<wiZ(XN!ME<$oE!73r-+KP7y<qQJ!67mgJFbVg<pnV
zhh2zViCc<Vi&>0VjaQCVk5!OVkyDaVlTnmVl~0yVmra;VnM;~Vn@OBVokyNVpGC7%
S1ndF^OjB%HZ#A<;2M+}Mt1p-U
delta 112
zcmV-$0FVFF7StB71OXI7ek-E|Z8Fh9(G%V1AYqwmRqNri7y<qQJz|1jgI<JOg<6JK
zhgOJGiBgJCi%yJ8jY^J4k4BJ0kwTI{lRlI@l{%I<mo}I*nKGI%n=YIzohqIvpC+?Y
S1ndF^P;+@qVQaHR2M+{CwJgd2
diff --git a/linux-user/riscv/vdso-64.so b/linux-user/riscv/vdso-64.so
index 83992bebe6d0182f24edfffc531015fd2f4e1cfb..de18e35537a493ba35307e93a2d33faaf489c0b3 100755
GIT binary patch
delta 118
zcmV-+0Ez#Q9*`cepaB$miap5s7G5`$2#eqLH6<vG8d2V}v;pe_KY{^*fB}PkgnWg1
zhIof|h;)f^ig1f=jBJf+j%bf&kYtf!l3<fwlw6fsmROfom{gfknoyfgoJ^fco=BfY
YlidYEvmgdT0|snTdTn?%vuO#Z1^ZDlW&i*H
delta 117
zcmV-*0E+*R9*`cepaB$}OC4Olbn*vwtO;!U^UJ?5jVB4Sv;pe_K7av&e1mv|bcJw+
zY=>xwWQkykT#HzYRE<!MOpi#AM3F#}Jd-$-G?g%xESD&lB$*(Z9Ge)N6rB*B44(*-
X-UULl9|lAN23SxxMKVLPX$hwVbapOM
diff --git a/linux-user/riscv/vdso.S b/linux-user/riscv/vdso.S
index a86d8fc488..4b4e34aeea 100644
--- a/linux-user/riscv/vdso.S
+++ b/linux-user/riscv/vdso.S
@@ -101,7 +101,7 @@ endf __vdso_flush_icache
.cfi_startproc simple
.cfi_signal_frame
-#define sizeof_reg (__riscv_xlen / 4)
+#define sizeof_reg (__riscv_xlen / 8)
#define sizeof_freg 8
#define B_GR (offsetof_uc_mcontext - sizeof_rt_sigframe)
#define B_FR (offsetof_uc_mcontext - sizeof_rt_sigframe + offsetof_freg0)
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] linux-user/riscv: Fix sizeof_reg typo in vdso unwind info
2024-01-12 22:03 [PATCH] linux-user/riscv: Fix sizeof_reg typo in vdso unwind info Richard Henderson
@ 2024-01-15 9:58 ` Philippe Mathieu-Daudé
2024-01-22 5:47 ` Alistair Francis
2024-02-05 4:33 ` Alistair Francis
2 siblings, 0 replies; 5+ messages in thread
From: Philippe Mathieu-Daudé @ 2024-01-15 9:58 UTC (permalink / raw)
To: Richard Henderson, qemu-devel; +Cc: Vineet Gupta, qemu-riscv
On 12/1/24 23:03, Richard Henderson wrote:
Fixes: 468c1bb5ca ("linux-user/riscv: Add vdso")
> Reported-by: Vineet Gupta <vineetg@rivosinc.com>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> linux-user/riscv/vdso-32.so | Bin 2900 -> 2900 bytes
> linux-user/riscv/vdso-64.so | Bin 3856 -> 3856 bytes
> linux-user/riscv/vdso.S | 2 +-
> 3 files changed, 1 insertion(+), 1 deletion(-)
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] linux-user/riscv: Fix sizeof_reg typo in vdso unwind info
2024-01-12 22:03 [PATCH] linux-user/riscv: Fix sizeof_reg typo in vdso unwind info Richard Henderson
2024-01-15 9:58 ` Philippe Mathieu-Daudé
@ 2024-01-22 5:47 ` Alistair Francis
2024-02-05 4:33 ` Alistair Francis
2 siblings, 0 replies; 5+ messages in thread
From: Alistair Francis @ 2024-01-22 5:47 UTC (permalink / raw)
To: Richard Henderson; +Cc: qemu-devel, Vineet Gupta
On Sat, Jan 13, 2024 at 8:04 AM Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Reported-by: Vineet Gupta <vineetg@rivosinc.com>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Alistair
> ---
> linux-user/riscv/vdso-32.so | Bin 2900 -> 2900 bytes
> linux-user/riscv/vdso-64.so | Bin 3856 -> 3856 bytes
> linux-user/riscv/vdso.S | 2 +-
> 3 files changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/linux-user/riscv/vdso-32.so b/linux-user/riscv/vdso-32.so
> index 1ad1e5cbbbb8b1fe36b0fe4bcb6c06fab8219ecd..5829c1dc90f1c1aafde69f5b9f5bc9afb85251f7 100755
> GIT binary patch
> delta 112
> zcmV-$0FVFF7StB71OXHyD|k<wiZ(XN!ME<$oE!73r-+KP7y<qQJ!67mgJFbVg<pnV
> zhh2zViCc<Vi&>0VjaQCVk5!OVkyDaVlTnmVl~0yVmra;VnM;~Vn@OBVokyNVpGC7%
> S1ndF^OjB%HZ#A<;2M+}Mt1p-U
>
> delta 112
> zcmV-$0FVFF7StB71OXI7ek-E|Z8Fh9(G%V1AYqwmRqNri7y<qQJz|1jgI<JOg<6JK
> zhgOJGiBgJCi%yJ8jY^J4k4BJ0kwTI{lRlI@l{%I<mo}I*nKGI%n=YIzohqIvpC+?Y
> S1ndF^P;+@qVQaHR2M+{CwJgd2
>
> diff --git a/linux-user/riscv/vdso-64.so b/linux-user/riscv/vdso-64.so
> index 83992bebe6d0182f24edfffc531015fd2f4e1cfb..de18e35537a493ba35307e93a2d33faaf489c0b3 100755
> GIT binary patch
> delta 118
> zcmV-+0Ez#Q9*`cepaB$miap5s7G5`$2#eqLH6<vG8d2V}v;pe_KY{^*fB}PkgnWg1
> zhIof|h;)f^ig1f=jBJf+j%bf&kYtf!l3<fwlw6fsmROfom{gfknoyfgoJ^fco=BfY
> YlidYEvmgdT0|snTdTn?%vuO#Z1^ZDlW&i*H
>
> delta 117
> zcmV-*0E+*R9*`cepaB$}OC4Olbn*vwtO;!U^UJ?5jVB4Sv;pe_K7av&e1mv|bcJw+
> zY=>xwWQkykT#HzYRE<!MOpi#AM3F#}Jd-$-G?g%xESD&lB$*(Z9Ge)N6rB*B44(*-
> X-UULl9|lAN23SxxMKVLPX$hwVbapOM
>
> diff --git a/linux-user/riscv/vdso.S b/linux-user/riscv/vdso.S
> index a86d8fc488..4b4e34aeea 100644
> --- a/linux-user/riscv/vdso.S
> +++ b/linux-user/riscv/vdso.S
> @@ -101,7 +101,7 @@ endf __vdso_flush_icache
> .cfi_startproc simple
> .cfi_signal_frame
>
> -#define sizeof_reg (__riscv_xlen / 4)
> +#define sizeof_reg (__riscv_xlen / 8)
> #define sizeof_freg 8
> #define B_GR (offsetof_uc_mcontext - sizeof_rt_sigframe)
> #define B_FR (offsetof_uc_mcontext - sizeof_rt_sigframe + offsetof_freg0)
> --
> 2.34.1
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] linux-user/riscv: Fix sizeof_reg typo in vdso unwind info
2024-01-12 22:03 [PATCH] linux-user/riscv: Fix sizeof_reg typo in vdso unwind info Richard Henderson
2024-01-15 9:58 ` Philippe Mathieu-Daudé
2024-01-22 5:47 ` Alistair Francis
@ 2024-02-05 4:33 ` Alistair Francis
2024-02-05 5:14 ` Richard Henderson
2 siblings, 1 reply; 5+ messages in thread
From: Alistair Francis @ 2024-02-05 4:33 UTC (permalink / raw)
To: Richard Henderson; +Cc: qemu-devel, Vineet Gupta
On Sat, Jan 13, 2024 at 8:04 AM Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Reported-by: Vineet Gupta <vineetg@rivosinc.com>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Is there a branch with this so I can pull in the binary changes?
Alistair
> ---
> linux-user/riscv/vdso-32.so | Bin 2900 -> 2900 bytes
> linux-user/riscv/vdso-64.so | Bin 3856 -> 3856 bytes
> linux-user/riscv/vdso.S | 2 +-
> 3 files changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/linux-user/riscv/vdso-32.so b/linux-user/riscv/vdso-32.so
> index 1ad1e5cbbbb8b1fe36b0fe4bcb6c06fab8219ecd..5829c1dc90f1c1aafde69f5b9f5bc9afb85251f7 100755
> GIT binary patch
> delta 112
> zcmV-$0FVFF7StB71OXHyD|k<wiZ(XN!ME<$oE!73r-+KP7y<qQJ!67mgJFbVg<pnV
> zhh2zViCc<Vi&>0VjaQCVk5!OVkyDaVlTnmVl~0yVmra;VnM;~Vn@OBVokyNVpGC7%
> S1ndF^OjB%HZ#A<;2M+}Mt1p-U
>
> delta 112
> zcmV-$0FVFF7StB71OXI7ek-E|Z8Fh9(G%V1AYqwmRqNri7y<qQJz|1jgI<JOg<6JK
> zhgOJGiBgJCi%yJ8jY^J4k4BJ0kwTI{lRlI@l{%I<mo}I*nKGI%n=YIzohqIvpC+?Y
> S1ndF^P;+@qVQaHR2M+{CwJgd2
>
> diff --git a/linux-user/riscv/vdso-64.so b/linux-user/riscv/vdso-64.so
> index 83992bebe6d0182f24edfffc531015fd2f4e1cfb..de18e35537a493ba35307e93a2d33faaf489c0b3 100755
> GIT binary patch
> delta 118
> zcmV-+0Ez#Q9*`cepaB$miap5s7G5`$2#eqLH6<vG8d2V}v;pe_KY{^*fB}PkgnWg1
> zhIof|h;)f^ig1f=jBJf+j%bf&kYtf!l3<fwlw6fsmROfom{gfknoyfgoJ^fco=BfY
> YlidYEvmgdT0|snTdTn?%vuO#Z1^ZDlW&i*H
>
> delta 117
> zcmV-*0E+*R9*`cepaB$}OC4Olbn*vwtO;!U^UJ?5jVB4Sv;pe_K7av&e1mv|bcJw+
> zY=>xwWQkykT#HzYRE<!MOpi#AM3F#}Jd-$-G?g%xESD&lB$*(Z9Ge)N6rB*B44(*-
> X-UULl9|lAN23SxxMKVLPX$hwVbapOM
>
> diff --git a/linux-user/riscv/vdso.S b/linux-user/riscv/vdso.S
> index a86d8fc488..4b4e34aeea 100644
> --- a/linux-user/riscv/vdso.S
> +++ b/linux-user/riscv/vdso.S
> @@ -101,7 +101,7 @@ endf __vdso_flush_icache
> .cfi_startproc simple
> .cfi_signal_frame
>
> -#define sizeof_reg (__riscv_xlen / 4)
> +#define sizeof_reg (__riscv_xlen / 8)
> #define sizeof_freg 8
> #define B_GR (offsetof_uc_mcontext - sizeof_rt_sigframe)
> #define B_FR (offsetof_uc_mcontext - sizeof_rt_sigframe + offsetof_freg0)
> --
> 2.34.1
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] linux-user/riscv: Fix sizeof_reg typo in vdso unwind info
2024-02-05 4:33 ` Alistair Francis
@ 2024-02-05 5:14 ` Richard Henderson
0 siblings, 0 replies; 5+ messages in thread
From: Richard Henderson @ 2024-02-05 5:14 UTC (permalink / raw)
To: Alistair Francis; +Cc: qemu-devel, Vineet Gupta
On 2/5/24 14:33, Alistair Francis wrote:
> On Sat, Jan 13, 2024 at 8:04 AM Richard Henderson
> <richard.henderson@linaro.org> wrote:
>>
>> Reported-by: Vineet Gupta <vineetg@rivosinc.com>
>> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
>
> Is there a branch with this so I can pull in the binary changes?
Already merged as
commit 1b21fe27e75a59bfe2513f5abcc6a18cfc35cfc8
Author: Richard Henderson <richard.henderson@linaro.org>
Date: Sat Jan 13 09:02:38 2024 +1100
linux-user/riscv: Adjust vdso signal frame cfa offsets
r~
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-02-05 5:15 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-12 22:03 [PATCH] linux-user/riscv: Fix sizeof_reg typo in vdso unwind info Richard Henderson
2024-01-15 9:58 ` Philippe Mathieu-Daudé
2024-01-22 5:47 ` Alistair Francis
2024-02-05 4:33 ` Alistair Francis
2024-02-05 5:14 ` Richard Henderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).