From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.4 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1253C433E1 for ; Wed, 19 Aug 2020 09:55:56 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9AC5C20658 for ; Wed, 19 Aug 2020 09:55:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="SosZaH0B" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9AC5C20658 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:44270 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k8Kp1-0006Ks-Uh for qemu-devel@archiver.kernel.org; Wed, 19 Aug 2020 05:55:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51928) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k8Ko8-0005ao-KC for qemu-devel@nongnu.org; Wed, 19 Aug 2020 05:55:00 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:46991) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1k8Ko6-0004Ye-1t for qemu-devel@nongnu.org; Wed, 19 Aug 2020 05:55:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1597830897; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=pxVmdWO2+raZ613nWwkmIGyUTlrO1atWhSVmAsh7q7Y=; b=SosZaH0BefE6Vr4wPyIFI4gWxpRjD/xojBXxY7J1W+Pnl+cDsao2WUGTzHKHrOYmYBVm+e UFHXpY1Hl3BFwTKeURBwZWimT233EaCQnqGuWcwu4nzGuTRwvaoyp9jjAgpY08ZBnLC2Ek 1Y6hmUwIm4Rl2IEFE5Shz1Ri5e4754g= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-575-EnExEq1UNZGFkl5icVvKAw-1; Wed, 19 Aug 2020 05:54:54 -0400 X-MC-Unique: EnExEq1UNZGFkl5icVvKAw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 959DE80BCA8; Wed, 19 Aug 2020 09:54:53 +0000 (UTC) Received: from dresden.str.redhat.com (ovpn-113-120.ams2.redhat.com [10.36.113.120]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BE1B85C882; Wed, 19 Aug 2020 09:54:51 +0000 (UTC) Subject: Re: [RFC PATCH 20/22] block/export: Add block-export-del To: Kevin Wolf , qemu-block@nongnu.org References: <20200813162935.210070-1-kwolf@redhat.com> <20200813162935.210070-21-kwolf@redhat.com> From: Max Reitz Autocrypt: addr=mreitz@redhat.com; prefer-encrypt=mutual; keydata= mQENBFXOJlcBCADEyyhOTsoa/2ujoTRAJj4MKA21dkxxELVj3cuILpLTmtachWj7QW+TVG8U /PsMCFbpwsQR7oEy8eHHZwuGQsNpEtNC2G/L8Yka0BIBzv7dEgrPzIu+W3anZXQW4702+uES U29G8TP/NGfXRRHGlbBIH9KNUnOSUD2vRtpOLXkWsV5CN6vQFYgQfFvmp5ZpPeUe6xNplu8V mcTw8OSEDW/ZnxJc8TekCKZSpdzYoxfzjm7xGmZqB18VFwgJZlIibt1HE0EB4w5GsD7x5ekh awIe3RwoZgZDLQMdOitJ1tUc8aqaxvgA4tz6J6st8D8pS//m1gAoYJWGwwIVj1DjTYLtABEB AAG0HU1heCBSZWl0eiA8bXJlaXR6QHJlZGhhdC5jb20+iQFTBBMBCAA9AhsDBQkSzAMABQsJ CAcCBhUICQoLAgQWAgMBAh4BAheABQJVzie5FRhoa3A6Ly9rZXlzLmdudXBnLm5ldAAKCRD0 B9sAYdXPQDcIB/9uNkbYEex1rHKz3mr12uxYMwLOOFY9fstP5aoVJQ1nWQVB6m2cfKGdcRe1 2/nFaHSNAzT0NnKz2MjhZVmcrpyd2Gp2QyISCfb1FbT82GMtXFj1wiHmPb3CixYmWGQUUh+I AvUqsevLA+WihgBUyaJq/vuDVM1/K9Un+w+Tz5vpeMidlIsTYhcsMhn0L9wlCjoucljvbDy/ 8C9L2DUdgi3XTa0ORKeflUhdL4gucWoAMrKX2nmPjBMKLgU7WLBc8AtV+84b9OWFML6NEyo4 4cP7cM/07VlJK53pqNg5cHtnWwjHcbpGkQvx6RUx6F1My3y52vM24rNUA3+ligVEgPYBuQEN BFXOJlcBCADAmcVUNTWT6yLWQHvxZ0o47KCP8OcLqD+67T0RCe6d0LP8GsWtrJdeDIQk+T+F xO7DolQPS6iQ6Ak2/lJaPX8L0BkEAiMuLCKFU6Bn3lFOkrQeKp3u05wCSV1iKnhg0UPji9V2 W5eNfy8F4ZQHpeGUGy+liGXlxqkeRVhLyevUqfU0WgNqAJpfhHSGpBgihUupmyUg7lfUPeRM DzAN1pIqoFuxnN+BRHdAecpsLcbR8sQddXmDg9BpSKozO/JyBmaS1RlquI8HERQoe6EynJhd 64aICHDfj61rp+/0jTIcevxIIAzW70IadoS/y3DVIkuhncgDBvGbF3aBtjrJVP+5ABEBAAGJ ASUEGAEIAA8FAlXOJlcCGwwFCRLMAwAACgkQ9AfbAGHVz0CbFwf9F/PXxQR9i4N0iipISYjU sxVdjJOM2TMut+ZZcQ6NSMvhZ0ogQxJ+iEQ5OjnIputKvPVd5U7WRh+4lF1lB/NQGrGZQ1ic alkj6ocscQyFwfib+xIe9w8TG1CVGkII7+TbS5pXHRxZH1niaRpoi/hYtgzkuOPp35jJyqT/ /ELbqQTDAWcqtJhzxKLE/ugcOMK520dJDeb6x2xVES+S5LXby0D4juZlvUj+1fwZu+7Io5+B bkhSVPb/QdOVTpnz7zWNyNw+OONo1aBUKkhq2UIByYXgORPFnbfMY7QWHcjpBVw9MgC4tGeF R4bv+1nAMMxKmb5VvQCExr0eFhJUAHAhVg== Message-ID: Date: Wed, 19 Aug 2020 11:54:49 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200813162935.210070-21-kwolf@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mreitz@redhat.com X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="M4XZPjYrCFhqioH1Xm8nYNDTwuj16bhsy" Received-SPF: pass client-ip=216.205.24.124; envelope-from=mreitz@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/19 05:42:04 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -40 X-Spam_score: -4.1 X-Spam_bar: ---- X-Spam_report: (-4.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=-1, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --M4XZPjYrCFhqioH1Xm8nYNDTwuj16bhsy Content-Type: multipart/mixed; boundary="06Uephe9hW1mjUOnOMWwzDofTx4Mr4lbs" --06Uephe9hW1mjUOnOMWwzDofTx4Mr4lbs Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 13.08.20 18:29, Kevin Wolf wrote: > Implement a new QMP command block-export-del and make nbd-server-remove > a wrapper around it. >=20 > Signed-off-by: Kevin Wolf > --- > qapi/block-export.json | 30 +++++++++++++++---- > include/block/nbd.h | 1 - > block/export/export.c | 54 ++++++++++++++++++++++++++++++++++ > block/monitor/block-hmp-cmds.c | 2 +- > blockdev-nbd.c | 28 ------------------ > nbd/server.c | 14 --------- > 6 files changed, 79 insertions(+), 50 deletions(-) [...] > diff --git a/block/monitor/block-hmp-cmds.c b/block/monitor/block-hmp-cmd= s.c > index 6c823234a9..10165252cf 100644 > --- a/block/monitor/block-hmp-cmds.c > +++ b/block/monitor/block-hmp-cmds.c > @@ -477,7 +477,7 @@ void hmp_nbd_server_remove(Monitor *mon, const QDict = *qdict) > Error *err =3D NULL; > =20 > /* Rely on NBD_SERVER_REMOVE_MODE_SAFE being the default */ This comment needs adjustment, too. With that done: Reviewed-by: Max Reitz > - qmp_nbd_server_remove(name, force, NBD_SERVER_REMOVE_MODE_HARD, &err= ); > + qmp_nbd_server_remove(name, force, BLOCK_EXPORT_REMOVE_MODE_HARD, &e= rr); > hmp_handle_error(mon, err); > } --06Uephe9hW1mjUOnOMWwzDofTx4Mr4lbs-- --M4XZPjYrCFhqioH1Xm8nYNDTwuj16bhsy Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEkb62CjDbPohX0Rgp9AfbAGHVz0AFAl889ukACgkQ9AfbAGHV z0AW8ggAjqiiFAzvxbIv/BQfXGzDvzNqDzA466ffekL4ae/Ks0jxa2/1hlqoO03a ISKiqw8MdyNUPkfrEJLA8irnCttLLXWKUeqCt+1rw58Kbk/vLDGhuh4FnJ0Dtn5V iAhiANDaGLuutuJGBFP/oEoEZ9PpCDFKGhbcxQkri+q7xRwKqLlNfig+X5tj/SCI d7ERlTvTMM8DQAezlKCYTq1c/SHVgoQplDnf30FRfP344X73kPXh9WM0OTToTnyv ZY86YtlmSPavPoh7X6Pz3r2955TgyZlETK2AYaIjF1AnROUFzJM31wyF3H4pCFjU KEX59apZ3jQsGWWo5AsNpcZfhOUXLw== =KNvw -----END PGP SIGNATURE----- --M4XZPjYrCFhqioH1Xm8nYNDTwuj16bhsy--