From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Bin Meng <bmeng.cn@gmail.com>, Keith Busch <kbusch@kernel.org>,
Kevin Wolf <kwolf@redhat.com>, Klaus Jensen <its@irrelevant.dk>,
Max Reitz <mreitz@redhat.com>,
qemu-block@nongnu.org, qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Thomas Huth" <thuth@redhat.com>,
"Daniel P . Berrange" <berrange@redhat.com>,
"Bin Meng" <bin.meng@windriver.com>,
"Minwoo Im" <minwoo.im.dev@gmail.com>,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH v2] hw/block: nvme: Fix a build error in nvme_get_feature()
Date: Wed, 10 Feb 2021 12:15:45 +0100 [thread overview]
Message-ID: <efffe227-472d-698d-d8f7-cc0bbd1800c0@redhat.com> (raw)
In-Reply-To: <299d3bdc-268c-eccc-66be-6605b23a2c92@redhat.com>
On 2/10/21 12:12 PM, Philippe Mathieu-Daudé wrote:
> Hi Bin,
>
> On 2/10/21 11:23 AM, Bin Meng wrote:
>> From: Bin Meng <bin.meng@windriver.com>
>>
>> Current QEMU HEAD nvme.c does not compile:
>>
>> hw/block/nvme.c:3242:9: error: ‘result’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
>> trace_pci_nvme_getfeat_vwcache(result ? "enabled" : "disabled");
>> ^
>> hw/block/nvme.c:3150:14: note: ‘result’ was declared here
>> uint32_t result;
>> ^
>
> Why isn't this catched by our CI? What is your host OS? Fedora 33?
Just noticed v1 and Peter's explanation:
https://lists.gnu.org/archive/html/qemu-devel/2021-02/msg03528.html
Can you amend "default GCC 5.4 on a Ubuntu 16.04 host" information
please?
>
>>
>> Explicitly initialize the result to fix it.
>>
>> Fixes: aa5e55e3b07e ("hw/block/nvme: open code for volatile write cache")
>> Signed-off-by: Bin Meng <bin.meng@windriver.com>
>>
>> ---
>>
>> Changes in v2:
>> - update function name in the commit message
>>
>> hw/block/nvme.c | 1 +
>> 1 file changed, 1 insertion(+)
next prev parent reply other threads:[~2021-02-10 11:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 10:23 [PATCH v2] hw/block: nvme: Fix a build error in nvme_get_feature() Bin Meng
2021-02-10 10:42 ` Klaus Jensen
2021-02-10 10:47 ` Minwoo Im
2021-02-10 11:12 ` Philippe Mathieu-Daudé
2021-02-10 11:15 ` Bin Meng
2021-02-10 11:23 ` Thomas Huth
2021-02-10 11:15 ` Philippe Mathieu-Daudé [this message]
2021-02-10 11:17 ` Bin Meng
2021-02-10 11:22 ` Daniel P. Berrangé
2021-02-10 11:34 ` Daniel P. Berrangé
2021-02-10 22:29 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=efffe227-472d-698d-d8f7-cc0bbd1800c0@redhat.com \
--to=philmd@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=bin.meng@windriver.com \
--cc=bmeng.cn@gmail.com \
--cc=its@irrelevant.dk \
--cc=kbusch@kernel.org \
--cc=kwolf@redhat.com \
--cc=minwoo.im.dev@gmail.com \
--cc=mreitz@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).