Re: [PATCH v3 5/7] iotests: Conditionally silence certain AQMP errors

[Hanna Reitz <hreitz@redhat.com>]

On 13.10.21 00:34, John Snow wrote:
> AQMP likes to be very chatty about errors it encounters. In general,
> this is good because it allows us to get good diagnostic information for
> otherwise complex async failures.
>
> For example, during a failed QMP connection attempt, we might see:
>
> +ERROR:qemu.aqmp.qmp_client.qemub-2536319:Negotiation failed: EOFError
> +ERROR:qemu.aqmp.qmp_client.qemub-2536319:Failed to establish session: EOFError
>
> This might be nice in iotests output, because failure scenarios
> involving the new QMP library will be spelled out plainly in the output
> diffs.
>
> For tests that are intentionally causing this scenario though, filtering
> that log output could be a hassle. For now, add a context manager that
> simply lets us toggle this output off during a critical region.
>
> (Additionally, a forthcoming patch allows the use of either legacy or
> async QMP to be toggled with an environment variable. In this
> circumstance, we can't amend the iotest output to just always expect the
> error message, either. Just suppress it for now. More rigorous log
> filtering can be investigated later if/when it is deemed safe to
> permanently replace the legacy QMP library.)
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
>   tests/qemu-iotests/iotests.py             | 20 +++++++++++++++++++-
>   tests/qemu-iotests/tests/mirror-top-perms | 12 ++++++++----
>   2 files changed, 27 insertions(+), 5 deletions(-)

Reviewed-by: Hanna Reitz <hreitz@redhat.com>