From: Jason Wang <jasowang@redhat.com>
To: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>,
qemu devel <qemu-devel@nongnu.org>
Cc: zhanghailiang <zhang.zhanghailiang@huawei.com>,
Li Zhijian <lizhijian@cn.fujitsu.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [Qemu-devel] [PATCH V3 0/4] Optimize COLO-compare performance
Date: Mon, 21 Aug 2017 11:55:07 +0800 [thread overview]
Message-ID: <f00fdc9a-6f9a-bae2-78a0-9d1124ca9640@redhat.com> (raw)
In-Reply-To: <e41d36bc-ed32-8d0d-7fff-bf68fb78707c@cn.fujitsu.com>
On 2017年08月21日 09:45, Zhang Chen wrote:
> Hi~~ All~
>
> No one review this series for a long time.
>
> Ping...
>
>
Looks ok to me. But I don't like patch 1 since it adds more TODO
especially for a non-exist function colo_notify_checkpoint().
I tend to have it after colo_notify_checkpoint() is implemented or merged.
Thanks
next prev parent reply other threads:[~2017-08-21 3:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-19 7:29 [Qemu-devel] [PATCH V3 0/4] Optimize COLO-compare performance Zhang Chen
2017-07-19 7:29 ` [Qemu-devel] [PATCH V3 1/4] net/colo-compare.c: Add checkpoint min period to optimize performance Zhang Chen
2017-07-19 7:29 ` [Qemu-devel] [PATCH V3 2/4] net/colo-compare.c: Optimize unpredictable tcp options comparison Zhang Chen
2017-07-19 7:29 ` [Qemu-devel] [PATCH V3 3/4] net/colo-compare.c: Adjust net queue pop order for performance Zhang Chen
2017-07-19 7:29 ` [Qemu-devel] [PATCH V3 4/4] net/colo-compare.c: Fix comments and scheme Zhang Chen
2017-07-19 10:20 ` [Qemu-devel] [PATCH V3 0/4] Optimize COLO-compare performance no-reply
2017-08-21 1:45 ` Zhang Chen
2017-08-21 3:55 ` Jason Wang [this message]
2017-08-21 5:17 ` Zhang Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f00fdc9a-6f9a-bae2-78a0-9d1124ca9640@redhat.com \
--to=jasowang@redhat.com \
--cc=dgilbert@redhat.com \
--cc=lizhijian@cn.fujitsu.com \
--cc=qemu-devel@nongnu.org \
--cc=zhang.zhanghailiang@huawei.com \
--cc=zhangchen.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).