From: Richard Henderson <richard.henderson@linaro.org>
To: Andrew Jones <drjones@redhat.com>
Cc: mark.rutland@arm.com, peter.maydell@linaro.org,
alex.bennee@linaro.org, qemu-devel@nongnu.org
Subject: Re: [PATCH v2 2/3] target/arm: Implement an IMPDEF pauth algorithm
Date: Fri, 14 Aug 2020 09:08:13 -0700 [thread overview]
Message-ID: <f03443e2-df9d-cb19-f964-48ba821a28ef@linaro.org> (raw)
In-Reply-To: <20200814092626.g63wbmvt5yvadeeb@kamzik.brq.redhat.com>
On 8/14/20 2:26 AM, Andrew Jones wrote:
>> +static uint64_t __attribute__((noinline))
>> +pauth_computepac_impdef(uint64_t data, uint64_t modifier, ARMPACKey key)
>
> Out of curiosity, why do we need to make these computepac functions
> noinline?
Oh, heh. Left over from profiling. Will remove.
> I think this patch should come before the last one. As it stands, when
> bisecting between the last one and this one a user could attempt to
> enable pauth-imdef, but it wouldn't do anything, or it would potentially
> break things. However, this patch shouldn't change anything if it comes
> first.
The current patch ordering would enable impdef but implement that with the
architected algorithm. Which is ok.
But you're right that the other ordering makes more sense.
r~
next prev parent reply other threads:[~2020-08-14 16:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-13 20:02 [PATCH v2 0/3] target/arm: Implement an IMPDEF pauth algorithm Richard Henderson
2020-08-13 20:02 ` [PATCH v2 1/3] target/arm: Add cpu properties to control pauth Richard Henderson
2020-08-14 9:17 ` Andrew Jones
2020-08-14 9:38 ` Andrew Jones
2020-08-13 20:02 ` [PATCH v2 2/3] target/arm: Implement an IMPDEF pauth algorithm Richard Henderson
2020-08-14 9:26 ` Andrew Jones
2020-08-14 16:08 ` Richard Henderson [this message]
2020-08-13 20:02 ` [PATCH v2 3/3] target/arm: Use object_property_add_bool for "sve" property Richard Henderson
2020-08-14 9:33 ` Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f03443e2-df9d-cb19-f964-48ba821a28ef@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=drjones@redhat.com \
--cc=mark.rutland@arm.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).