From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:55511) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gj6Om-0008Jn-6S for qemu-devel@nongnu.org; Mon, 14 Jan 2019 12:51:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gj6Ok-0003Wy-VH for qemu-devel@nongnu.org; Mon, 14 Jan 2019 12:51:44 -0500 References: <1547470346-18416-1-git-send-email-thuth@redhat.com> <20190114162003.274d5921.cohuck@redhat.com> From: Thomas Huth Message-ID: Date: Mon, 14 Jan 2019 18:51:35 +0100 MIME-Version: 1.0 In-Reply-To: <20190114162003.274d5921.cohuck@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [qemu-s390x] [PATCH v2] configure: Only build the s390-ccw bios if the compiler supports -march=z900 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cornelia Huck Cc: qemu-s390x@nongnu.org, qemu-devel@nongnu.org On 2019-01-14 16:20, Cornelia Huck wrote: > On Mon, 14 Jan 2019 13:52:26 +0100 > Thomas Huth wrote: > >> We want to build our s390-ccw bios with -march=z900 so that it also >> works with the oldest s390x CPU that we support with TCG. However, >> Clang on s390x does not support -march=z900 anymore, so we can not >> use this compiler to build the s390-ccw bios. Thus add a proper test >> to the configure script to see whether the compiler is usable. >> >> Signed-off-by: Thomas Huth >> --- >> v2: Use compile_prog as suggested by Peter >> >> configure | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) > > With this, the fpu/softfloat patch, and Marcel's rdma patches, I can > compile with clang on my Fedora 29 s390x system. Yeah! > > Should this patch go through the s390 tree, or take some other path? There is no dedicated maintainer for the configure script, so please take it through the s390 tree. Thanks, Thomas