From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35252C33CAC for ; Thu, 6 Feb 2020 15:42:59 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0009121741 for ; Thu, 6 Feb 2020 15:42:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=gmx.net header.i=@gmx.net header.b="cxBy6Xy1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0009121741 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=gmx.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:41264 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1izjIw-0008Va-13 for qemu-devel@archiver.kernel.org; Thu, 06 Feb 2020 10:42:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44765) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1izjFP-00070S-AT for qemu-devel@nongnu.org; Thu, 06 Feb 2020 10:39:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1izjFM-0001K6-PH for qemu-devel@nongnu.org; Thu, 06 Feb 2020 10:39:18 -0500 Received: from mout.gmx.net ([212.227.15.18]:56391) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1izjFM-0001FX-3X for qemu-devel@nongnu.org; Thu, 06 Feb 2020 10:39:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1581003547; bh=3A2+2Vtrzu2mbMVcJgsza9A23fS23NoknCAW2Wsron0=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=cxBy6Xy1IManoy60wNLbeig0NgHLJaHl7oq+HZV5Vbc90ul/3y0dmac7VXvhUL55A 0W5D6qflSvlj5KgIghFb26RhpyIZFMe+0xPQSCfbVPX2pd4O7kLTvJ4zJ245SViGTc 9XLEWKslmUyy4ThhPeeJ/neudK66exvnsfWXaPb0= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.0.241] ([89.71.135.231]) by mail.gmx.com (mrgmx005 [212.227.17.184]) with ESMTPSA (Nemesis) id 1M9FjR-1iv2PV4BGh-006Psp; Thu, 06 Feb 2020 16:39:07 +0100 Subject: Re: [PATCH v2 4/4] Add the NVMM acceleration enlightenments To: Markus Armbruster References: <20200107124903.16505-1-n54@gmx.com> <20200128140945.929-1-n54@gmx.com> <20200128140945.929-5-n54@gmx.com> <0ed12efa-eee4-b3ff-8f02-f9c3b80d0e21@redhat.com> <2ae4caf9-05fd-b740-2612-e1c1ecafe277@gmx.com> <87o8ubuapr.fsf@dusky.pond.sub.org> <87v9ojst1h.fsf@dusky.pond.sub.org> From: Kamil Rytarowski Autocrypt: addr=n54@gmx.com; prefer-encrypt=mutual; keydata= mQINBFVwUF8BEADHmOg7PFLIcSDdMx5HNDYr8MY2ExGfUTrKwPndbt3peaa5lHsK+UGoPG48 KiWkhEaMmjaXHFa7XgVpJHhFmNoJXfPgjI/sOKTMCPQ5DEHEHTibC4mta7IBAk+rmnaOF0k8 bxHfP8Qbls66wvicrAfTRXn/1ReeNc3NP4Sq39PoVHkfQTlnQiD4eAqBdq61B7DhzjhbKAZ4 RsNtLfB6eOv9qvmblUzs50ChYewM9hvn+c7MdDH+x2UXoSDhkBDkKcJGkX91evos8s9AuoEd D32X5e+bmdUGe8Cr3cAZJ8IEXR6F9828/kxzPliMsCWVRx1Fr28baCJOUGgFPNr3ips78m9+ Iw8PdQ101jU0dvucDFxw/1SCGYEZzV+O/237oRPuLCiDX5nhQoxf6dn9ukQleLBMNy2BLI4H g342NhF21HLA+KlyLOHaMKQCKzlal+zVNZTRTCh/ikMhsxWQjBfnqTDbMj85DnWwtump27SI qhPjUnS0a6MKoS/A+hbi64k5zztkvloELfCSrX7NyBTT0jgF2IGFIxZMrKCtQ9StcGMCV9MX tjcBy6fj7QMontEaIDRJEMjg8UIGw1B687OhalOv1ISia4xOWvpYAM6ipgqh6tBQmFzasL9P h1RtcVdFpFbhwVlr1Bly8c25gBNQHL5GUjLMn45LlQz50OzrkwARAQABtCdLYW1pbCBSeXRh cm93c2tpIChOZXRCU0QpIDxuNTRAZ214LmNvbT6JAjwEEwEIACYCGyMHCwkIBwMCAQYVCAIJ CgsEFgIDAQIeAQIXgAUCVbKGFwIZAQAKCRBLswjpsC52bIVpD/9i8npieI91xMIVvAHIUMeo cQO0IrNb+b/PuTj2qNemdwU7dhVJ7tVU5O1H2hI2M4rHGzjzDTxYzdxka0+A8CVEuvFdf6sF lXlXF0wM7rC6MoaB0QLAKxkZB5OtCILxLx7Bl2Y4cTPMU9v+qSL6yrdmhxogkufa4d6O9Zl/ FCWO2kH/BphKOiDtbyvdo2WULSLWP2IXN+0rCpNL4wbTfYLgV9JtMf8f0naGsdy7BFuDWsIE vtHh8dkQZP7dz6Qy67kx8negZaehSEgXwiae0HwQIn3xTQrFmBDALDsCgXuLWPTvglSkqTak uG+8X5fyTy0cU10TNKsU+rFBO+/xsUoIQOGrARwfWOIfJNPelzh/qigSnyNQNH8u5vFRPg9n fqB/AcvvAvtOYOo8EN9Ofx11gNj397NXc5HBQTrX6k5GNAeBWE3Ng1uO6scIwAS7qGnqGezU ABmQKLN37gmJiiGwhQAnSE6HILLBC5Z2b0S2rQsPKg8WgUmPa1YIcDkDtNB/LJcDsdU4Fm+r U2ksKU7tGD2ZfBt8H2nqfPKKeB+Uv/TBigjRvx/m70vjhqVxwCZA9Fqr9vkQkZroNfqP+3dp Z5V5fjmxO5abE2+IikSvFagwMtgx56i8Yrr2BzE8P5/S4cKq1kgyQoF+lVGDKRkUKCv1i4Fo aftnSxN8jTFZDbkCDQRVcFBfARAAutbzb8wAHGL5FPPWKErQ3Bsrp9RDTVqRzp7kBMOtd/14 MrOsWWyiml4XnvBYsJuhZWomFoeulcOXAPoTJ2vTw6erWYtdOiZymfQ3GMWpxzgkOVeNjsFF 9AQ38FCMKmIDs9dgn+KXSIXlZA34khKLd163SN5U/KHfYlnnocec31u+7rVa1hlF5DBSSpoi s8cs41foBYC5NsB/i+yqGIlfzHy7pC2u5kyQCuJotLH4y0rT5X+YBC7z7cqKChtILNDGw0ht qps29fwOGBE/FWmu8CbpSHj8pvg7uUyQcKbZbNChBfWtOJKdjnNs5VHf2ec95SwYmWl6Xz66 G892HY4ODtvl05/kh0qtdJd2oI4gJBsBx/N1585/3JYN4k78GIHTnML3xJydRRs9wwM3AXf/ iDGrMyY7qHQVXJLdO5nPe7LHg48vryCMkBnTMw5iNFPVCu5w1BaZyHxuS2HvpsgUtQoBa2QE P1jYNI+2qgoiIG4VQDhYtrD0WJaYdi/C2UVDxRy07dt73SV3RQ7ijOiUrz4g3/deFKY16/1k sE+N5Sc5Tjt84ChjO3nJRbHrQxd6dCOElR70e3R2yAuSB4m7LJpO20IB9CtWhlF/0AtfL91W O8GGGqLWB0Z04hmwRs/l8T4WWIlykLshbunWN6jsP1Y27FeilTZ+Pc9mYOEUFfEAEQEAAYkC HwQYAQgACQUCVXBQXwIbDAAKCRBLswjpsC52bPayD/9jE8mdNudrudSxbDB2vf8pU8r5flCq vIkfOdpZGV/Wx/Zx+HFHHp+b2aNBGSNyFTnph1Ku9bvg06vD0o+b7SdA1vrBgRG41t0OCIyf vejz65Xpin2EtCllcBM8zUCxHo43blON8fNw70P1Ec0loBp4TAal1MiXbB8kxRTRcEPVO9YF 9NPsFxycoWl0ZSvu4ESrQlrjRbVv+W0Fy/XqcQwEtDziFQHQXNRbTy8INPD49CsB7BkKRK+f 1vMmw7SxfsyEhyCgo9ZWfHb/+w9T5h+UhF87L/m287z7W+s4aCAPBzjbIWhtngGJJwIgiWdI I9J6YJLcHLvVZLw7xzA/flcjc0VfzOgJOJw3hBukHnEz7/CKgnABwyNu52P+PQbxVTiTjMKm 06eV732u9ZLD9ZgEazfmyGDHzsuzoXwsRnmcnbwYYAiynS+vfGl5oMtMa5qzsPhlzuvRlXHm zr8VjF8c9RThvyZyyHtWYAqNmBecMvM0whigjMeoAMJ5LtpyZgxjbHj1XnVdNBZgfJkOzsc/ twffi7RYphRx0d9z5UZ1Yl5Rvl05vTaJ7YhhNC7xuE8yGOQmDUsPDwWqO/eXUDErJjCOBR5b 0yILqRPYNT0Fj/th9gtEbZy1Gp0TVBkZM3tfjDRu43Pn6iSKObO/j0rNuq1LwN/EMxDifeZO 4XSbcg== Message-ID: Date: Thu, 6 Feb 2020 16:38:20 +0100 User-Agent: Mozilla/5.0 (X11; NetBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <87v9ojst1h.fsf@dusky.pond.sub.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:Pf5QnvjQoRCa1Jyk4DGsaD1X6nQOVRvFIvAQSrIzh/0RPrmtVcs jqIB96Ubb9cDjI+BK6Vq1JOwr8nPcAc68M2xSuYPiiSyWCjmq3IKTIv3EkSRRkwtTjcaXIB 9Cdm47r2nAD6EaOKSCv/dor+luTdNtAv9vqCF+2sm8RRaN3iLgSnakc1IHdDr1R2/91zVGN 1nMJMFqJR0iOOzYPLrJUg== X-UI-Out-Filterresults: notjunk:1;V03:K0:8uASLeFAUVs=:EHj/mEAOgPIVQ9165w3vgu wt6fDoaKLCI2TcVnsYJ+m2p+Rot4X82jpes/HL++yLpLzMAWYrbULo+wcHdq5MCEdOr8QGrgY VoHUclz4YErx46x0INlaXKkvV2mGVvLHj8ulF59qENJ29Syabshzo3NPeTk9tzFSXACQ6pa5O Jr1nYog18YcHzzgrj4xneSTCiccyvHyHOXEtUsXKk3o19S7Y5CDHNPmvXzIUnkTymuMMMu6QG 78shkVM2pCmEq7VbjUcYfXJPBO5RCJGguqqLTVQUlSB5clZB/dMwOHv3fAUapNjXdBAK02u8p qiACHVn7sMqBS0rGHNx8vELobBZcSMdkgEn6JXX7LiYbT1vCfv5pYjS7NsTFsYqolb8vXHn6G tgYcIX2686e/bjQYlMgf30UdojHdh0YvlIWk+7SJDphidqSkwnRV0/TL6WQ80aJSfgHAbZG93 ao4mMjdfd4VVfGJLi9BL+qnfdzd7GVjOWKJwkAi3mMGz7kSp82Tm8dUvAG9/p79FzCIDrKR6w iKsNlJ/LrvlRpG50JoOQYjQ2D4sBUDU+fUUz3w2BGMrR649TR4K0Z+50aosNCcm7m7lQ9/yyX Zeza5Mudp8gTdsQXn3xrJ7Iz/gCp0Wz8CTg+rh5ki7GhmmaRDGV/75AhMN8j4uxKm4jl2G6SF BgZjKna8HPFg8hM9PYqI5IhseUOQLiqnVRWRAU49AmfSzw6yLrD/eC0mL+IyQ62+M8YAAczhp 6hjqYAjW4RxzDGava+f8MrILMhJ1BW8eOnNhJ9CoUvy48+C23RUAqiGmtswyYMOLrvYAf7nnD 8GBy65/6YLEyByKqQClAz6Bk9wGC09puNG1nv+V9ARyg/CSybslO1qjUAH86XJWwv++Jy5Ige iEQPCdRtZZkyUpX5xp5Hoo2pJ9Dm/wGjgOUl/TWhBj84RKUwW4RZU8AZbiSlj7105ySXC1Lds G8EI9mIkDbuKFWL9YoLueMI2HvzvGvO8LO9RI0H8mCHOOTQp8dQtKa6o3yOxi3fY0PcWgc5Do XOqHLSk95fDYWSmQhcBKmsXq+83FSNL4f9yibr0L+ZUB3wFwrHaICu2++IYL6+nwxfhzrbjeJ HZPXHIdDZcyADUX3/JLcBs74wTqPOL6D1ujR/WsClGoi/mbShCumMn7f/N9gp1fjpeKvK/ETe HJLeH/jtAJpUQlOJKKfk2dnfLv+S6iGza9FveXXvH1QesjZ9Z99tTYH6LCUXssCVDleNs= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.15.18 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Eduardo Habkost , Sergio Lopez , QEMU Developers , Paolo Bonzini , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , max@m00nbsd.net, Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 06.02.2020 15:13, Markus Armbruster wrote: > Kamil Rytarowski writes: > >> On 06.02.2020 14:09, Philippe Mathieu-Daud=C3=A9 wrote: >>> On Thu, Feb 6, 2020 at 2:06 PM Markus Armbruster w= rote: >>>> Kamil Rytarowski writes: >>>> >>>>> On 03.02.2020 12:54, Philippe Mathieu-Daud=C3=A9 wrote: >>>>>>> @@ -2029,6 +2072,19 @@ static void qemu_whpx_start_vcpu(CPUState *= cpu) >>>>>>> #endif >>>>>>> } >>>>>>> >>>>>>> +static void qemu_nvmm_start_vcpu(CPUState *cpu) >>>>>>> +{ >>>>>>> + char thread_name[VCPU_THREAD_NAME_SIZE]; >>>>>>> + >>>>>>> + cpu->thread =3D g_malloc0(sizeof(QemuThread)); >>>>>>> + cpu->halt_cond =3D g_malloc0(sizeof(QemuCond)); >>>>>> >>>>>> Nitpick, we prefer g_new0(). >>>>> >>>>> In this file other qemu_*_start_vcpu() use g_malloc0(). >>>>> >>>>> I will leave this part unchanged and defer tor future style fixups i= f >>>>> someone is interested. >>>> >>>> Time to re-run Coccinelle with the semantic patch from commit >>>> b45c03f585e. >>> >>> I thought about it, but then noticed it would be clever to modify >>> checkpatch to refuse 'g_malloc0?(.*sizeof.*);' >>> >>> >> >> As the patchset was reviewed, could we please merge it in the current >> (v3) form (*) please? > > No objection. If I wanted you to clean this up before we accept your > work, I would've told you :) > > [...] > > I see. I don't own myself a merge queue so I depend on yours. Thank you in advance!