From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59454) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1daig9-0003uW-Mq for qemu-devel@nongnu.org; Thu, 27 Jul 2017 09:18:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1daig4-0002R9-Kn for qemu-devel@nongnu.org; Thu, 27 Jul 2017 09:18:13 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:47892) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1daig4-0002Qa-B0 for qemu-devel@nongnu.org; Thu, 27 Jul 2017 09:18:08 -0400 Received: from pps.filterd (m0098394.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id v6RDEUsR137965 for ; Thu, 27 Jul 2017 09:18:06 -0400 Received: from e06smtp11.uk.ibm.com (e06smtp11.uk.ibm.com [195.75.94.107]) by mx0a-001b2d01.pphosted.com with ESMTP id 2byg502h7r-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Thu, 27 Jul 2017 09:18:06 -0400 Received: from localhost by e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 27 Jul 2017 14:18:04 +0100 References: <20170725224442.13383-1-pasic@linux.vnet.ibm.com> <20170727102636.43d6a789@gondolin> From: Halil Pasic Date: Thu, 27 Jul 2017 15:18:01 +0200 MIME-Version: 1.0 In-Reply-To: <20170727102636.43d6a789@gondolin> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Message-Id: Subject: Re: [Qemu-devel] [PATCH 0/2] ccw interpretation AR compliance improvements List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cornelia Huck Cc: Christian Borntraeger , Dong Jia Shi , qemu-devel@nongnu.org [Re-posting my previous reply because I've accidentally dropped almost all addresses.] On 07/27/2017 10:26 AM, Cornelia Huck wrote: > On Wed, 26 Jul 2017 00:44:40 +0200 > Halil Pasic wrote: > >> There were some missing checks. There might be some more missing. For details, >> see the individual patches. > > The checks are not perfect? Colour me shocked ;) > With a fedora or without ;)? >> >> Regarding testing: did not do much more than a simple smoke test >> with virtio-ccw. > > I think we need a way to throw random channel programs at a channel > device... > By random do you mean random random, or do you mean carefully crafted to provoke (and verify) certain responses. If it's more like the second case I've actually wrote something (a kernel driver) for 'internal use' but at the moment it's limited to indirect data access support (no test cases for invalid invalid channel programs). The 'internal guys' say it probably ain't interesting for the rest of the world make this external, but if you are interested I could send you the patch these days. Regards, Halil >> >> Halil Pasic (2): >> s390x/css: check ccw address validity >> s390x/css: fix bits must be zero check for TIC >> >> hw/s390x/css.c | 21 ++++++++++++++++++++- >> 1 file changed, 20 insertions(+), 1 deletion(-) >> > >