From: Eric Blake <eblake@redhat.com>
To: Max Reitz <mreitz@redhat.com>, qemu-block@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Daniel P . Berrangé" <berrange@redhat.com>,
qemu-devel@nongnu.org, "Maxim Levitsky" <mlevitsk@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] doc: Preallocation does not require writing zeroes
Date: Thu, 11 Jul 2019 08:34:56 -0500 [thread overview]
Message-ID: <f06a74ea-d38a-73c2-2c81-68d31e5e0116@redhat.com> (raw)
In-Reply-To: <20190711132935.13070-1-mreitz@redhat.com>
[-- Attachment #1.1: Type: text/plain, Size: 712 bytes --]
On 7/11/19 8:29 AM, Max Reitz wrote:
> When preallocating an encrypted qcow2 image, it just lets the protocol
> driver write data and then does not mark the clusters as zero.
> Therefore, reading this image will yield effectively random data.
>
> As such, we have not fulfilled the promise of always writing zeroes when
> preallocating an image in a while. It seems that nobody has really
> cared, so change the documentation to conform to qemu's actual behavior.
>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-07-11 13:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-11 13:29 [Qemu-devel] [PATCH] doc: Preallocation does not require writing zeroes Max Reitz
2019-07-11 13:34 ` Eric Blake [this message]
2019-07-11 13:42 ` Daniel P. Berrangé
2019-07-11 14:04 ` Maxim Levitsky
2019-07-12 10:27 ` [Qemu-devel] [Qemu-block] " Stefano Garzarella
2019-07-12 18:33 ` Max Reitz
2019-07-15 8:01 ` Stefano Garzarella
2019-08-15 16:10 ` [Qemu-devel] " Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f06a74ea-d38a-73c2-2c81-68d31e5e0116@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=kwolf@redhat.com \
--cc=mlevitsk@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).