Re: [Qemu-devel] [PATCH] qemu-io: fix EOF Ctrl-D handling in qemu-io readline code

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 924 bytes --]

On 12/06/2017 08:25 AM, Daniel P. Berrange wrote:

>> Should we instead be looking for a match against the current termios()
>> c_cc[VEOF] setting, in case the user prefers something other than ^D via
>> stty?  Does readline provide any functionality for automating this?
> 
> I was afraid someone was going to suggest doing that. I was being lazy by
> hardcoding Ctrl-D, but yes the real readline() library will honour the
> VEOF value.  QEMU though is using a home-grown reimpl of readline...

I understand why we can't use modern libreadline (it is licensed GPLv3+,
making it impossible to use with our GPLv2-only code) - but doesn't BSD
have a readline-alike library with BSD licensing that we could use
instead of implementing readline ourselves?  (Was it named libinput?)

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]