From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46512) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cRjxK-0003DE-Nw for qemu-devel@nongnu.org; Thu, 12 Jan 2017 13:18:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cRjxG-0008QZ-ON for qemu-devel@nongnu.org; Thu, 12 Jan 2017 13:18:34 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36926) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cRjxG-0008ND-Hx for qemu-devel@nongnu.org; Thu, 12 Jan 2017 13:18:30 -0500 References: <1484032051-11619-1-git-send-email-he.chen@linux.intel.com> <20170112171029.GD27893@thinpad.lan.raisama.net> From: Paolo Bonzini Message-ID: Date: Thu, 12 Jan 2017 19:18:20 +0100 MIME-Version: 1.0 In-Reply-To: <20170112171029.GD27893@thinpad.lan.raisama.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] x86: add AVX512_VPOPCNTDQ features List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost , He Chen Cc: qemu-devel@nongnu.org, He Chen , Richard Henderson On 12/01/2017 18:10, Eduardo Habkost wrote: > On Tue, Jan 10, 2017 at 03:07:31PM +0800, He Chen wrote: >> AVX512_VPOPCNTDQ: Vector POPCNT instructions for word and qwords. >> variable precision. >> >> Signed-off-by: He Chen >> --- >> target/i386/cpu.c | 2 +- >> target/i386/cpu.h | 1 + >> 2 files changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/target/i386/cpu.c b/target/i386/cpu.c >> index b0640f1..ae900b5 100644 >> --- a/target/i386/cpu.c >> +++ b/target/i386/cpu.c >> @@ -435,7 +435,7 @@ static FeatureWordInfo feature_word_info[FEATURE_WORDS] = { >> NULL, "avx512vbmi", "umip", "pku", >> "ospke", NULL, NULL, NULL, >> NULL, NULL, NULL, NULL, >> - NULL, NULL, NULL, NULL, >> + NULL, NULL, "vpopcntdq", NULL, > > The patches I see on linux-kernel use the "avx512_vpopcntdq" > name. Why not use "avx512-vpopcntdq" in QEMU to avoid confusion? Or without the dash too, for consistency with avx512vbmi. Paolo > >> "la57", NULL, NULL, NULL, >> NULL, NULL, "rdpid", NULL, >> NULL, NULL, NULL, NULL, >> diff --git a/target/i386/cpu.h b/target/i386/cpu.h >> index a7f2f60..73edc60 100644 >> --- a/target/i386/cpu.h >> +++ b/target/i386/cpu.h >> @@ -630,6 +630,7 @@ typedef uint32_t FeatureWordArray[FEATURE_WORDS]; >> #define CPUID_7_0_ECX_UMIP (1U << 2) >> #define CPUID_7_0_ECX_PKU (1U << 3) >> #define CPUID_7_0_ECX_OSPKE (1U << 4) >> +#define CPUID_7_0_ECX_VPOPCNTDQ (1U << 14) /* POPCNT for vectors of DW/QW */ >> #define CPUID_7_0_ECX_LA57 (1U << 16) >> #define CPUID_7_0_ECX_RDPID (1U << 22) >> >> -- >> 2.7.4 >> >> >