From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Paul Burton <paulburton@kernel.org>,
Aleksandar Rikalo <arikalo@gmail.com>,
Eduardo Habkost <eduardo@habkost.net>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
Yanan Wang <wangyanan55@huawei.com>,
Zhao Liu <zhao1.liu@intel.com>, Jia Liu <proljc@gmail.com>
Subject: Re: [PATCH 2/6] hw/openrisc: Support monitor dumpdtb command
Date: Mon, 10 Feb 2025 11:57:43 +0100 [thread overview]
Message-ID: <f0a0f932-5394-4dd8-8185-1fa4e8947a13@linaro.org> (raw)
In-Reply-To: <20250206151214.2947842-3-peter.maydell@linaro.org>
On 6/2/25 16:12, Peter Maydell wrote:
> The openrisc machines don't set MachineState::fdt to point to their
> DTB blob. This means that although the command line '-machine
> dumpdtb=file.dtb' option works, the equivalent QMP and HMP monitor
> commands do not, but instead produce the error "This machine doesn't
> have a FDT".
>
> Set MachineState::fdt in openrisc_load_fdt(), when we write it to
> guest memory.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> include/hw/openrisc/boot.h | 3 ++-
> hw/openrisc/boot.c | 7 +++++--
> hw/openrisc/openrisc_sim.c | 2 +-
> hw/openrisc/virt.c | 2 +-
> 4 files changed, 9 insertions(+), 5 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2025-02-10 10:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-06 15:12 [PATCH 0/6] hw: Centralize handling, improve error messages for -machine dumpdtb Peter Maydell
2025-02-06 15:12 ` [PATCH 1/6] monitor/hmp-cmds.c: Clean up hmp_dumpdtb printf Peter Maydell
2025-02-06 20:46 ` Richard Henderson
2025-02-10 10:57 ` Philippe Mathieu-Daudé
2025-02-06 15:12 ` [PATCH 2/6] hw/openrisc: Support monitor dumpdtb command Peter Maydell
2025-02-06 20:48 ` Richard Henderson
2025-02-10 10:57 ` Philippe Mathieu-Daudé [this message]
2025-02-06 15:12 ` [PATCH 3/6] hw/mips/boston: Check for error return from boston_fdt_filter() Peter Maydell
2025-02-10 10:48 ` Philippe Mathieu-Daudé
2025-02-06 15:12 ` [PATCH 4/6] hw/mips/boston: Support dumpdtb monitor commands Peter Maydell
2025-02-10 10:56 ` Philippe Mathieu-Daudé
2025-02-10 11:09 ` Peter Maydell
2025-02-10 11:37 ` Philippe Mathieu-Daudé
2025-02-06 15:12 ` [PATCH 5/6] hw: Centralize handling of -machine dumpdtb option Peter Maydell
2025-02-06 20:51 ` Richard Henderson
2025-02-06 15:12 ` [PATCH 6/6] hw/core/machine.c: Make -machine dumpdtb=file.dtb with no DTB an error Peter Maydell
2025-02-06 20:52 ` Richard Henderson
2025-02-24 14:50 ` [PATCH 0/6] hw: Centralize handling, improve error messages for -machine dumpdtb Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0a0f932-5394-4dd8-8185-1fa4e8947a13@linaro.org \
--to=philmd@linaro.org \
--cc=arikalo@gmail.com \
--cc=eduardo@habkost.net \
--cc=marcel.apfelbaum@gmail.com \
--cc=paulburton@kernel.org \
--cc=peter.maydell@linaro.org \
--cc=proljc@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=wangyanan55@huawei.com \
--cc=zhao1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).