From: Dongli Zhang <dongli.zhang@oracle.com>
To: quintela@redhat.com
Cc: qemu-devel@nongnu.org, philmd@linaro.org, armbru@redhat.com,
thuth@redhat.com, kkostiuk@redhat.com, berrange@redhat.com,
dwmw@amazon.co.uk, pbonzini@redhat.com, joe.jin@oracle.com
Subject: Re: [PATCH v3 1/1] hmp: synchronize cpu state for lapic info
Date: Tue, 31 Oct 2023 15:24:20 -0700 [thread overview]
Message-ID: <f0adae79-7c6c-3e52-3bd1-f2e094d4a735@oracle.com> (raw)
In-Reply-To: <87edhc9inl.fsf@secure.mitica>
Hi Juan,
On 10/30/23 09:31, Juan Quintela wrote:
> Dongli Zhang <dongli.zhang@oracle.com> wrote:
>> While the default "info lapic" always synchronizes cpu state ...
>>
>> mon_get_cpu()
>> -> mon_get_cpu_sync(mon, true)
>> -> cpu_synchronize_state(cpu)
>> -> ioctl KVM_GET_LAPIC (taking KVM as example)
>>
>> ... the cpu state is not synchronized when the apic-id is available as
>> argument.
>>
>> The cpu state should be synchronized when apic-id is available. Otherwise
>> the "info lapic <apic-id>" always returns stale data.
>>
>> Reference:
>> https://urldefense.com/v3/__https://lore.kernel.org/all/20211028155457.967291-19-berrange@redhat.com/__;!!ACWV5N9M2RV99hQ!KOLfuCesLC4T6ka9bjf4x6ncC34GPK9pVvWwOJhbwSZw2fwp3Mxlakk0fnR-NCoqRPKOX7X4SOAxozQBC7VQ$
>>
>> Cc: Joe Jin <joe.jin@oracle.com>
>> Signed-off-by: Dongli Zhang <dongli.zhang@oracle.com>
>> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
>> Reviewed-by: David Woodhouse <dwmw@amazon.co.uk>
>
> Reviewed-by: Juan Quintela <quintela@redhat.com>
>
> But I wonder how I did get CC'd on this patch O:-)
>
Thank you very much!
This component does not have a maintainer. I just blindly cc all suggested
reviewers :), in order to get it reviewed and merged.
get_maintainer.pl: No maintainers found, printing recent contributors.
get_maintainer.pl: Do not blindly cc: them on patches! Use common sense.
Thank you very much!
Dongli Zhang
next prev parent reply other threads:[~2023-10-31 22:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-26 21:19 [PATCH v3 1/1] hmp: synchronize cpu state for lapic info Dongli Zhang
2023-10-30 16:31 ` Juan Quintela
2023-10-31 22:24 ` Dongli Zhang [this message]
2023-11-02 6:00 ` Markus Armbruster
2023-11-06 6:46 ` Thomas Huth
2023-11-08 10:22 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0adae79-7c6c-3e52-3bd1-f2e094d4a735@oracle.com \
--to=dongli.zhang@oracle.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=dwmw@amazon.co.uk \
--cc=joe.jin@oracle.com \
--cc=kkostiuk@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).