From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48998) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e0TI3-0007ex-Fn for qemu-devel@nongnu.org; Fri, 06 Oct 2017 10:07:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e0TI2-0007GT-O9 for qemu-devel@nongnu.org; Fri, 06 Oct 2017 10:07:47 -0400 Received: from mail-qt0-x22d.google.com ([2607:f8b0:400d:c0d::22d]:48546) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e0TI2-0007G3-J8 for qemu-devel@nongnu.org; Fri, 06 Oct 2017 10:07:46 -0400 Received: by mail-qt0-x22d.google.com with SMTP id d13so30913132qta.5 for ; Fri, 06 Oct 2017 07:07:46 -0700 (PDT) References: <20170928203708.9376-1-david@redhat.com> <20170928203708.9376-30-david@redhat.com> From: Richard Henderson Message-ID: Date: Fri, 6 Oct 2017 10:07:43 -0400 MIME-Version: 1.0 In-Reply-To: <20170928203708.9376-30-david@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 29/30] s390x/tcg: refactor stfl(e) to use s390_get_feat_block() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Hildenbrand , qemu-devel@nongnu.org Cc: thuth@redhat.com, cohuck@redhat.com, Christian Borntraeger , Alexander Graf On 09/28/2017 04:37 PM, David Hildenbrand wrote: > Refactor it to use s390_get_feat_block(). Directly write into the mapped > lowcore with stfl and make sure it is really only compiled if needed. > > While at it, add an alignment check for STFLE and avoid > potential_page_fault() by properly restoring the CPU state. > > Due to s390_get_feat_block(), we will now also indicate the > "Configuration-z-architectural-mode", which is with new SIGP code the > right thing to do. > > Signed-off-by: David Hildenbrand > --- > target/s390x/misc_helper.c | 67 ++++++++++++++++++++-------------------------- > target/s390x/translate.c | 1 - > 2 files changed, 29 insertions(+), 39 deletions(-) Reviewed-by: Richard Henderson r~