qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Vivier <laurent@vivier.eu>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Subject: Re: [PATCH 0/2] linux-user: Load a vdso for x86_64
Date: Thu, 28 May 2020 11:54:32 +0200	[thread overview]
Message-ID: <f0d538fa-93b6-fdb4-e856-dfee371f1957@vivier.eu> (raw)
In-Reply-To: <20200519194452.9009-1-richard.henderson@linaro.org>

Le 19/05/2020 à 21:44, Richard Henderson a écrit :
> The subject of AT_SYSINFO came up on launchpad recently.
> 
> There is definite room for improvement in all of this:
> 
> (1) We could build the vdso binary into qemu instead of really
>     loading it from the file system.  This would obviate the
>     several problems of locating the .so file.  It would also
>     mean that --static builds continue to create a standalone
>     qemu binary.
> 
> (2) We could use our cross-build system to build the vdso.
>     Though we'd still likely want to keep the image in git
>     along side the other rom images for when cross-build is
>     not available.
> 
> (3) There are some ??? comments where some decisions could be made,
>     and other ??? that are merely commenting on weirdness.
> 
> (4) It shouldn't take too much effort to create vdsos for the
>     other architectures.  But we should get this one as clean
>     as we can first.
> 
> Amusingly, this patch set has just turned 10 years old.
> First posted April 4, 2010.  I don't recall ever seeing
> any review on the several postings over the years.
> 
> 
> r~
> 
> 
> Richard Henderson (2):
>   linux-user: Build vdso for x64.
>   linux-user: Load a VDSO for x86-64.
> 
>  Makefile                  |   4 +-
>  linux-user/elfload.c      | 203 +++++++++++++++++++++++++++++++++++++-
>  pc-bios/Makefile          |   5 +
>  pc-bios/vdso-linux-x64.S  | 115 +++++++++++++++++++++
>  pc-bios/vdso-linux-x64.ld |  81 +++++++++++++++
>  pc-bios/vdso-linux-x64.so | Bin 0 -> 7500 bytes
>  6 files changed, 401 insertions(+), 7 deletions(-)
>  create mode 100644 pc-bios/vdso-linux-x64.S
>  create mode 100644 pc-bios/vdso-linux-x64.ld
>  create mode 100755 pc-bios/vdso-linux-x64.so
> 

Applied to my linux-user branch.

Thanks,
Laurent



  parent reply	other threads:[~2020-05-28  9:55 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-19 19:44 [PATCH 0/2] linux-user: Load a vdso for x86_64 Richard Henderson
2020-05-19 19:44 ` [PATCH 1/2] linux-user: Build vdso for x64 Richard Henderson
2020-05-19 19:44 ` [PATCH 2/2] linux-user: Load a VDSO for x86-64 Richard Henderson
2020-05-28  9:54 ` Laurent Vivier [this message]
2020-05-28 10:08 ` [PATCH 0/2] linux-user: Load a vdso for x86_64 Peter Maydell
2020-05-28 10:32   ` Laurent Vivier
2020-05-28 13:20     ` Philippe Mathieu-Daudé
2020-05-28 21:42     ` Richard Henderson
2020-05-29  8:50       ` Laurent Vivier
2020-05-29  8:58         ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f0d538fa-93b6-fdb4-e856-dfee371f1957@vivier.eu \
    --to=laurent@vivier.eu \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).