From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBBD4C433DF for ; Fri, 14 Aug 2020 18:05:03 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9224720771 for ; Fri, 14 Aug 2020 18:05:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Bz741luA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9224720771 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amsat.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:57834 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k6e4c-0001iU-SX for qemu-devel@archiver.kernel.org; Fri, 14 Aug 2020 14:05:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36524) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k6e3c-0000Sv-Gb for qemu-devel@nongnu.org; Fri, 14 Aug 2020 14:04:00 -0400 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]:37700) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k6e3b-0003vH-5Z for qemu-devel@nongnu.org; Fri, 14 Aug 2020 14:04:00 -0400 Received: by mail-wr1-x442.google.com with SMTP id y3so9109575wrl.4 for ; Fri, 14 Aug 2020 11:03:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=+80pBPQDiXfAC9dVlzhj/xoqF2WY/PBN7ftRjmVQv5I=; b=Bz741luAx6WKUl6E+DPyEFhP/WvAPHjZMdP8gAuoRJkzDERPy6qq7LiHJtO9INruQQ YRWt6qN2qFQpka6kCUrcPmZR8zYdsMQD64N/3ep7xoYG6OeKGQAefOPNHq0jrTMgqUdK uAOJyOwAMbPk264IoLiugHna/b4UVq94aRl7L/+Jqim6nfQxIZqn/0aKtJkJaYpOtE6n EBiyqNZRp2Np+KjO2OgBbgcGhVEXyMzeK/UkEnikVyl7TP8o4x50F5ERsz+lm3RLgete 343WUblr0zyJZiKeV2dqwglwqtre1Qlf7LyZDPdashXmjDKVMimDkoazOSeXwu51YIYi 3KeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=+80pBPQDiXfAC9dVlzhj/xoqF2WY/PBN7ftRjmVQv5I=; b=qWpKGh+dXGw2WfDfhLCPLo+/Kc3ziBBvROdXbsmtuCwfl9KWI0JDpcqub/P/j5L9N8 iONNNPCKQ6VzkcKqSqTaoyl08Qo4ZziNdcC/RjoNytUZcSg4QTBPNnzUxBiKkAiug1VG UJOQf7WeBjEHsTENEESNaFDFO8bOoOc9azxzbeoVbNhm7h2I0b53ykX89xAx2/4RYdeB pkiBXTArUVHdMN92m2Y+sHx+JbYpVu3uL2KSXc9FzthUMHx0bwoJtQpLIqCDhxc/KA5f luwFVcRZ3lURLlkANOGP/K/GNFfoCzaUrVU14tdKMcPl8aZot/MFiZNNBOmjBWhRUjqF QQDg== X-Gm-Message-State: AOAM531GCI4Rpo6uTQ6jZi53XcdLOO+glyEpx9ZZ5hh0PhES7tUQdELJ OoeUOhpmdm39lg8LfUa01aDwAZoMeko= X-Google-Smtp-Source: ABdhPJwh1shFD9pbD+u9ySYNABjLPXNPqMp75EvfHh2sr2sw1niUBD1OHa499qsU2PwADVsS6DhMEQ== X-Received: by 2002:adf:b602:: with SMTP id f2mr3567297wre.186.1597428237787; Fri, 14 Aug 2020 11:03:57 -0700 (PDT) Received: from [192.168.1.36] (121.red-81-40-121.staticip.rima-tde.net. [81.40.121.121]) by smtp.gmail.com with ESMTPSA id p14sm18906275wrg.96.2020.08.14.11.03.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Aug 2020 11:03:57 -0700 (PDT) Subject: Re: [PATCH 22/41] can_emu: Delete macros for non-existing typedef To: Eduardo Habkost , qemu-devel@nongnu.org References: <20200813222625.243136-1-ehabkost@redhat.com> <20200813222625.243136-23-ehabkost@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: Date: Fri, 14 Aug 2020 20:03:56 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200813222625.243136-23-ehabkost@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::442; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-x442.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: 0 X-Spam_score: 0.0 X-Spam_bar: / X-Spam_report: (0.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=1, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , "Daniel P. Berrange" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 8/14/20 12:26 AM, Eduardo Habkost wrote: > CanBusClass doesn't exist. This will break when we automatically > convert the code to use OBJECT_DEFINE_TYPE(). Delete the macros > that reference the non-existing typedef. > > Signed-off-by: Eduardo Habkost Reviewed-by: Philippe Mathieu-Daudé > --- > include/net/can_emu.h | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/include/net/can_emu.h b/include/net/can_emu.h > index fce9770928..7e90fd8a45 100644 > --- a/include/net/can_emu.h > +++ b/include/net/can_emu.h > @@ -100,10 +100,6 @@ struct CanBusClientState { > }; > > #define TYPE_CAN_BUS "can-bus" > -#define CAN_BUS_CLASS(klass) \ > - OBJECT_CLASS_CHECK(CanBusClass, (klass), TYPE_CAN_BUS) > -#define CAN_BUS_GET_CLASS(obj) \ > - OBJECT_GET_CLASS(CanBusClass, (obj), TYPE_CAN_BUS) > #define CAN_BUS(obj) \ > OBJECT_CHECK(CanBusState, (obj), TYPE_CAN_BUS) > >