From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43249) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bkaJw-0005yh-9y for qemu-devel@nongnu.org; Thu, 15 Sep 2016 13:19:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bkaJu-0007jN-B5 for qemu-devel@nongnu.org; Thu, 15 Sep 2016 13:19:32 -0400 References: <1473957290-13382-1-git-send-email-den@openvz.org> <1473957290-13382-3-git-send-email-den@openvz.org> From: Eric Blake Message-ID: Date: Thu, 15 Sep 2016 12:19:20 -0500 MIME-Version: 1.0 In-Reply-To: <1473957290-13382-3-git-send-email-den@openvz.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="1oqhWCvoDMlvKU6Qr4nROc79tPa6nDrsc" Subject: Re: [Qemu-devel] [PATCH v3 2/2] mirror: fix improperly filled copy_bitmap for mirror block job List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Denis V. Lunev" , qemu-block@nongnu.org, qemu-devel@nongnu.org Cc: Kevin Wolf , Fam Zheng , Jeff Cody , Max Reitz , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --1oqhWCvoDMlvKU6Qr4nROc79tPa6nDrsc From: Eric Blake To: "Denis V. Lunev" , qemu-block@nongnu.org, qemu-devel@nongnu.org Cc: Kevin Wolf , Fam Zheng , Jeff Cody , Max Reitz , Stefan Hajnoczi Message-ID: Subject: Re: [Qemu-devel] [PATCH v3 2/2] mirror: fix improperly filled copy_bitmap for mirror block job References: <1473957290-13382-1-git-send-email-den@openvz.org> <1473957290-13382-3-git-send-email-den@openvz.org> In-Reply-To: <1473957290-13382-3-git-send-email-den@openvz.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/15/2016 11:34 AM, Denis V. Lunev wrote: > bdrv_is_allocated_above() returns true in the case even for completel s/completel/completely/ > zeroed areas as BDRV_BLOCK_ALLOCATED flag is set in both cases. >=20 > The patch stops using bdrv_is_allocated_above() wrapper and switches to= > bdrv_get_block_status_above() to distinguish zeroed areas and areas wit= h > data to avoid extra IO operations if possible. >=20 > Signed-off-by: Denis V. Lunev > CC: Stefan Hajnoczi > CC: Fam Zheng > CC: Kevin Wolf > CC: Max Reitz > CC: Jeff Cody > --- > block/mirror.c | 17 +++++++++++------ > 1 file changed, 11 insertions(+), 6 deletions(-) --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --1oqhWCvoDMlvKU6Qr4nROc79tPa6nDrsc Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJX2tgYAAoJEKeha0olJ0NqY/AH/1OVvtMtoFA/coiS0xyKXGFw 4OZ5u8ygcv5VVVyvRTpZ7ZCLUngpQca1LgX3vC5nUFOLIjB8AxqQkMOVil5owEbe 4NlS/DzCJtQ8YiPZ5oYh28YW+bhwZ68QUnVaTYOiQy3pyWfpYQt6mHW+1Q5B63L7 VmVSW6eDTv9bNm+RRbMAJYqlrYJaATVFv7SFOE40u93BCX1JiHxyxw/p6lzNux/1 rTUVHT1grQRaiGjSsW47/Gh1ROcHXYMhCq7dBGaSmyBJxRj9tQNtslU2pXjFcas3 KUecfOBT+snrXZtxnE2+5zrULh3ni0wZF8hbscZprVLEgQrEtYMUiGpUpv3Jq4E= =ugq4 -----END PGP SIGNATURE----- --1oqhWCvoDMlvKU6Qr4nROc79tPa6nDrsc--