From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE9BFC433B4 for ; Mon, 12 Apr 2021 16:55:57 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 13F676044F for ; Mon, 12 Apr 2021 16:55:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 13F676044F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:42026 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lVzqu-0000G0-2i for qemu-devel@archiver.kernel.org; Mon, 12 Apr 2021 12:55:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33808) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lVzp9-0007nY-Fo for qemu-devel@nongnu.org; Mon, 12 Apr 2021 12:54:07 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:59365) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lVzp6-00028Q-Fk for qemu-devel@nongnu.org; Mon, 12 Apr 2021 12:54:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618246442; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=W0JyjOzxiCYDdprwn1Q6He4ocrUkGwtG/ewke/s26xY=; b=f3y8c5PfHEtHBR7sRAiRobCYRkNr86qo46/gk4Pu1MvPS+FIIMDia0vjAcZMbxml/UYB55 yu/rqqMR3Ux0IPBNVEqdY1FLdoU3wH1Uys/V6FOQv94GdxWlskkDMj3lcCcHUAYm/0wfpu aTKg8Fh/5txFKa84cM+pnAuZqbjAJuQ= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-507-n-ZbcP1xNBG3XESmFkXPZA-1; Mon, 12 Apr 2021 12:54:00 -0400 X-MC-Unique: n-ZbcP1xNBG3XESmFkXPZA-1 Received: by mail-wr1-f70.google.com with SMTP id h30so6280217wrh.10 for ; Mon, 12 Apr 2021 09:54:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:references:from:organization:subject :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=W0JyjOzxiCYDdprwn1Q6He4ocrUkGwtG/ewke/s26xY=; b=r1hTcDKFsZzXNZBlUYJjsBLfZb0lphtE/mqmx96pwzNxC9VAk3UGyx5O1T/cEsxYUE pNp5Vi50R8BJgMEhCzsB/VnOO9zyG0T2XVg/d7YzrEicAAxfn7tumfZmDxQzzTBgwzWs t70F61qIHKD5Br7z2Pn+oURPprEuM5oXIQrdF+cyDf7ppOUo1E6XyqQ5yTrx4Y+ti1bN rCRk+jZWJzaIqeoapsFVaozqYBFbWr/WPExgbZdDZEUw/MrKwhTR3fcUbIaJVnPC2uMv fPTrnsfnWuZMg/xOHQZvnFVZHWQemWl91upMhdY+AzmmdHc0CotAeLCdGWmgC1qW7vHM frKg== X-Gm-Message-State: AOAM531tDAzUlu6mCWgMqKBpEOFu91vmlXOxEPfckarbmisLWyEP1OZk 0pZEo1r33QvzGZgz2lDrMn5kdXGSgFcPI4nFp1lYCGCNPY8fbwDyLqrRMVj5ioagXzTJ84/0Sw+ YPwiFZofEb60EkN4= X-Received: by 2002:a1c:19c1:: with SMTP id 184mr81670wmz.38.1618246439166; Mon, 12 Apr 2021 09:53:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy3Lh0QWfuFJyl9e7JRXlpkZEcZx1+8A6ZEzzSoRcxBllSllXEeEY4uAjtZzYYC+9jUZUv8mw== X-Received: by 2002:a1c:19c1:: with SMTP id 184mr81654wmz.38.1618246438950; Mon, 12 Apr 2021 09:53:58 -0700 (PDT) Received: from [192.168.3.132] (p5b0c66cb.dip0.t-ipconnect.de. [91.12.102.203]) by smtp.gmail.com with ESMTPSA id r5sm15885485wmr.15.2021.04.12.09.53.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Apr 2021 09:53:58 -0700 (PDT) To: Paolo Bonzini , qemu-devel@nongnu.org References: <20210312173547.1283477-1-pbonzini@redhat.com> <20210312173547.1283477-3-pbonzini@redhat.com> From: David Hildenbrand Organization: Red Hat Subject: Re: [PATCH v2 2/3] qom: move user_creatable_add_opts logic to vl.c and QAPIfy it Message-ID: Date: Mon, 12 Apr 2021 18:53:58 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210312173547.1283477-3-pbonzini@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=david@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, armbru@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 12.03.21 18:35, Paolo Bonzini wrote: > Emulators are currently using OptsVisitor (via user_creatable_add_opts) > to parse the -object command line option. This has one extra feature, > compared to keyval, which is automatic conversion of integers to lists > as well as support for lists as repeated options: > > -object memory-backend-ram,id=pc.ram,size=1048576000,host-nodes=0,policy=bind > > So we cannot replace OptsVisitor with keyval right now. Still, this > patch moves the user_creatable_add_opts logic to vl.c since it is > not needed anywhere else, and makes it go through user_creatable_add_qapi. > > In order to minimize code changes, the predicate still takes a string. > This can be changed later to use the ObjectType QAPI enum directly. > Rebasing my "noreserve"[1] series on this, I get weird errors from QEMU when specifying the new "reserve=off" option for a memory-backend-ram: "Invalid parameter 'reserve'" And it looks like this is the case for any new properties. Poking around, I fail to find what's causing this -- or how to unlock new properties. What is the magic toggle to make it work? Thanks! [1] https://lkml.kernel.org/r/20210319101230.21531-1-david@redhat.com -- Thanks, David / dhildenb