From: Paolo Bonzini <pbonzini@redhat.com>
To: Michael Tokarev <mjt@tls.msk.ru>,
Pierre Labatut <plabatut@google.com>,
qemu-trivial@nongnu.org
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
"open list:All patches CC here" <qemu-devel@nongnu.org>
Subject: Re: [PATCH] Fix compilation when UFFDIO_REGISTER is not set.
Date: Mon, 2 Oct 2023 18:56:35 +0200 [thread overview]
Message-ID: <f0fee08b-7d4d-90ab-7961-21324f5c0b5c@redhat.com> (raw)
In-Reply-To: <9e380190-4147-fc73-3205-112cb854f25a@tls.msk.ru>
On 10/2/23 13:56, Michael Tokarev wrote:
> 28.09.2023 15:56, Pierre Labatut wrote:
>> Signed-off-by: Pierre Labatut <plabatut@google.com>
>> ---
>> subprojects/libvhost-user/libvhost-user.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> I'm not sure how subprojects are handled here. Should we commit things
> to a subproject directly? This one does not seem to be wrapped at least,
> and has been in contrib/ before moving to subprojects/, so seems to be
> ok.
Yes, subprojects either are hosted directly in qemu.git (they're just a
nested build system), or they replace a submodule and have a .wrap file
(and then the patch won't apply). libvhost-user is of the former kind.
Paolo
prev parent reply other threads:[~2023-10-02 16:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-28 12:56 [PATCH] Fix compilation when UFFDIO_REGISTER is not set Pierre Labatut
2023-10-02 11:56 ` Michael Tokarev
2023-10-02 16:56 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0fee08b-7d4d-90ab-7961-21324f5c0b5c@redhat.com \
--to=pbonzini@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=mst@redhat.com \
--cc=plabatut@google.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).