From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CEB0CE784B0 for ; Mon, 2 Oct 2023 16:57:24 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qnME0-0007XN-W7; Mon, 02 Oct 2023 12:56:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qnMDp-0007Wt-Np for qemu-devel@nongnu.org; Mon, 02 Oct 2023 12:56:41 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qnMDo-00010J-Ap for qemu-devel@nongnu.org; Mon, 02 Oct 2023 12:56:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1696265799; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fztuQTvCsq83cHqsTUCZXBc7Mf6lNb3Kk9nSdTwWCJA=; b=JY+C5ounfDVZGWRKyIc2QujlwwPSujGXQM+llJfPgsHQ7tROU4DuJAf1cJNGxf/ZhwBczC Y5+h0w0jY8N0tS0QPENhxnYY55pTfjF4QClP9VlQdd30Vu0qrrpnGkIPdVuzuaaCYTRMP9 hYGlq+7wtK5A7ljvaETsuI372aKFtP0= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-122-iQOncKOmMfepAAq4zpu0MQ-1; Mon, 02 Oct 2023 12:56:37 -0400 X-MC-Unique: iQOncKOmMfepAAq4zpu0MQ-1 Received: by mail-ed1-f70.google.com with SMTP id 4fb4d7f45d1cf-533d8a785a5so11314194a12.3 for ; Mon, 02 Oct 2023 09:56:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696265797; x=1696870597; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fztuQTvCsq83cHqsTUCZXBc7Mf6lNb3Kk9nSdTwWCJA=; b=H3DsTHQ1j8X+gHnUeG18WmEvcPKY2M0ni1aT/l0Q4Hsm0DsvlaVWdHc1fSKzESGwbC uoy4kllCIB8RG31ZredCqKdMGpTqhzA52n0GHEWUrU0ruD8h/NTX+rq+cOyvJrrQcFcQ fkpXHqQX2tZqIIQuLcJWeqLqiDky4ZG34fZW/BkYzJPouzypys69w8/ym/vr1haV10lf kss2olJTbLraxpS3TDdh4D96Gw0pR7d2iWupAGZ5Y6G2Y+ebYI+ZLhJVGsPqyhWZHr+c UV/tdi34jJzS7nw7mcQh3nR9j1L3MY+dJfFl/QOBpZDaptQ7omF6tyn2YAuqXz8QtBk/ w6Ug== X-Gm-Message-State: AOJu0YyEfZRQ/VpwW9xWHczMPxdxrQ+WKZmNFZD8Mccp0rPe6xCrSO6X drOBgT6BAUarC73NcgW4s/845+DmVD6i71MLZuoKW1u7VsJEgCG73AC9kdg7HmBfX9BfzGc2sE/ b1jGoQ9iya0xg8Jw= X-Received: by 2002:a05:6402:b21:b0:52f:2bd3:6f4d with SMTP id bo1-20020a0564020b2100b0052f2bd36f4dmr10712117edb.0.1696265796848; Mon, 02 Oct 2023 09:56:36 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHqagLrCikU52L0VMu7n6OV1okp1JBA4Kg3kTiLz2kxJDH1BQpGpcWHf2+QqO17IWKsLJN0tg== X-Received: by 2002:a05:6402:b21:b0:52f:2bd3:6f4d with SMTP id bo1-20020a0564020b2100b0052f2bd36f4dmr10712107edb.0.1696265796553; Mon, 02 Oct 2023 09:56:36 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:48f9:bea:a04c:3dfe? ([2001:b07:6468:f312:48f9:bea:a04c:3dfe]) by smtp.googlemail.com with ESMTPSA id v10-20020aa7cd4a000000b0052ff9bae873sm15727035edw.5.2023.10.02.09.56.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Oct 2023 09:56:35 -0700 (PDT) Message-ID: Date: Mon, 2 Oct 2023 18:56:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] Fix compilation when UFFDIO_REGISTER is not set. Content-Language: en-US To: Michael Tokarev , Pierre Labatut , qemu-trivial@nongnu.org Cc: "Michael S. Tsirkin" , "open list:All patches CC here" References: <20230928125700.1504442-1-plabatut@google.com> <9e380190-4147-fc73-3205-112cb854f25a@tls.msk.ru> From: Paolo Bonzini In-Reply-To: <9e380190-4147-fc73-3205-112cb854f25a@tls.msk.ru> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-2.321, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 10/2/23 13:56, Michael Tokarev wrote: > 28.09.2023 15:56, Pierre Labatut wrote: >> Signed-off-by: Pierre Labatut >> --- >>   subprojects/libvhost-user/libvhost-user.c | 2 +- >>   1 file changed, 1 insertion(+), 1 deletion(-) > > I'm not sure how subprojects are handled here.  Should we commit things > to a subproject directly? This one does not seem to be wrapped at least, > and has been in contrib/ before moving to subprojects/, so seems to be > ok. Yes, subprojects either are hosted directly in qemu.git (they're just a nested build system), or they replace a submodule and have a .wrap file (and then the patch won't apply). libvhost-user is of the former kind. Paolo