qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
	fam@euphon.net, thuth@redhat.com, lvivier@redhat.com,
	qemu-devel@nongnu.org
Subject: Re: [PATCH for-6.2 0/2] esp: add fix for reset before transfer
Date: Fri, 19 Nov 2021 10:14:53 +0100	[thread overview]
Message-ID: <f1093393-bf6d-480c-8b3b-70e9d4a7532b@redhat.com> (raw)
In-Reply-To: <20211118100327.29061-1-mark.cave-ayland@ilande.co.uk>

On 11/18/21 11:03, Mark Cave-Ayland wrote:
> This is the fix for Gitlab issue #724 discovered by fuzzing which I think is
> worth including in 6.2 for 2 reasons: firstly the fix is to zero out
> an extra field during chip reset which normally only occurs during driver
> initialisation and durring IO timeouts, and secondly the bug causes a stale
> SCSI data buffer pointer dereference rather than triggering a FIFO assert.
> 
> The first patch contains the very simple fix, whilst the second patch adds a
> qtest based upon the original Gitlab issue.
> 
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> 
> 
> Mark Cave-Ayland (2):
>    esp: ensure that async_len is reset to 0 during esp_hard_reset()
>    qtest/am53c974-test: add test for reset before transfer
> 
>   hw/scsi/esp.c               |  1 +
>   tests/qtest/am53c974-test.c | 30 ++++++++++++++++++++++++++++++
>   2 files changed, 31 insertions(+)
> 

Queued, thanks.

Paolo



      parent reply	other threads:[~2021-11-19  9:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-18 10:03 [PATCH for-6.2 0/2] esp: add fix for reset before transfer Mark Cave-Ayland
2021-11-18 10:03 ` [PATCH for-6.2 1/2] esp: ensure that async_len is reset to 0 during esp_hard_reset() Mark Cave-Ayland
2021-11-18 11:30   ` Philippe Mathieu-Daudé
2021-11-18 10:03 ` [PATCH for-6.2 2/2] qtest/am53c974-test: add test for reset before transfer Mark Cave-Ayland
2021-11-18 10:19   ` Thomas Huth
2021-11-19  9:14 ` Paolo Bonzini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f1093393-bf6d-480c-8b3b-70e9d4a7532b@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=fam@euphon.net \
    --cc=lvivier@redhat.com \
    --cc=mark.cave-ayland@ilande.co.uk \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).