From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CF4EC43465 for ; Mon, 21 Sep 2020 14:50:04 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BC5F720735 for ; Mon, 21 Sep 2020 14:50:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="WqXzJctc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BC5F720735 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:40442 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kKN8k-0001wk-QX for qemu-devel@archiver.kernel.org; Mon, 21 Sep 2020 10:50:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53756) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kKN5g-00084E-BH for qemu-devel@nongnu.org; Mon, 21 Sep 2020 10:46:53 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:48376) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kKN5e-0006UN-9l for qemu-devel@nongnu.org; Mon, 21 Sep 2020 10:46:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600699608; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/5Hqn6jySfjP7Wr40wPCovOfu0GOxO7kQ9MhyB1X8Cc=; b=WqXzJctcX3eyTSuvgXrQpnMF80M+l+BvC9S55unwC3AE0AFItB51f4aO65fIkq121+Jmvw r7jlyU6gG3a95RS19dqUaZzAIwoYNRr+5c+l+D7LaqrtaOU84aqRztDXia8sls4iSI7MJL xb5RwDimeWloYhZmebm730e4qnU1gYk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-591-glTVh78ZMpO9whWlI4j2gQ-1; Mon, 21 Sep 2020 10:46:44 -0400 X-MC-Unique: glTVh78ZMpO9whWlI4j2gQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 370051021202; Mon, 21 Sep 2020 14:46:43 +0000 (UTC) Received: from [10.10.119.140] (ovpn-119-140.rdu2.redhat.com [10.10.119.140]) by smtp.corp.redhat.com (Postfix) with ESMTP id EF0AA5D9CD; Mon, 21 Sep 2020 14:46:41 +0000 (UTC) Subject: Re: [PATCH 16/37] qapi: establish mypy type-checking baseline To: Markus Armbruster References: <20200915224027.2529813-1-jsnow@redhat.com> <20200915224027.2529813-17-jsnow@redhat.com> <874knvguzb.fsf@dusky.pond.sub.org> <87imc7a71d.fsf@dusky.pond.sub.org> From: John Snow Message-ID: Date: Mon, 21 Sep 2020 10:46:41 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <87imc7a71d.fsf@dusky.pond.sub.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jsnow@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Received-SPF: pass client-ip=216.205.24.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/21 01:43:11 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.455, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , =?UTF-8?Q?Alex_Benn=c3=a9e?= , qemu-devel@nongnu.org, Eduardo Habkost , Cleber Rosa Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 9/21/20 4:05 AM, Markus Armbruster wrote: > John Snow writes: > >> On 9/18/20 7:55 AM, Markus Armbruster wrote: >>> Ignorant question: why does this come after PATCH 13 "qapi/common.py: >>> add notational type hints", but before all the other patches adding type >>> hints? >>> John Snow writes: >>> >>>> Fix two very minor issues, and then establish a mypy type-checking >>>> baseline. >>>> >>>> Like pylint, this should be run from the folder above: >>>> >>>> > mypy --config-file=qapi/mypy.ini qapi/ >>> I get: >>> $ mypy --config-file qapi/mypy.ini qapi >>> qapi/mypy.ini: [mypy]: Strict mode is not supported in configuration files: specify individual flags instead (see 'mypy -h' for the list of flags enabled in strict mode) >>> qapi/types.py:29: error: Need type annotation for 'objects_seen' (hint: "objects_seen: Set[] = ...") >>> Found 1 error in 1 file (checked 18 source files) >>> Is this expected? >>> In case it matters: >>> $ mypy --version >>> mypy 0.761 >>> >> >> (Warning; FiSH and stgit ahead) >> >> cd ~/src/qemu/scripts >> pipenv --python 3.6 >> pipenv shell >> pip install pylint flake8 >> >> ### Testing mypy 0.770 >> >> pip install mypy==0.770 >> stg goto qapi-establish-mypy-type >> >> while true; and flake8 qapi/; and pylint --rcfile=qapi/pylintrc qapi/; >> and mypy --config-file=qapi/mypy.ini qapi/; and stg push; end >> >> pip uninstall mypy >> >> ### >> >> >> >> 0.782 - OK >> 0.770 - OK >> 0.760 - FAIL, Fixable* >> 0.750 - OK* >> 0.740 - OK* >> 0.730 - OK* >> 0.720 - OK* >> 0.710 - OK** (Does not recognize 'no_implicit_reexport' option) >> 0.700 - OK*** (Not compatible with bleeding edge pylint/flake8) >> 0.670 - OK*** >> 0.660 - OK*** >> 0.650 - OK*** >> 0.641 - OK*** >> 0.630 - Fails again. >> >> >> >> 0.760 doesn't support strict in the config file (It needs component >> options), and it wants a few extra annotations where its inference >> power is weaker. Well, easy enough to fix up. >> >> 0.630 fails again and insists that __init__ should have a return type >> annotation of None. Modern mypy is smart enough to know that's what >> that type is supposed to be. Arbitrarily, this is my cutoff for what >> seems reasonable to even want to support. >> >> I still find the lack of "strict=true" in the config file irritating >> and might ask to target 0.770 or newer. There should be no reason we >> can't install that in a venv for CI to chew on. >> >> Humbly ask I take the lazy way out and document that we support mypy >>> = 0.770. > > Our "supported build platforms" policy puts hard limits on the minimum > versions for tools the build requires. > > Mypy is not such a tool. I hope we get to the point where we can have > "make check" run it, but skipping the test when we don't have a > sufficiently modern mypy feels okay to me, as long as our gating CI > still guards the master branch. > Yes, that's been my view. These tools *are* new and they *do* change often. Chasing a wide compatibility window with them is prohibitively difficult. Luckily, they're not needed for running the packages at all. If I do add linting to 'make check', it is going to be through a virtual environment that deploys *specific versions* of these tools, and it will happen transparently. The VM tests already do this. --js