From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C313C433E2 for ; Mon, 14 Sep 2020 11:22:37 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A346C21D7E for ; Mon, 14 Sep 2020 11:22:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="f1YbT1ci" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A346C21D7E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:60788 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kHmZ9-00081G-PM for qemu-devel@archiver.kernel.org; Mon, 14 Sep 2020 07:22:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48202) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kHmYV-00075b-Rj for qemu-devel@nongnu.org; Mon, 14 Sep 2020 07:21:55 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:28860 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kHmYU-0007zE-0I for qemu-devel@nongnu.org; Mon, 14 Sep 2020 07:21:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600082513; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BKppdPpLR0fXvrtbCFWadjn7t/GYkYq6MsZUdlmgg3k=; b=f1YbT1ci0S3qLXa9emcWsBpFIFSdJ19+B5mh0LBcPhjmq0uWM4BKvDoF1bKstoEplFcjli wz0+osN2n6aTJ2xyF6wpILkltKx9ebtKxyqgkPulWjMV8MjwnxSNN21tl3fRsaFeoAG2fD qUWCRhWoPr2EOlEFzC3YXpWCIQ27UrE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-495-q02vYyfUNwWiAHjniq7rwA-1; Mon, 14 Sep 2020 07:21:51 -0400 X-MC-Unique: q02vYyfUNwWiAHjniq7rwA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 67AE61084D62; Mon, 14 Sep 2020 11:21:50 +0000 (UTC) Received: from thuth.remote.csb (ovpn-112-134.ams2.redhat.com [10.36.112.134]) by smtp.corp.redhat.com (Postfix) with ESMTP id 659A819C4F; Mon, 14 Sep 2020 11:21:49 +0000 (UTC) Subject: Re: [PATCH] tests/check-block: Do not run the iotests with old versions of bash To: Max Reitz , qemu-devel@nongnu.org References: <20200912121412.10999-1-thuth@redhat.com> <8e1a8f08-5fd1-b53e-07a4-70170e4451e0@redhat.com> <532c3912-b18b-86bf-52a2-044aaacbbc81@redhat.com> <803bda1b-fc4a-3221-b130-f86c45f30826@redhat.com> From: Thomas Huth Message-ID: Date: Mon, 14 Sep 2020 13:21:48 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <803bda1b-fc4a-3221-b130-f86c45f30826@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US Received-SPF: pass client-ip=207.211.31.81; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/14 00:11:19 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -38 X-Spam_score: -3.9 X-Spam_bar: --- X-Spam_report: (-3.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.792, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?Q?Daniel_P_=2e_Berrang=c3=a9?= , qemu-block@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 14/09/2020 13.13, Max Reitz wrote: > On 14.09.20 12:50, Thomas Huth wrote: >> On 14/09/2020 11.19, Max Reitz wrote: >>> On 12.09.20 14:14, Thomas Huth wrote: >>>> macOS is shipped with a very old version of the bash (3.2), which >>>> is currently not suitable for running the iotests anymore. Add >>>> a check to skip the iotests in this case - if someone still wants >>>> to run the iotests on macOS, they can install a newer version from >>>> homebrew, for example. >>>> >>>> Signed-off-by: Thomas Huth >>>> --- >>>> tests/check-block.sh | 5 +++++ >>>> 1 file changed, 5 insertions(+) >>>> >>>> diff --git a/tests/check-block.sh b/tests/check-block.sh >>>> index 8e29c868e5..bfe1630c1e 100755 >>>> --- a/tests/check-block.sh >>>> +++ b/tests/check-block.sh >>>> @@ -46,6 +46,11 @@ if ! command -v bash >/dev/null 2>&1 ; then >>>> exit 0 >>>> fi >>>> >>>> +if bash --version | grep 'GNU bash, version [123]' > /dev/null 2>&1 ; then >>> >>> grep -q instead of the redirections, perhaps? >>> >>> But more importantly, I think this needs a LANG=C prefix. (If I expand >>> the rejected major versions to [12345], it doesn’t skip without a >>> prefix, because the string reads “GNU bash, Version 5...” here in >>> LANG=de_DE.UTF-8.) >> >> Ouch, ok. But actually, I'm not quite sure anymore whether the patch is >> really required. I ran into the "readlink -f" problem and thought that >> it occurred due to the ancient version of bash on macOS, but as a I now >> know, readlink is a separate program and not a bash built-in, so it's a >> different issue... thus let's skip this patch here for now until we hit >> a real issue with bash again. > > Yes, I had hoped this patch would fix that issue. Or perhaps at least > hide it, because if you have a newer bash, chances are your readlink has > -f, too. > > So should we just effectively revert b1cbc33a397 if readlink -f didn’t > work, i.e. check "$?" and on failure use $PWD as it was before b1cbc33a397? Sounds like the best option that I currently can see, indeed. Want me to send a patch, or will you provide one? Thomas