qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: "Cédric Le Goater" <clg@redhat.com>,
	qemu-devel@nongnu.org, qemu-arm@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
	"Steven Lee" <steven_lee@aspeedtech.com>,
	"Troy Lee" <leetroy@gmail.com>,
	"Jamin Lin" <jamin_lin@aspeedtech.com>,
	"Andrew Jeffery" <andrew@codeconstruct.com.au>,
	"Joel Stanley" <joel@jms.id.au>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	berrange@redhat.com
Subject: Re: [PATCH v3] tests/functional: Convert most Aspeed machine tests
Date: Mon, 21 Oct 2024 10:53:47 +0200	[thread overview]
Message-ID: <f1249e0b-290e-4416-a776-3f5d6ada1ece@redhat.com> (raw)
In-Reply-To: <20241018071726.2723934-1-clg@redhat.com>

On 18/10/2024 09.17, Cédric Le Goater wrote:
> This is a simple conversion of the tests with some cleanups and
> adjustments to match the new test framework. Replace the zephyr image
> MD5 hashes with SHA256 hashes while at it.
> 
> The SDK tests depend on a ssh class from avocado.utils which is
> difficult to replace. To be addressed separately.
> 
> Signed-off-by: Cédric Le Goater <clg@redhat.com>
> ---

  Hi Cédric,

I'm seeing errors when I try to run "make check-functional" with this patch 
multiple times, e.g.:

   File "/home/thuth/devel/qemu/tests/functional/test_arm_aspeed.py", line 
111, in test_arm_ast2400_palmetto_openbmc_v2_9_0
     image_path = self.ASSET_PALMETTO_FLASH.fetch()
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   File "/home/thuth/devel/qemu/tests/functional/qemu_test/asset.py", line 
104, in fetch
     raise Exception("Asset cache is invalid and downloads disabled")
Exception: Asset cache is invalid and downloads disabled

Could it be that the tests alter the file in the download cache?

  Thomas



  reply	other threads:[~2024-10-21  8:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-18  7:17 [PATCH v3] tests/functional: Convert most Aspeed machine tests Cédric Le Goater
2024-10-21  8:53 ` Thomas Huth [this message]
2024-10-21  9:31   ` Cédric Le Goater
2024-10-21  9:36     ` Thomas Huth
2024-10-21  9:47     ` Daniel P. Berrangé
2024-10-21 10:04       ` Cédric Le Goater

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f1249e0b-290e-4416-a776-3f5d6ada1ece@redhat.com \
    --to=thuth@redhat.com \
    --cc=andrew@codeconstruct.com.au \
    --cc=berrange@redhat.com \
    --cc=clg@redhat.com \
    --cc=jamin_lin@aspeedtech.com \
    --cc=joel@jms.id.au \
    --cc=leetroy@gmail.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=steven_lee@aspeedtech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).