From: Richard Henderson <richard.henderson@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, qemu-devel@nongnu.org
Cc: Marc Zyngier <maz@kernel.org>
Subject: Re: [PATCH 12/41] hw/intc/arm_gicv3_its: Factor out CTE lookup sequence
Date: Fri, 8 Apr 2022 17:47:17 -0700 [thread overview]
Message-ID: <f1500122-80dc-e85a-d2e2-a3b397215bd7@linaro.org> (raw)
In-Reply-To: <20220408141550.1271295-13-peter.maydell@linaro.org>
On 4/8/22 07:15, Peter Maydell wrote:
> Factor out the sequence of looking up a CTE from an ICID including
> the validity and error checks.
>
> Signed-off-by: Peter Maydell<peter.maydell@linaro.org>
> ---
> I think process_movi() in particular is now a lot cleaner
> to read with all the error-checking factored out.
> ---
> hw/intc/arm_gicv3_its.c | 109 ++++++++++++++--------------------------
> 1 file changed, 39 insertions(+), 70 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2022-04-09 0:49 UTC|newest]
Thread overview: 88+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-08 14:15 [PATCH 00/41] arm: Implement GICv4 Peter Maydell
2022-04-08 14:15 ` [PATCH 01/41] hw/intc/arm_gicv3_its: Add missing blank line Peter Maydell
2022-04-08 23:16 ` Richard Henderson
2022-04-08 14:15 ` [PATCH 02/41] hw/intc/arm_gicv3: Sanity-check num-cpu property Peter Maydell
2022-04-08 23:17 ` Richard Henderson
2022-04-08 14:15 ` [PATCH 03/41] hw/intc/arm_gicv3: Insist that redist region capacity matches CPU count Peter Maydell
2022-04-08 23:20 ` Richard Henderson
2022-04-08 14:15 ` [PATCH 04/41] hw/intc/arm_gicv3: Report correct PIDR0 values for ID registers Peter Maydell
2022-04-08 23:26 ` Richard Henderson
2022-04-08 14:15 ` [PATCH 05/41] target/arm/cpu.c: ignore VIRQ and VFIQ if no EL2 Peter Maydell
2022-04-08 23:39 ` Richard Henderson
2022-04-08 14:15 ` [PATCH 06/41] hw/intc/arm_gicv3_its: Factor out "is intid a valid LPI ID?" Peter Maydell
2022-04-08 23:45 ` Richard Henderson
2022-04-08 14:15 ` [PATCH 07/41] hw/intc/arm_gicv3_its: Implement GITS_BASER2 for GICv4 Peter Maydell
2022-04-08 23:55 ` Richard Henderson
2022-04-08 14:15 ` [PATCH 08/41] hw/intc/arm_gicv3_its: Implement VMAPI and VMAPTI Peter Maydell
2022-04-09 0:17 ` Richard Henderson
2022-04-08 14:15 ` [PATCH 09/41] hw/intc/arm_gicv3_its: Implement VMAPP Peter Maydell
2022-04-09 0:21 ` Richard Henderson
2022-04-08 14:15 ` [PATCH 10/41] hw/intc/arm_gicv3_its: Distinguish success and error cases of CMD_CONTINUE Peter Maydell
2022-04-09 0:23 ` Richard Henderson
2022-04-08 14:15 ` [PATCH 11/41] hw/intc/arm_gicv3_its: Factor out "find ITE given devid, eventid" Peter Maydell
2022-04-09 0:39 ` Richard Henderson
2022-04-08 14:15 ` [PATCH 12/41] hw/intc/arm_gicv3_its: Factor out CTE lookup sequence Peter Maydell
2022-04-09 0:47 ` Richard Henderson [this message]
2022-04-08 14:15 ` [PATCH 13/41] hw/intc/arm_gicv3_its: Split out process_its_cmd() physical interrupt code Peter Maydell
2022-04-09 17:55 ` Richard Henderson
2022-04-08 14:15 ` [PATCH 14/41] hw/intc/arm_gicv3_its: Handle virtual interrupts in process_its_cmd() Peter Maydell
2022-04-09 18:02 ` Richard Henderson
2022-04-08 14:15 ` [PATCH 15/41] hw/intc/arm_gicv3: Keep pointers to every connected ITS Peter Maydell
2022-04-09 18:06 ` Richard Henderson
2022-04-08 14:15 ` [PATCH 16/41] hw/intc/arm_gicv3_its: Implement VMOVP Peter Maydell
2022-04-09 18:13 ` Richard Henderson
2022-04-08 14:15 ` [PATCH 17/41] hw/intc/arm_gicv3_its: Implement VSYNC Peter Maydell
2022-04-09 18:17 ` Richard Henderson
2022-04-09 18:25 ` Richard Henderson
2022-04-08 14:15 ` [PATCH 18/41] hw/intc/arm_gicv3_its: Implement INV command properly Peter Maydell
2022-04-09 18:22 ` Richard Henderson
2022-04-08 14:15 ` [PATCH 19/41] hw/intc/arm_gicv3_its: Implement INV for virtual interrupts Peter Maydell
2022-04-09 18:23 ` Richard Henderson
2022-04-08 14:15 ` [PATCH 20/41] hw/intc/arm_gicv3_its: Implement VMOVI Peter Maydell
2022-04-09 18:27 ` Richard Henderson
2022-04-08 14:15 ` [PATCH 21/41] hw/intc/arm_gicv3_its: Implement VINVALL Peter Maydell
2022-04-09 18:28 ` Richard Henderson
2022-04-08 14:15 ` [PATCH 22/41] hw/intc/arm_gicv3: Implement GICv4's new redistributor frame Peter Maydell
2022-04-09 18:32 ` Richard Henderson
2022-04-22 8:39 ` Peter Maydell
2022-04-08 14:15 ` [PATCH 23/41] hw/intc/arm_gicv3: Implement new GICv4 redistributor registers Peter Maydell
2022-04-09 18:40 ` Richard Henderson
2022-04-08 14:15 ` [PATCH 24/41] hw/intc/arm_gicv3_cpuif: Split "update vIRQ/vFIQ" from gicv3_cpuif_virt_update() Peter Maydell
2022-04-09 18:45 ` Richard Henderson
2022-04-08 14:15 ` [PATCH 25/41] hw/intc/arm_gicv3_cpuif: Support vLPIs Peter Maydell
2022-04-09 19:20 ` Richard Henderson
2022-04-10 8:49 ` Peter Maydell
2022-04-08 14:15 ` [PATCH 26/41] hw/intc/arm_gicv3_cpuif: Don't recalculate maintenance irq unnecessarily Peter Maydell
2022-04-09 19:23 ` Richard Henderson
2022-04-08 14:15 ` [PATCH 27/41] hw/intc/arm_gicv3_redist: Factor out "update hpplpi for one LPI" logic Peter Maydell
2022-04-09 19:28 ` Richard Henderson
2022-04-08 14:15 ` [PATCH 28/41] hw/intc/arm_gicv3_redist: Factor out "update hpplpi for all LPIs" logic Peter Maydell
2022-04-09 19:54 ` Richard Henderson
2022-04-08 14:15 ` [PATCH 29/41] hw/intc/arm_gicv3_redist: Recalculate hppvlpi on VPENDBASER writes Peter Maydell
2022-04-09 20:10 ` Richard Henderson
2022-04-10 8:56 ` Peter Maydell
2022-04-08 14:15 ` [PATCH 30/41] hw/intc/arm_gicv3_redist: Factor out "update bit in pending table" code Peter Maydell
2022-04-09 20:21 ` Richard Henderson
2022-04-08 14:15 ` [PATCH 31/41] hw/intc/arm_gicv3_redist: Implement gicv3_redist_process_vlpi() Peter Maydell
2022-04-09 20:28 ` Richard Henderson
2022-04-08 14:15 ` [PATCH 32/41] hw/intc/arm_gicv3_redist: Implement gicv3_redist_vlpi_pending() Peter Maydell
2022-04-09 20:32 ` Richard Henderson
2022-04-08 14:15 ` [PATCH 33/41] hw/intc/arm_gicv3_redist: Use set_pending_table_bit() in mov handling Peter Maydell
2022-04-09 20:34 ` Richard Henderson
2022-04-08 14:15 ` [PATCH 34/41] hw/intc/arm_gicv3_redist: Implement gicv3_redist_mov_vlpi() Peter Maydell
2022-04-09 20:39 ` Richard Henderson
2022-04-08 14:15 ` [PATCH 35/41] hw/intc/arm_gicv3_redist: Implement gicv3_redist_vinvall() Peter Maydell
2022-04-09 20:40 ` Richard Henderson
2022-04-08 14:15 ` [PATCH 36/41] hw/intc/arm_gicv3_redist: Implement gicv3_redist_inv_vlpi() Peter Maydell
2022-04-09 20:40 ` Richard Henderson
2022-04-08 14:15 ` [PATCH 37/41] hw/intc/arm_gicv3: Update ID and feature registers for GICv4 Peter Maydell
2022-04-09 20:47 ` Richard Henderson
2022-04-08 14:15 ` [PATCH 38/41] hw/intc/arm_gicv3: Allow 'revision' property to be set to 4 Peter Maydell
2022-04-09 20:50 ` Richard Henderson
2022-04-08 14:15 ` [PATCH 39/41] hw/arm/virt: Use VIRT_GIC_VERSION_* enum values in create_gic() Peter Maydell
2022-04-09 20:52 ` Richard Henderson
2022-04-08 14:15 ` [PATCH 40/41] hw/arm/virt: Abstract out calculation of redistributor region capacity Peter Maydell
2022-04-09 20:53 ` Richard Henderson
2022-04-08 14:15 ` [PATCH 41/41] hw/arm/virt: Support TCG GICv4 Peter Maydell
2022-04-09 20:55 ` Richard Henderson
2022-04-08 14:29 ` [PATCH 00/41] arm: Implement GICv4 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1500122-80dc-e85a-d2e2-a3b397215bd7@linaro.org \
--to=richard.henderson@linaro.org \
--cc=maz@kernel.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).