From: Paolo Bonzini <pbonzini@redhat.com>
To: "Stefan Weil" <sw@weilnetz.de>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Richard Henderson" <richard.henderson@linaro.org>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] oslib-posix: Fix compiler warning and some data types
Date: Mon, 16 Oct 2017 14:22:48 +0200 [thread overview]
Message-ID: <f1681f83-c337-1b40-a98d-d4d740f6f576@redhat.com> (raw)
In-Reply-To: <2be5f194-ccc4-d3cc-6001-feae580e77e1@weilnetz.de>
On 15/10/2017 19:53, Stefan Weil wrote:
>> I see your arguments. Maybe that part can be removed from my patch
>> when it is applied, or should I send a v3 (cc'ing qemu-trivial)?
Sending v3 to trivial makes sense.
> While thinking more about that line of code, I wonder whether
> it would make sense to replace the byte r/w by a 32 bit r/w.
> Would that be faster on architectures with a 32 bit memory bus?
In practice this goes to the cache, so it's not affected by the size of
the write.
Paolo
prev parent reply other threads:[~2017-10-16 12:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-13 5:48 [Qemu-devel] [PATCH v2] oslib-posix: Fix compiler warning and some data types Stefan Weil
2017-10-13 6:25 ` no-reply
2017-10-14 16:53 ` Philippe Mathieu-Daudé
2017-10-15 15:32 ` Paolo Bonzini
2017-10-15 17:46 ` Stefan Weil
2017-10-15 17:53 ` Stefan Weil
2017-10-16 12:22 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1681f83-c337-1b40-a98d-d4d740f6f576@redhat.com \
--to=pbonzini@redhat.com \
--cc=f4bug@amsat.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=stefanha@redhat.com \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).