qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	qemu-devel@nongnu.org, Michael Tsirkin <mst@redhat.com>,
	Fan Ni <fan.ni@samsung.com>,
	linux-cxl@vger.kernel.org
Cc: linuxarm@huawei.com
Subject: Re: [PATCH v2 2/3] hw/cxl: Add utility functions decoder interleave ways and target count.
Date: Thu, 7 Sep 2023 14:35:41 +0200	[thread overview]
Message-ID: <f1694c9b-75ed-a8a3-6a05-91f796dfcf2b@linaro.org> (raw)
In-Reply-To: <20230907113543.19760-3-Jonathan.Cameron@huawei.com>

On 7/9/23 13:35, Jonathan Cameron wrote:
> As an encoded version of these key configuration parameters is available
> in a register, provide functions to extract it again so as to avoid
> the need for duplicating the storage.
> 
> Whilst here update the _enc() function to include additional values
> as defined in the CXL 3.0 specification. Whilst they are not
> currently used in the emulation, they may be in future and it is
> easier to compare with the specification if all values are covered.
> 
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
> v2: Thanks to Philippe Mathieu-Daudé
>   - Expand both enc() and dec() functions to include full set of values
>     defined in CXL r3.0
>   - Pushed implementation down into the .c file.
> ---
>   include/hw/cxl/cxl_component.h |  2 ++
>   hw/cxl/cxl-component-utils.c   | 59 ++++++++++++++++++++++++++++++----
>   2 files changed, 55 insertions(+), 6 deletions(-)

Hoping the values match the "CXL r3.0 Section 8.2.4.19.1 CXL
HDM Decoder Capability Register":

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>



  reply	other threads:[~2023-09-07 12:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-07 11:35 [PATCH v2 0/3] hw/cxl: Support emulating 4 HDM decoders throughout topology Jonathan Cameron via
2023-09-07 11:35 ` [PATCH v2 1/3] hw/cxl: Push cxl_decoder_count_enc() and cxl_decode_ig() into .c Jonathan Cameron via
2023-09-07 12:33   ` Philippe Mathieu-Daudé
2023-09-07 11:35 ` [PATCH v2 2/3] hw/cxl: Add utility functions decoder interleave ways and target count Jonathan Cameron via
2023-09-07 12:35   ` Philippe Mathieu-Daudé [this message]
2023-09-07 11:35 ` [PATCH v2 3/3] hw/cxl: Support 4 HDM decoders at all levels of topology Jonathan Cameron via
2023-09-07 12:41   ` Philippe Mathieu-Daudé
2023-09-11 11:40     ` Jonathan Cameron via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f1694c9b-75ed-a8a3-6a05-91f796dfcf2b@linaro.org \
    --to=philmd@linaro.org \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=fan.ni@samsung.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).