From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58687) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eQNWx-0003Fs-NO for qemu-devel@nongnu.org; Sat, 16 Dec 2017 20:14:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eQNWu-0006JH-IJ for qemu-devel@nongnu.org; Sat, 16 Dec 2017 20:14:15 -0500 Received: from mail-qk0-x244.google.com ([2607:f8b0:400d:c09::244]:39017) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eQNWu-0006J8-DY for qemu-devel@nongnu.org; Sat, 16 Dec 2017 20:14:12 -0500 Received: by mail-qk0-x244.google.com with SMTP id u184so14609532qkd.6 for ; Sat, 16 Dec 2017 17:14:12 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= References: <20171216213004.30393-1-hpoussin@reactos.org> <20171216213004.30393-15-hpoussin@reactos.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: Date: Sat, 16 Dec 2017 22:14:07 -0300 MIME-Version: 1.0 In-Reply-To: <20171216213004.30393-15-hpoussin@reactos.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v2 14/15] piix4: rename PIIX4 object to piix4-isa List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Herv=c3=a9_Poussineau?= , Aurelien Jarno , Yongbok Kim , "Michael S . Tsirkin" , Paolo Bonzini , qemu-devel@nongnu.org Hi Hervé, On 12/16/2017 06:30 PM, Hervé Poussineau wrote: > Other piix4 parts are already named piix4-ide and piix4-usb-uhci. > > Signed-off-by: Hervé Poussineau > --- > hw/isa/piix4.c | 2 +- > hw/mips/mips_malta.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/isa/piix4.c b/hw/isa/piix4.c > index dc7146ee14..8bf260594f 100644 > --- a/hw/isa/piix4.c > +++ b/hw/isa/piix4.c > @@ -52,7 +52,7 @@ typedef struct PIIX4State { > uint8_t rcr; > } PIIX4State; > > -#define TYPE_PIIX4_PCI_DEVICE "PIIX4" > +#define TYPE_PIIX4_PCI_DEVICE "piix4-isa" > #define PIIX4_PCI_DEVICE(obj) \ > OBJECT_CHECK(PIIX4State, (obj), TYPE_PIIX4_PCI_DEVICE) > > diff --git a/hw/mips/mips_malta.c b/hw/mips/mips_malta.c > index 3d304a6e0a..28d91c9668 100644 > --- a/hw/mips/mips_malta.c > +++ b/hw/mips/mips_malta.c > @@ -1178,7 +1178,7 @@ void mips_malta_init(MachineState *machine) > ide_drive_get(hd, ARRAY_SIZE(hd)); > > pci = pci_create_multifunction(pci_bus, PCI_DEVFN(10, 0), > - true, "PIIX4"); > + true, "piix4-isa"); Can you use TYPE_PIIX4_PCI_DEVICE instead? Then: Reviewed-by: Philippe Mathieu-Daudé > dev = DEVICE(pci); > > /* Floppy */ >