From: Eric Blake <eblake@redhat.com>
To: Sergio Lopez <slp@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, Max Reitz <mreitz@redhat.com>
Subject: Re: [PATCH v3 1/2] block: Avoid processing BDS twice in bdrv_set_aio_context_ignore()
Date: Thu, 21 Jan 2021 11:31:34 -0600 [thread overview]
Message-ID: <f18017fc-c843-f1a3-d04f-9bb0912745b6@redhat.com> (raw)
In-Reply-To: <20210121170700.59734-2-slp@redhat.com>
On 1/21/21 11:06 AM, Sergio Lopez wrote:
> Some graphs may contain an indirect reference to the first BDS in the
> chain that can be reached while walking it bottom->up from one its
one of its
> children.
>
> Doubling-processing of a BDS is especially problematic for the
Double-processing
> aio_notifiers, as they might attempt to work on both the old and the
> new AIO contexts.
>
> To avoid this problem, add every child and parent to the ignore list
> before actually processing them.
>
> Suggested-by: Kevin Wolf <kwolf@redhat.com>
> Signed-off-by: Sergio Lopez <slp@redhat.com>
> ---
> block.c | 34 +++++++++++++++++++++++++++-------
> 1 file changed, 27 insertions(+), 7 deletions(-)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2021-01-21 17:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-21 17:06 [PATCH v3 0/2] nbd/server: Quiesce coroutines on context switch Sergio Lopez
2021-01-21 17:06 ` [PATCH v3 1/2] block: Avoid processing BDS twice in bdrv_set_aio_context_ignore() Sergio Lopez
2021-01-21 17:31 ` Eric Blake [this message]
2021-02-01 12:06 ` Kevin Wolf
2021-02-01 12:34 ` Sergio Lopez
2021-01-21 17:07 ` [PATCH v3 2/2] block: move blk_exp_close_all() to qemu_cleanup() Sergio Lopez
2021-01-21 18:02 ` Eric Blake
2021-02-01 12:20 ` Kevin Wolf
2021-02-01 12:35 ` Sergio Lopez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f18017fc-c843-f1a3-d04f-9bb0912745b6@redhat.com \
--to=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=slp@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).