From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3873BD75E35 for ; Fri, 22 Nov 2024 12:37:45 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tESud-0007tF-5C; Fri, 22 Nov 2024 07:37:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tESuW-0007s0-Nc for qemu-devel@nongnu.org; Fri, 22 Nov 2024 07:37:22 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tESuU-0005K4-3a for qemu-devel@nongnu.org; Fri, 22 Nov 2024 07:37:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732279037; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=CyQKgN06PGUD+AXir6DHOe7QB+SHUhoCcRgC8Zwcdyc=; b=a8grYJpmhfhK8sob+hYxo5bPBk+H/DMPa7D9PehrV/VO2V9PfzK1VxZJDCkwOpCuQwr8NI cOCb9ZrdAnSrNTxHKpX8rvUOGfhds0Ahi5Rm32ROtDeeOvSfgBAOdpi3g7/hBhKpvBrFOi oWPKhEWnTutFVA4tkJKGKfUOlfgB120= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-623-SByLQHJmNjKk7KFf3nGDXA-1; Fri, 22 Nov 2024 07:37:14 -0500 X-MC-Unique: SByLQHJmNjKk7KFf3nGDXA-1 X-Mimecast-MFC-AGG-ID: SByLQHJmNjKk7KFf3nGDXA Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4315f48bd70so14461535e9.2 for ; Fri, 22 Nov 2024 04:37:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732279033; x=1732883833; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=CyQKgN06PGUD+AXir6DHOe7QB+SHUhoCcRgC8Zwcdyc=; b=fR0LMGK9+S0vs7T79PPGs7+eS548s9rVNVbKlJRHg+KzmDlAVEN7EKFHfPt9zTFJYU HWE3ltSyoyd4vCShRIi5r4ohDiMSio+oDK4ojkZGEKN4Wm0xAwPVDV9nkC/5/cZ/hAGH yDOpWqAJHa0fSARMf46YbUBLgTuI4J8eZCvlRq7Niq0MX1YNwNFXTIUo1w34U1GRSfX1 aw8Xk1jLN165U70Pf9kCI9njHXrfDGNFzuA9vBhm8A7tp42Iee6FRPneE3TkIoSNANAq bY011ixkFLLyWsDcBTDZGtqtf6RGDTH7V+Oy/sJt6FUPerT3bdzs6KpAeKAUG4YAJpTI uCiQ== X-Forwarded-Encrypted: i=1; AJvYcCVIqbR39IkLeOKdNLFHDwQy8Pjau9/2kPq4oUUTEOsR/zyMpqqKQK7FMFHhpyCt7xHzz+u/IH61AbKM@nongnu.org X-Gm-Message-State: AOJu0YwJDxryl9XN7NkyzreFPi9z3/S7nsdWHy2aG5Y3U7Qrn/6dTY0c Qs8qBibxcODGKlpSSCmGzt09Xt2QnFbIO5ocoP7Ag9LtF4dUdx30gvQqLSc6isZ8xholJNijDeG iUXMaBGMD2itjbJFszFHlIFnz0DHakUpCXtU+rGigxH0bYzqbsKJ7 X-Gm-Gg: ASbGncvCSO4cHF6hSfExuTH8DFKw5JqhAp4Q15ujPVlSlnk5c6LYN9HLRQYGY0GtQbt fmySW7Mn4w3TlpgOsa0+oKEjrFGzLC2ejhhuhRcjDzjoIdeEQ+i9HbLxzip94ChorJ3xHTs3s+W PpnO3cgtSaClAZFWqqPQmKCP5hsVOEbq0el/1L/p9Vv2c3BpJa+By1SnFeATDUcfQBz8ElHU+Ae wu0RBuL0wWFy0c6KEbBUrHyGCfVNncRfooGPurMy5xdlh0QQw81NwAbsYppYLyYpDgu5f3pWVk= X-Received: by 2002:a05:600c:3593:b0:431:55af:a22f with SMTP id 5b1f17b1804b1-433ce425069mr24304845e9.13.1732279033481; Fri, 22 Nov 2024 04:37:13 -0800 (PST) X-Google-Smtp-Source: AGHT+IESz0W85o7Bd32cbw6VHQvveIbuUYfOrQ1IDL5uCxew+ikPK7r98IwuHKni3UPHGwmOcFpldQ== X-Received: by 2002:a05:600c:3593:b0:431:55af:a22f with SMTP id 5b1f17b1804b1-433ce425069mr24304515e9.13.1732279033080; Fri, 22 Nov 2024 04:37:13 -0800 (PST) Received: from [10.33.192.206] (nat-pool-str-t.redhat.com. [149.14.88.106]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-433cde0db3csm26076995e9.10.2024.11.22.04.37.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Nov 2024 04:37:12 -0800 (PST) Message-ID: Date: Fri, 22 Nov 2024 13:37:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/3] hw/scsi: Cleanup around scsi_bus_legacy_handle_cmdline() To: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, "Michael S. Tsirkin" , Mark Cave-Ayland , Aleksandar Rikalo , Harsh Prateek Bora , qemu-ppc@nongnu.org, Laurent Vivier , =?UTF-8?Q?Herv=C3=A9_Poussineau?= , Artyom Tarasenko , Richard Henderson , Thomas Huth , Peter Maydell , Paolo Bonzini , Fam Zheng , Helge Deller , Daniel Henrique Barboza , Nicholas Piggin , Marcel Apfelbaum References: <20241122111939.11936-1-philmd@linaro.org> From: Thomas Huth Content-Language: en-US Autocrypt: addr=thuth@redhat.com; keydata= xsFNBFH7eUwBEACzyOXKU+5Pcs6wNpKzrlJwzRl3VGZt95VCdb+FgoU9g11m7FWcOafrVRwU yYkTm9+7zBUc0sW5AuPGR/dp3pSLX/yFWsA/UB4nJsHqgDvDU7BImSeiTrnpMOTXb7Arw2a2 4CflIyFqjCpfDM4MuTmzTjXq4Uov1giGE9X6viNo1pxyEpd7PanlKNnf4PqEQp06X4IgUacW tSGj6Gcns1bCuHV8OPWLkf4hkRnu8hdL6i60Yxz4E6TqlrpxsfYwLXgEeswPHOA6Mn4Cso9O 0lewVYfFfsmokfAVMKWzOl1Sr0KGI5T9CpmRfAiSHpthhHWnECcJFwl72NTi6kUcUzG4se81 O6n9d/kTj7pzTmBdfwuOZ0YUSqcqs0W+l1NcASSYZQaDoD3/SLk+nqVeCBB4OnYOGhgmIHNW 0CwMRO/GK+20alxzk//V9GmIM2ACElbfF8+Uug3pqiHkVnKqM7W9/S1NH2qmxB6zMiJUHlTH gnVeZX0dgH27mzstcF786uPcdEqS0KJuxh2kk5IvUSL3Qn3ZgmgdxBMyCPciD/1cb7/Ahazr 3ThHQXSHXkH/aDXdfLsKVuwDzHLVSkdSnZdt5HHh75/NFHxwaTlydgfHmFFwodK8y/TjyiGZ zg2Kje38xnz8zKn9iesFBCcONXS7txENTzX0z80WKBhK+XSFJwARAQABzR5UaG9tYXMgSHV0 aCA8dGh1dGhAcmVkaGF0LmNvbT7CwXgEEwECACIFAlVgX6oCGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAAoJEC7Z13T+cC21EbIP/ii9cvT2HHGbFRl8HqGT6+7Wkb+XLMqJBMAIGiQK QIP3xk1HPTsLfVG0ao4hy/oYkGNOP8+ubLnZen6Yq3zAFiMhQ44lvgigDYJo3Ve59gfe99KX EbtB+X95ODARkq0McR6OAsPNJ7gpEUzfkQUUJTXRDQXfG/FX303Gvk+YU0spm2tsIKPl6AmV 1CegDljzjycyfJbk418MQmMu2T82kjrkEofUO2a24ed3VGC0/Uz//XCR2ZTo+vBoBUQl41BD eFFtoCSrzo3yPFS+w5fkH9NT8ChdpSlbNS32NhYQhJtr9zjWyFRf0Zk+T/1P7ECn6gTEkp5k ofFIA4MFBc/fXbaDRtBmPB0N9pqTFApIUI4vuFPPO0JDrII9dLwZ6lO9EKiwuVlvr1wwzsgq zJTPBU3qHaUO4d/8G+gD7AL/6T4zi8Jo/GmjBsnYaTzbm94lf0CjXjsOX3seMhaE6WAZOQQG tZHAO1kAPWpaxne+wtgMKthyPLNwelLf+xzGvrIKvLX6QuLoWMnWldu22z2ICVnLQChlR9d6 WW8QFEpo/FK7omuS8KvvopFcOOdlbFMM8Y/8vBgVMSsK6fsYUhruny/PahprPbYGiNIhKqz7 UvgyZVl4pBFjTaz/SbimTk210vIlkDyy1WuS8Zsn0htv4+jQPgo9rqFE4mipJjy/iboDzsFN BFH7eUwBEAC2nzfUeeI8dv0C4qrfCPze6NkryUflEut9WwHhfXCLjtvCjnoGqFelH/PE9NF4 4VPSCdvD1SSmFVzu6T9qWdcwMSaC+e7G/z0/AhBfqTeosAF5XvKQlAb9ZPkdDr7YN0a1XDfa +NgA+JZB4ROyBZFFAwNHT+HCnyzy0v9Sh3BgJJwfpXHH2l3LfncvV8rgFv0bvdr70U+On2XH 5bApOyW1WpIG5KPJlDdzcQTyptOJ1dnEHfwnABEfzI3dNf63rlxsGouX/NFRRRNqkdClQR3K gCwciaXfZ7ir7fF0u1N2UuLsWA8Ei1JrNypk+MRxhbvdQC4tyZCZ8mVDk+QOK6pyK2f4rMf/ WmqxNTtAVmNuZIwnJdjRMMSs4W4w6N/bRvpqtykSqx7VXcgqtv6eqoDZrNuhGbekQA0sAnCJ VPArerAZGArm63o39me/bRUQeQVSxEBmg66yshF9HkcUPGVeC4B0TPwz+HFcVhheo6hoJjLq knFOPLRj+0h+ZL+D0GenyqD3CyuyeTT5dGcNU9qT74bdSr20k/CklvI7S9yoQje8BeQAHtdV cvO8XCLrpGuw9SgOS7OP5oI26a0548M4KldAY+kqX6XVphEw3/6U1KTf7WxW5zYLTtadjISB X9xsRWSU+Yqs3C7oN5TIPSoj9tXMoxZkCIHWvnqGwZ7JhwARAQABwsFfBBgBAgAJBQJR+3lM AhsMAAoJEC7Z13T+cC21hPAQAIsBL9MdGpdEpvXs9CYrBkd6tS9mbaSWj6XBDfA1AEdQkBOn ZH1Qt7HJesk+qNSnLv6+jP4VwqK5AFMrKJ6IjE7jqgzGxtcZnvSjeDGPF1h2CKZQPpTw890k fy18AvgFHkVk2Oylyexw3aOBsXg6ukN44vIFqPoc+YSU0+0QIdYJp/XFsgWxnFIMYwDpxSHS 5fdDxUjsk3UBHZx+IhFjs2siVZi5wnHIqM7eK9abr2cK2weInTBwXwqVWjsXZ4tq5+jQrwDK cvxIcwXdUTLGxc4/Z/VRH1PZSvfQxdxMGmNTGaXVNfdFZjm4fz0mz+OUi6AHC4CZpwnsliGV ODqwX8Y1zic9viSTbKS01ZNp175POyWViUk9qisPZB7ypfSIVSEULrL347qY/hm9ahhqmn17 Ng255syASv3ehvX7iwWDfzXbA0/TVaqwa1YIkec+/8miicV0zMP9siRcYQkyTqSzaTFBBmqD oiT+z+/E59qj/EKfyce3sbC9XLjXv3mHMrq1tKX4G7IJGnS989E/fg6crv6NHae9Ckm7+lSs IQu4bBP2GxiRQ+NV3iV/KU3ebMRzqIC//DCOxzQNFNJAKldPe/bKZMCxEqtVoRkuJtNdp/5a yXFZ6TfE1hGKrDBYAm4vrnZ4CXFSBDllL59cFFOJCkn4Xboj/aVxxJxF30bn In-Reply-To: <20241122111939.11936-1-philmd@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.143, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 22/11/2024 12.19, Philippe Mathieu-Daudé wrote: > When a device model requires legacy command line handling, > call scsi_bus_legacy_handle_cmdline() in its realize handler > instead of having each user call it. > > This applies to: > - spapr_vscsi > - lsi53c810 / lsi53c895a > - sysbus_esp > > Note, scsi_bus_legacy_handle_cmdline() prototype could be > made private to hw/scsi/ to restrict its use to scsi device > implementations. Not sure whether this is the right way to go ... shouldn't the handling of the legacy command line be rather part of the machine than being part of the SCSI controller device? Imagine for example a machine that has multiple, different SCSI controllers - I think you'd rather want to let the machine decide where the legacy devices should be grabbed from than having the SCSI controller devices fight for them...? Thomas