From: Gavin Shan <gshan@redhat.com>
To: Andrew Jones <drjones@redhat.com>
Cc: robh@kernel.org, qemu-riscv@nongnu.org, ehabkost@redhat.com,
peter.maydell@linaro.org, qemu-devel@nongnu.org,
qemu-arm@nongnu.org, shan.gavin@gmail.com,
Igor Mammedov <imammedo@redhat.com>
Subject: Re: [PATCH v3 1/2] numa: Require distance map when empty node exists
Date: Fri, 15 Oct 2021 21:51:07 +1100 [thread overview]
Message-ID: <f199b132-7db1-0f1d-dd52-49355d38db3a@redhat.com> (raw)
In-Reply-To: <20211015083359.j5t2xt7cfdjqbzlm@gator>
Hi Drew,
On 10/15/21 7:33 PM, Andrew Jones wrote:
> On Fri, Oct 15, 2021 at 07:22:05PM +1100, Gavin Shan wrote:
>> It's possible that the empty NUMA nodes aren't referred by any CPUs,
>> as the following command line indicate. In this case, the empty NUMA
>> node IDs aren't existing in device-tree CPU nodes. So we still need
>> the distance-map.
>
> Ah, indeed.
>
>>
>> However, I would like to drop this (PATCH[01/02]) in v4. The memory
>> hotplug through device-tree on ARM64 isn't existing. We might have
>> alternative ways to present the empty NUMA nodes when it's supported,
>> or we needn't it for ever because ACPI is enough to support the
>> memory hotplug.
>
> Agreed. Please update the commit message of 2/2 for v4 and also add
> a comment above the new code with the rationale for dropping those
> memory nodes.
>
v4 was posted for review. Your r-b tag was dropped as the additional
comments are added. Please take a look on v4 and sorry for having
taken so much time from you :)
Thanks,
Gavin
next prev parent reply other threads:[~2021-10-15 10:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-13 4:58 [PATCH v3 0/2] hw/arm/virt: Fix qemu booting failure on device-tree Gavin Shan
2021-10-13 4:58 ` [PATCH v3 1/2] numa: Require distance map when empty node exists Gavin Shan
2021-10-13 6:35 ` Andrew Jones
2021-10-13 11:30 ` Igor Mammedov
2021-10-13 11:35 ` Andrew Jones
2021-10-13 11:53 ` Igor Mammedov
2021-10-13 12:11 ` Andrew Jones
2021-10-13 12:28 ` Andrew Jones
2021-10-14 15:14 ` Igor Mammedov
2021-10-14 15:36 ` Andrew Jones
2021-10-15 8:22 ` Gavin Shan
2021-10-15 8:33 ` Andrew Jones
2021-10-15 10:51 ` Gavin Shan [this message]
2021-10-13 4:58 ` [PATCH v3 2/2] hw/arm/virt: Don't create device-tree node for empty NUMA node Gavin Shan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f199b132-7db1-0f1d-dd52-49355d38db3a@redhat.com \
--to=gshan@redhat.com \
--cc=drjones@redhat.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=robh@kernel.org \
--cc=shan.gavin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).