From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
pbonzini@redhat.com, fam@euphon.net, laurent@vivier.eu,
qemu-devel@nongnu.org
Subject: Re: [PATCH v3 03/17] esp.c: replace esp_fifo_pop_buf() with esp_fifo8_pop_buf() in do_message_phase()
Date: Mon, 25 Mar 2024 11:21:38 +0100 [thread overview]
Message-ID: <f1a377f3-904d-487b-9737-bc361982443f@linaro.org> (raw)
In-Reply-To: <20240324191707.623175-4-mark.cave-ayland@ilande.co.uk>
On 24/3/24 20:16, Mark Cave-Ayland wrote:
> The aim is to restrict the esp_fifo_*() functions so that they only operate on
> the hardware FIFO. When reading from cmdfifo in do_message_phase() use the
> underlying esp_fifo8_pop_buf() function directly.
>
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> ---
> hw/scsi/esp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2024-03-25 10:22 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-24 19:16 [PATCH v3 00/17] [for-9.0] esp: avoid explicit setting of DRQ within ESP state machine Mark Cave-Ayland
2024-03-24 19:16 ` [PATCH v3 01/17] esp.c: move esp_fifo_pop_buf() internals to new esp_fifo8_pop_buf() function Mark Cave-Ayland
2024-03-25 10:20 ` Philippe Mathieu-Daudé
2024-03-24 19:16 ` [PATCH v3 02/17] esp.c: replace esp_fifo_pop_buf() with esp_fifo8_pop_buf() in do_command_phase() Mark Cave-Ayland
2024-03-25 10:21 ` Philippe Mathieu-Daudé
2024-03-24 19:16 ` [PATCH v3 03/17] esp.c: replace esp_fifo_pop_buf() with esp_fifo8_pop_buf() in do_message_phase() Mark Cave-Ayland
2024-03-25 10:21 ` Philippe Mathieu-Daudé [this message]
2024-03-24 19:16 ` [PATCH v3 04/17] esp.c: replace cmdfifo use of esp_fifo_pop() " Mark Cave-Ayland
2024-03-24 19:16 ` [PATCH v3 05/17] esp.c: change esp_fifo_push() to take ESPState Mark Cave-Ayland
2024-03-24 19:16 ` [PATCH v3 06/17] esp.c: change esp_fifo_pop() " Mark Cave-Ayland
2024-03-24 19:16 ` [PATCH v3 07/17] esp.c: use esp_fifo_push() instead of fifo8_push() Mark Cave-Ayland
2024-03-24 19:16 ` [PATCH v3 08/17] esp.c: change esp_fifo_pop_buf() to take ESPState Mark Cave-Ayland
2024-03-24 19:16 ` [PATCH v3 09/17] esp.c: introduce esp_fifo_push_buf() function for pushing to the FIFO Mark Cave-Ayland
2024-03-24 19:16 ` [PATCH v3 10/17] esp.c: don't assert() if FIFO empty when executing non-DMA SELATNS Mark Cave-Ayland
2024-03-25 10:49 ` Philippe Mathieu-Daudé
2024-03-25 12:57 ` Mark Cave-Ayland
2024-04-02 11:34 ` Philippe Mathieu-Daudé
2024-03-24 19:17 ` [PATCH v3 11/17] esp.c: rework esp_cdb_length() into esp_cdb_ready() Mark Cave-Ayland
2024-04-02 11:38 ` Philippe Mathieu-Daudé
2024-03-24 19:17 ` [PATCH v3 12/17] esp.c: prevent cmdfifo overflow in esp_cdb_ready() Mark Cave-Ayland
2024-03-25 10:26 ` Philippe Mathieu-Daudé
2024-03-25 12:41 ` Mark Cave-Ayland
2024-04-02 11:36 ` Philippe Mathieu-Daudé
2024-03-24 19:17 ` [PATCH v3 13/17] esp.c: move esp_set_phase() and esp_get_phase() towards the beginning of the file Mark Cave-Ayland
2024-03-24 19:17 ` [PATCH v3 14/17] esp.c: introduce esp_update_drq() and update esp_fifo_{push, pop}_buf() to use it Mark Cave-Ayland
2024-03-24 19:17 ` [PATCH v3 15/17] esp.c: update esp_fifo_{push, pop}() to call esp_update_drq() Mark Cave-Ayland
2024-03-24 19:17 ` [PATCH v3 16/17] esp.c: ensure esp_pdma_write() always calls esp_fifo_push() Mark Cave-Ayland
2024-03-24 19:17 ` [PATCH v3 17/17] esp.c: remove explicit setting of DRQ within ESP state machine Mark Cave-Ayland
2024-04-04 10:04 ` [PATCH v3 00/17] [for-9.0] esp: avoid " Paolo Bonzini
2024-04-04 10:28 ` Philippe Mathieu-Daudé
2024-04-04 12:53 ` Mark Cave-Ayland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1a377f3-904d-487b-9737-bc361982443f@linaro.org \
--to=philmd@linaro.org \
--cc=fam@euphon.net \
--cc=laurent@vivier.eu \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).