From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60240) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g7g8L-0002Cx-Fx for qemu-devel@nongnu.org; Wed, 03 Oct 2018 08:20:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g7g8K-0003it-Pv for qemu-devel@nongnu.org; Wed, 03 Oct 2018 08:20:05 -0400 References: <20181002230218.13949-1-jsnow@redhat.com> <20181002230218.13949-2-jsnow@redhat.com> From: Eric Blake Message-ID: Date: Wed, 3 Oct 2018 07:19:38 -0500 MIME-Version: 1.0 In-Reply-To: <20181002230218.13949-2-jsnow@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 1/6] block/dirty-bitmaps: add user_locked status checker List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , qemu-devel@nongnu.org, qemu-block@nongnu.org Cc: Markus Armbruster , "Dr. David Alan Gilbert" , Kevin Wolf , Juan Quintela , Paolo Bonzini , vsementsov@virtuozzo.com, Fam Zheng , Max Reitz , Stefan Hajnoczi On 10/2/18 6:02 PM, John Snow wrote: > Instead of both frozen and qmp_locked checks, wrap it into one check. > frozen implies the bitmap is split in two (for backup), and shouldn't > be modified. qmp_locked implies it's being used by another operation, > like being exported over NBD. In both cases it means we shouldn't allow > the user to modify it in any meaningful way. > > Replace any usages where we check both frozen and qmp_locked with the > new check. > > Signed-off-by: John Snow > --- > block/dirty-bitmap.c | 6 ++++++ > blockdev.c | 29 ++++++++--------------------- > include/block/dirty-bitmap.h | 1 + > migration/block-dirty-bitmap.c | 10 ++-------- > 4 files changed, 17 insertions(+), 29 deletions(-) > Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org