From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 95652C48BF8 for ; Mon, 19 Feb 2024 19:19:08 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rc99K-0006MJ-5T; Mon, 19 Feb 2024 14:17:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rc99I-0006M2-NQ for qemu-devel@nongnu.org; Mon, 19 Feb 2024 14:17:56 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rc99B-0000X9-BJ for qemu-devel@nongnu.org; Mon, 19 Feb 2024 14:17:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1708370267; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=NwiQkEwOG6LbNPmAzzxh595rsI0mMzgttr1IYB9A4gA=; b=MohOCVZVeH335XPm/EWuq/xGYr4pIdQcA46U3Jxp2tt1kmrurH8z1FCFJ5oTtAVnRXqcuW C9TFQ0A/KVUhDWgwnqAvc2U/wl2PFbkqZ9ExS0KkVKFSl4DXpPLlYvDK6FU0XC+vpeaw12 b3qgkLejBrGf7U2C5aPkrzx0uFy6DTU= Received: from mail-oi1-f197.google.com (mail-oi1-f197.google.com [209.85.167.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-464-GKt86TEvM1SXvmlmouE-dg-1; Mon, 19 Feb 2024 14:17:46 -0500 X-MC-Unique: GKt86TEvM1SXvmlmouE-dg-1 Received: by mail-oi1-f197.google.com with SMTP id 5614622812f47-3c15074df25so2364623b6e.0 for ; Mon, 19 Feb 2024 11:17:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708370265; x=1708975065; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NwiQkEwOG6LbNPmAzzxh595rsI0mMzgttr1IYB9A4gA=; b=mc4Ym80TExQb6xyXk3mrwiQrOxRHcD99urI4gGLZyE994banLqPNzetWdBVkpV0IYc /QKmSuiu4OkobHNtvibqzHIGdIwAND9qtHAfGkv9I7hFaRofhMiLDT7BGoZFQ4Q8ouwJ UPk1UbMYLxBuChjY8jjIQ1ydOLrgO0pC6lO5gWPSJDZXFnALOu7tYshcpKyjO2EJ/Cde pCg+tafUJH36VoHEJU+Va1Mma19AsfDRdZkJ7ZkGvCUAgc8mUmIc2jyVVeU0894v65Ob USnxV7M79nlKjk6fBC1Wtfn9SKHeS6lsuQ6TerOS/raLI43QoGL98UCn7rrnpkd/YO3x RsrQ== X-Forwarded-Encrypted: i=1; AJvYcCVsYftkG1sayiW3YNntvZY8+0H6jwQO2tTICzfSo/Cgi+LyS39C/MPkObWEAbVYNe+PpvakWpYmrTlxvnqYcqvMpqF42KI= X-Gm-Message-State: AOJu0YxWgLQaeEoZBkQHQZ7SUfEQ2vc/jVM7vTdoBXv2gqTR0djmZb5L DTUsSjLO2jnohN8PIbe4TCKSrRQlvXDspbf7hTPUOevUrHDegOonpmale/SpMIBfg0fDObM04RM aiwDUCqlBaiipKZWHAPGiSz/c390i65uXloXSMG4GCpSaBMjvfelV X-Received: by 2002:a05:6808:140e:b0:3c0:371d:3504 with SMTP id w14-20020a056808140e00b003c0371d3504mr15110503oiv.5.1708370265281; Mon, 19 Feb 2024 11:17:45 -0800 (PST) X-Google-Smtp-Source: AGHT+IGr9W0G0Dq+p8oNiF8xnpfv1HEmjNw7MrABPZOeKlSJbbSr8PQ3XtbTyuuRV4lSqO2MAzLqrw== X-Received: by 2002:a05:6808:140e:b0:3c0:371d:3504 with SMTP id w14-20020a056808140e00b003c0371d3504mr15110488oiv.5.1708370264983; Mon, 19 Feb 2024 11:17:44 -0800 (PST) Received: from [192.168.0.9] (ip-109-43-177-48.web.vodafone.de. [109.43.177.48]) by smtp.gmail.com with ESMTPSA id on12-20020a056214448c00b0068f51bfb6c8sm2765580qvb.132.2024.02.19.11.17.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Feb 2024 11:17:44 -0800 (PST) Message-ID: Date: Mon, 19 Feb 2024 20:17:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/7] hw/ide: Move IDE device related definitions to ide-dev.h Content-Language: en-US To: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , John Snow , qemu-devel@nongnu.org Cc: BALATON Zoltan , qemu-block@nongnu.org References: <20240219104912.378211-1-thuth@redhat.com> <20240219104912.378211-4-thuth@redhat.com> From: Thomas Huth Autocrypt: addr=thuth@redhat.com; keydata= xsFNBFH7eUwBEACzyOXKU+5Pcs6wNpKzrlJwzRl3VGZt95VCdb+FgoU9g11m7FWcOafrVRwU yYkTm9+7zBUc0sW5AuPGR/dp3pSLX/yFWsA/UB4nJsHqgDvDU7BImSeiTrnpMOTXb7Arw2a2 4CflIyFqjCpfDM4MuTmzTjXq4Uov1giGE9X6viNo1pxyEpd7PanlKNnf4PqEQp06X4IgUacW tSGj6Gcns1bCuHV8OPWLkf4hkRnu8hdL6i60Yxz4E6TqlrpxsfYwLXgEeswPHOA6Mn4Cso9O 0lewVYfFfsmokfAVMKWzOl1Sr0KGI5T9CpmRfAiSHpthhHWnECcJFwl72NTi6kUcUzG4se81 O6n9d/kTj7pzTmBdfwuOZ0YUSqcqs0W+l1NcASSYZQaDoD3/SLk+nqVeCBB4OnYOGhgmIHNW 0CwMRO/GK+20alxzk//V9GmIM2ACElbfF8+Uug3pqiHkVnKqM7W9/S1NH2qmxB6zMiJUHlTH gnVeZX0dgH27mzstcF786uPcdEqS0KJuxh2kk5IvUSL3Qn3ZgmgdxBMyCPciD/1cb7/Ahazr 3ThHQXSHXkH/aDXdfLsKVuwDzHLVSkdSnZdt5HHh75/NFHxwaTlydgfHmFFwodK8y/TjyiGZ zg2Kje38xnz8zKn9iesFBCcONXS7txENTzX0z80WKBhK+XSFJwARAQABzR5UaG9tYXMgSHV0 aCA8dGh1dGhAcmVkaGF0LmNvbT7CwXgEEwECACIFAlVgX6oCGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAAoJEC7Z13T+cC21EbIP/ii9cvT2HHGbFRl8HqGT6+7Wkb+XLMqJBMAIGiQK QIP3xk1HPTsLfVG0ao4hy/oYkGNOP8+ubLnZen6Yq3zAFiMhQ44lvgigDYJo3Ve59gfe99KX EbtB+X95ODARkq0McR6OAsPNJ7gpEUzfkQUUJTXRDQXfG/FX303Gvk+YU0spm2tsIKPl6AmV 1CegDljzjycyfJbk418MQmMu2T82kjrkEofUO2a24ed3VGC0/Uz//XCR2ZTo+vBoBUQl41BD eFFtoCSrzo3yPFS+w5fkH9NT8ChdpSlbNS32NhYQhJtr9zjWyFRf0Zk+T/1P7ECn6gTEkp5k ofFIA4MFBc/fXbaDRtBmPB0N9pqTFApIUI4vuFPPO0JDrII9dLwZ6lO9EKiwuVlvr1wwzsgq zJTPBU3qHaUO4d/8G+gD7AL/6T4zi8Jo/GmjBsnYaTzbm94lf0CjXjsOX3seMhaE6WAZOQQG tZHAO1kAPWpaxne+wtgMKthyPLNwelLf+xzGvrIKvLX6QuLoWMnWldu22z2ICVnLQChlR9d6 WW8QFEpo/FK7omuS8KvvopFcOOdlbFMM8Y/8vBgVMSsK6fsYUhruny/PahprPbYGiNIhKqz7 UvgyZVl4pBFjTaz/SbimTk210vIlkDyy1WuS8Zsn0htv4+jQPgo9rqFE4mipJjy/iboDzsFN BFH7eUwBEAC2nzfUeeI8dv0C4qrfCPze6NkryUflEut9WwHhfXCLjtvCjnoGqFelH/PE9NF4 4VPSCdvD1SSmFVzu6T9qWdcwMSaC+e7G/z0/AhBfqTeosAF5XvKQlAb9ZPkdDr7YN0a1XDfa +NgA+JZB4ROyBZFFAwNHT+HCnyzy0v9Sh3BgJJwfpXHH2l3LfncvV8rgFv0bvdr70U+On2XH 5bApOyW1WpIG5KPJlDdzcQTyptOJ1dnEHfwnABEfzI3dNf63rlxsGouX/NFRRRNqkdClQR3K gCwciaXfZ7ir7fF0u1N2UuLsWA8Ei1JrNypk+MRxhbvdQC4tyZCZ8mVDk+QOK6pyK2f4rMf/ WmqxNTtAVmNuZIwnJdjRMMSs4W4w6N/bRvpqtykSqx7VXcgqtv6eqoDZrNuhGbekQA0sAnCJ VPArerAZGArm63o39me/bRUQeQVSxEBmg66yshF9HkcUPGVeC4B0TPwz+HFcVhheo6hoJjLq knFOPLRj+0h+ZL+D0GenyqD3CyuyeTT5dGcNU9qT74bdSr20k/CklvI7S9yoQje8BeQAHtdV cvO8XCLrpGuw9SgOS7OP5oI26a0548M4KldAY+kqX6XVphEw3/6U1KTf7WxW5zYLTtadjISB X9xsRWSU+Yqs3C7oN5TIPSoj9tXMoxZkCIHWvnqGwZ7JhwARAQABwsFfBBgBAgAJBQJR+3lM AhsMAAoJEC7Z13T+cC21hPAQAIsBL9MdGpdEpvXs9CYrBkd6tS9mbaSWj6XBDfA1AEdQkBOn ZH1Qt7HJesk+qNSnLv6+jP4VwqK5AFMrKJ6IjE7jqgzGxtcZnvSjeDGPF1h2CKZQPpTw890k fy18AvgFHkVk2Oylyexw3aOBsXg6ukN44vIFqPoc+YSU0+0QIdYJp/XFsgWxnFIMYwDpxSHS 5fdDxUjsk3UBHZx+IhFjs2siVZi5wnHIqM7eK9abr2cK2weInTBwXwqVWjsXZ4tq5+jQrwDK cvxIcwXdUTLGxc4/Z/VRH1PZSvfQxdxMGmNTGaXVNfdFZjm4fz0mz+OUi6AHC4CZpwnsliGV ODqwX8Y1zic9viSTbKS01ZNp175POyWViUk9qisPZB7ypfSIVSEULrL347qY/hm9ahhqmn17 Ng255syASv3ehvX7iwWDfzXbA0/TVaqwa1YIkec+/8miicV0zMP9siRcYQkyTqSzaTFBBmqD oiT+z+/E59qj/EKfyce3sbC9XLjXv3mHMrq1tKX4G7IJGnS989E/fg6crv6NHae9Ckm7+lSs IQu4bBP2GxiRQ+NV3iV/KU3ebMRzqIC//DCOxzQNFNJAKldPe/bKZMCxEqtVoRkuJtNdp/5a yXFZ6TfE1hGKrDBYAm4vrnZ4CXFSBDllL59cFFOJCkn4Xboj/aVxxJxF30bn In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.072, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 19/02/2024 12.32, Philippe Mathieu-Daudé wrote: > On 19/2/24 11:49, Thomas Huth wrote: >> Let's start to unentangle internal.h by moving public IDE device >> related definitions to ide-dev.h. >> >> Signed-off-by: Thomas Huth >> --- >>   include/hw/ide/ide-dev.h  | 145 +++++++++++++++++++++++++++++++++++++- >>   include/hw/ide/internal.h | 145 +------------------------------------- >>   hw/ide/ide-dev.c          |   1 + >>   3 files changed, 146 insertions(+), 145 deletions(-) >> >> diff --git a/include/hw/ide/ide-dev.h b/include/hw/ide/ide-dev.h >> index 7e9663cda9..de88784a25 100644 >> --- a/include/hw/ide/ide-dev.h >> +++ b/include/hw/ide/ide-dev.h >> @@ -20,9 +20,152 @@ >>   #ifndef IDE_DEV_H >>   #define IDE_DEV_H >> +#include "sysemu/dma.h" > > Not required. It's required for QEMUSGList that is used in struct IDEState. >>   #include "hw/qdev-properties.h" >>   #include "hw/block/block.h" >> -#include "hw/ide/internal.h" >> + >> +typedef struct IDEDevice IDEDevice; >> +typedef struct IDEState IDEState; > >> +typedef struct IDEDMA IDEDMA; >> +typedef struct IDEDMAOps IDEDMAOps; >> +typedef struct IDEBus IDEBus; > > Looking at next patches, better forward-declare IDEBus and > IDEDMA in "qemu/typedefs.h". I really dislike using qemu/typedefs.h for things that are not really part of the core framework, since it's a touch-it-once-and-everything-gets-recompiled header. So IMHO the typedefs here are the lesser evil. > IDEDMAOps and "sysemu/dma.h" belong to "hw/ide/ide-dma.h. Ok, I can move the typedef for IDEDMAOps to ide-dma.h instead. Thomas