qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Thomas Huth <thuth@redhat.com>,
	Qemu-block <qemu-block@nongnu.org>,
	QEMU Developers <qemu-devel@nongnu.org>
Cc: Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>,
	Nir Soffer <nirsof@gmail.com>
Subject: Re: [Qemu-devel] Failing QEMU iotest 175
Date: Thu, 2 May 2019 16:56:16 -0500	[thread overview]
Message-ID: <f1dfe2c3-2d61-e477-ac3d-37ad26d9236d@redhat.com> (raw)
In-Reply-To: <68cc5bbc-ed6f-e001-e376-ccd986683b88@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1222 bytes --]

On 4/28/19 10:18 AM, Thomas Huth wrote:
> QEMU iotest 175 is failing for me when I run it with -raw:
> 

>  == creating image with default preallocation ==
>  Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=1048576
> -size=1048576, blocks=0
> +size=1048576, blocks=2

What filesystem? It should be fairly obvious that 'stat -c blocks=%b' is
file-system dependent (some allocate slightly more or less space, based
on granularities and on predictions of future use), so we may need to
update the test to apply a filter or otherwise allow a bit of fuzz in
the answer. But 0/2 is definitely different than...
> 
>  == creating image with preallocation off ==
>  Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=1048576 preallocation=off
> -size=1048576, blocks=0
> +size=1048576, blocks=2
> 
>  == creating image with preallocation full ==
>  Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=1048576 preallocation=full
> -size=1048576, blocks=2048
> +size=1048576, blocks=2050

2048/2050, so we DO have some indication of whether the file is sparse
or fully allocated.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Eric Blake <eblake@redhat.com>
To: Thomas Huth <thuth@redhat.com>,
	Qemu-block <qemu-block@nongnu.org>,
	QEMU Developers <qemu-devel@nongnu.org>
Cc: Kevin Wolf <kwolf@redhat.com>, Nir Soffer <nirsof@gmail.com>,
	Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] Failing QEMU iotest 175
Date: Thu, 2 May 2019 16:56:16 -0500	[thread overview]
Message-ID: <f1dfe2c3-2d61-e477-ac3d-37ad26d9236d@redhat.com> (raw)
Message-ID: <20190502215616.2KtrwVXlmRA9pES4YpoZ5OA4rEK__MUKkzI7cjltwdc@z> (raw)
In-Reply-To: <68cc5bbc-ed6f-e001-e376-ccd986683b88@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1222 bytes --]

On 4/28/19 10:18 AM, Thomas Huth wrote:
> QEMU iotest 175 is failing for me when I run it with -raw:
> 

>  == creating image with default preallocation ==
>  Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=1048576
> -size=1048576, blocks=0
> +size=1048576, blocks=2

What filesystem? It should be fairly obvious that 'stat -c blocks=%b' is
file-system dependent (some allocate slightly more or less space, based
on granularities and on predictions of future use), so we may need to
update the test to apply a filter or otherwise allow a bit of fuzz in
the answer. But 0/2 is definitely different than...
> 
>  == creating image with preallocation off ==
>  Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=1048576 preallocation=off
> -size=1048576, blocks=0
> +size=1048576, blocks=2
> 
>  == creating image with preallocation full ==
>  Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=1048576 preallocation=full
> -size=1048576, blocks=2048
> +size=1048576, blocks=2050

2048/2050, so we DO have some indication of whether the file is sparse
or fully allocated.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  parent reply	other threads:[~2019-05-02 21:56 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-28 15:18 [Qemu-devel] Failing QEMU iotest 175 Thomas Huth
2019-04-28 15:18 ` Thomas Huth
2019-05-02 21:56 ` Eric Blake [this message]
2019-05-02 21:56   ` Eric Blake
2019-05-03  4:37   ` Thomas Huth
2019-05-03  4:37     ` Thomas Huth
2019-05-03 20:21     ` Eric Blake
2019-05-03 20:21       ` Eric Blake
2019-05-03 21:31       ` Nir Soffer
2019-05-03 21:31         ` Nir Soffer
2019-05-10 21:15         ` [Qemu-devel] [Qemu-block] " Nir Soffer
2019-05-04  6:51       ` [Qemu-devel] " Thomas Huth
2019-05-04  6:51         ` Thomas Huth
2019-05-06 17:44         ` Eric Blake
2019-05-15 14:56           ` Stefan Hajnoczi
2019-05-10 13:54 ` Max Reitz
2019-05-10 16:42   ` Thomas Huth
2019-05-10 17:39     ` Max Reitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f1dfe2c3-2d61-e477-ac3d-37ad26d9236d@redhat.com \
    --to=eblake@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=nirsof@gmail.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).